All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: Paolo Abeni <pabeni@redhat.com>, mptcp@lists.linux.dev
Cc: Geliang Tang <geliangtang@gmail.com>
Subject: Re: [PATCH v3 mptcp-next 0/3] mptcp: minor out optimization
Date: Wed, 28 Jul 2021 10:09:31 +0200	[thread overview]
Message-ID: <aca30f71-bc68-7e33-65c5-c5bcb79fd043@tessares.net> (raw)
In-Reply-To: <cover.1627296764.git.pabeni@redhat.com>

Hi Paolo, Geliang, Mat,

On 26/07/2021 12:55, Paolo Abeni wrote:
> This series implements a few ideas discussed in the past mtg,
> specifcally:
> 
> https://github.com/multipath-tcp/mptcp_net-next/issues/15
> https://github.com/multipath-tcp/mptcp_net-next/issues/42

Should we close any of them? e.g. the issue #15?

> The final goal is shrink the mptcp_out_options struct, which is
> always zeroed by the plain TCP protocol in the output path.

Thank you for looking at that!

> This iteration covers the feedback provided by Geliang (many thanks!)
> on v1:
>  - some code moved to new squash-to patch 1/3
>  - some cleanup in 2/3

And thanks Geliang for the notes about the conflicts!

> please see the individual patch changelog for the details
> 
> Paolo Abeni (3):
>   Squash-to: "mptcp: move drop_other_suboptions check under pm lock"
>   mptcp: optimize out option generation
>   mptcp: shrink mptcp_out_options struct

Thank you for the patches, reviews and tests!

I split the series in two: the squash-to patch first and then the two
new patches.

Part 1: squash-to + update commit msg:

- 9030cfa001f6: "squashed" (with conflicts) in "mptcp: move
drop_other_suboptions check under pm lock"
- fb6c1d39264e: "Signed-off-by" + "Co-developed-by"
- b6a51f709e5b: tg: update msg after having applied 1 squash-to patch
- a4f59d64a674: conflict in
t/mptcp-remove-MPTCP_ADD_ADDR_IPV6-and-MPTCP_ADD_ADDR_PORT
- Results: 49320b30c955..14a78d3af24a

Builds and tests are now in progress:



https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20210728T074049

https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export/20210728T074049


Part 2: new patches with Mat's RvB tag and a few checkpatch fixes:

- ef6b13c8bbad: mptcp: optimize out option generation
- 7547285ef776: mptcp: shrink mptcp_out_options struct
- Results: 14a78d3af24a..4c599993729d

Builds and tests are now in progress:



https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20210728T080904

https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export/20210728T080904

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net

  parent reply	other threads:[~2021-07-28  8:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-26 10:55 [PATCH v3 mptcp-next 0/3] mptcp: minor out optimization Paolo Abeni
2021-07-26 10:55 ` [PATCH v3 mptcp-next 1/3] Squash-to: "mptcp: move drop_other_suboptions check under pm lock" Paolo Abeni
2021-07-27  4:27   ` Geliang Tang
2021-07-26 10:55 ` [PATCH v3 mptcp-next 2/3] mptcp: optimize out option generation Paolo Abeni
2021-07-27  4:33   ` Geliang Tang
2021-07-26 10:55 ` [PATCH v3 mptcp-next 3/3] mptcp: shrink mptcp_out_options struct Paolo Abeni
2021-07-28  0:40 ` [PATCH v3 mptcp-next 0/3] mptcp: minor out optimization Mat Martineau
2021-07-28  8:09 ` Matthieu Baerts [this message]
2021-07-28 10:46   ` Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aca30f71-bc68-7e33-65c5-c5bcb79fd043@tessares.net \
    --to=matthieu.baerts@tessares.net \
    --cc=geliangtang@gmail.com \
    --cc=mptcp@lists.linux.dev \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.