From: Alex Elder <elder@linaro.org>
To: "Krzysztof Wilczyński" <kw@linux.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
linux-pci@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Pavel Machek <pavel@ucw.cz>,
linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
Kevin Hilman <khilman@kernel.org>,
Julian Wiedmann <jwi@linux.ibm.com>,
linux-acpi@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Len Brown <lenb@kernel.org>,
linux-pm@vger.kernel.org,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Ursula Braun <ubraun@linux.ibm.com>,
Johan Hovold <johan@kernel.org>,
greybus-dev@lists.linaro.org,
John Stultz <john.stultz@linaro.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Felipe Balbi <balbi@kernel.org>, Alex Elder <elder@kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Karsten Graul <kgraul@linux.ibm.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [greybus-dev] [PATCH 8/8] net/iucv: Use the new device_to_pm() helper to access struct dev_pm_ops
Date: Tue, 26 May 2020 11:48:12 -0500 [thread overview]
Message-ID: <acb9415a-d0d0-3ebc-b5ae-c26a7dc2114a@linaro.org> (raw)
In-Reply-To: <20200526150744.GC75990@rocinante>
On 5/26/20 10:07 AM, Krzysztof Wilczyński wrote:
> Hello Greg,
>
> [...]
>> It's "interesting" how using your new helper doesn't actually make the
>> code smaller. Perhaps it isn't a good helper function?
Helper functions often improve code readability, which is
beneficial even if it doesn't reduce code size or efficiency.
But I won't argue for or against this particular change.
It's OK with me either way.
-Alex
> The idea for the helper was inspired by the comment Dan made to Bjorn
> about Bjorn's change, as per:
>
> https://lore.kernel.org/driverdev-devel/20191016135002.GA24678@kadam/
>
> It looked like a good idea to try to reduce the following:
>
> dev->driver && dev->driver->pm && dev->driver->pm->prepare
>
> Into something more succinct. Albeit, given the feedback from yourself
> and Rafael, I gather that this helper is not really a good addition.
>
> Thank you everyone and sorry for the commotion!
>
> Krzysztof
> _______________________________________________
> greybus-dev mailing list
> greybus-dev@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/greybus-dev
>
next prev parent reply other threads:[~2020-05-26 16:48 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 18:26 [PATCH 0/8] Add helper for accessing Power Management callbacs Krzysztof Wilczyński
2020-05-25 18:26 ` [PATCH 1/8] driver core: " Krzysztof Wilczyński
2020-05-26 6:33 ` Greg Kroah-Hartman
2020-05-26 11:53 ` [greybus-dev] " Alex Elder
2020-05-26 15:01 ` Krzysztof Wilczyński
2020-05-25 18:26 ` [PATCH 2/8] ACPI: PM: Use the new device_to_pm() helper to access struct dev_pm_ops Krzysztof Wilczyński
2020-05-26 8:37 ` Rafael J. Wysocki
2020-05-26 8:37 ` Rafael J. Wysocki
2020-05-26 9:45 ` Pavel Machek
2020-05-26 10:35 ` Rafael J. Wysocki
2020-05-25 18:26 ` [PATCH 3/8] greybus: " Krzysztof Wilczyński
2020-05-26 11:53 ` [greybus-dev] " Alex Elder
2020-05-25 18:26 ` [PATCH 4/8] scsi: pm: " Krzysztof Wilczyński
2020-05-25 18:26 ` [PATCH 5/8] usb: phy: fsl: " Krzysztof Wilczyński
2020-05-26 8:38 ` Rafael J. Wysocki
2020-05-26 8:38 ` Rafael J. Wysocki
2020-05-25 18:26 ` [PATCH 6/8] PCI/PM: " Krzysztof Wilczyński
2020-05-25 18:26 ` [PATCH 7/8] PM: " Krzysztof Wilczyński
2020-05-26 8:33 ` Rafael J. Wysocki
2020-05-26 8:33 ` Rafael J. Wysocki
2020-05-25 18:26 ` [PATCH 8/8] net/iucv: " Krzysztof Wilczyński
2020-05-26 6:35 ` Greg Kroah-Hartman
2020-05-26 15:07 ` Krzysztof Wilczyński
2020-05-26 15:19 ` Rafael J. Wysocki
2020-05-26 15:19 ` Rafael J. Wysocki
2020-05-26 15:28 ` Alan Stern
2020-05-26 16:06 ` Rafael J. Wysocki
2020-05-26 16:48 ` Alex Elder [this message]
2020-05-26 7:07 ` Ursula Braun
2020-05-26 14:57 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acb9415a-d0d0-3ebc-b5ae-c26a7dc2114a@linaro.org \
--to=elder@linaro.org \
--cc=balbi@kernel.org \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=jejb@linux.ibm.com \
--cc=johan@kernel.org \
--cc=john.stultz@linaro.org \
--cc=jwi@linux.ibm.com \
--cc=kgraul@linux.ibm.com \
--cc=khilman@kernel.org \
--cc=kuba@kernel.org \
--cc=kw@linux.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=ubraun@linux.ibm.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.