All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xose Vazquez Perez <xose.vazquez@gmail.com>
To: Martin Wilck <mwilck@suse.com>,
	Benjamin Marzinski <bmarzins@redhat.com>,
	Hannes Reinecke <hare@suse.de>, DM-DEVEL ML <dm-devel@redhat.com>
Subject: [PATCH RFC] multipath-tools: *untested* use sysfs prio also for arrays with dual implicit/explicit alua support
Date: Sat, 25 Jul 2020 00:34:27 +0200	[thread overview]
Message-ID: <acc2f009-c4b8-0c09-c77c-9400aac38cb1@gmail.com> (raw)


Cc: Martin Wilck <mwilck@suse.com>
Cc: Benjamin Marzinski <bmarzins@redhat.com>
Cc: Hannes Reinecke <hare@suse.de>
Cc: DM-DEVEL ML <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
diff --git a/libmultipath/propsel.c b/libmultipath/propsel.c
index 897e48ca..5a82234f 100644
--- a/libmultipath/propsel.c
+++ b/libmultipath/propsel.c
@@ -595,7 +595,7 @@ detect_prio(struct config *conf, struct path * pp)
  		tpgs = path_get_tpgs(pp);
  		if (tpgs == TPGS_NONE)
  			return;
-		if ((tpgs == TPGS_EXPLICIT || !check_rdac(pp)) &&
+		if ((tpgs == TPGS_EXPLICIT || tpgs == TPGS_BOTH || !check_rdac(pp)) &&
  		    sysfs_get_asymmetric_access_state(pp, buff, 512) >= 0)
  			default_prio = PRIO_SYSFS;
  		else

In short:

diff --git a/libmultipath/propsel.c b/libmultipath/propsel.c
index 897e48ca..a9609a01 100644
--- a/libmultipath/propsel.c
+++ b/libmultipath/propsel.c
@@ -595,7 +595,7 @@ detect_prio(struct config *conf, struct path * pp)
  		tpgs = path_get_tpgs(pp);
  		if (tpgs == TPGS_NONE)
  			return;
-		if ((tpgs == TPGS_EXPLICIT || !check_rdac(pp)) &&
+		if ((tpgs != TPGS_IMPLICIT || !check_rdac(pp)) &&
  		    sysfs_get_asymmetric_access_state(pp, buff, 512) >= 0)
  			default_prio = PRIO_SYSFS;
  		else

             reply	other threads:[~2020-07-24 22:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-24 22:34 Xose Vazquez Perez [this message]
2020-08-05 21:12 ` [PATCH RFC] multipath-tools: *untested* use sysfs prio also for arrays with dual implicit/explicit alua support Martin Wilck
2020-08-10 21:27   ` Schremmer, Steven
2020-08-11  9:52     ` Martin Wilck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acc2f009-c4b8-0c09-c77c-9400aac38cb1@gmail.com \
    --to=xose.vazquez@gmail.com \
    --cc=bmarzins@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=hare@suse.de \
    --cc=mwilck@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.