All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Bayduraev <alexey.v.bayduraev@linux.intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Andi Kleen <ak@linux.intel.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Alexander Antonov <alexander.antonov@linux.intel.com>,
	Alexei Budankov <abudankov@huawei.com>,
	Riccardo Mancini <rickyman7@gmail.com>
Subject: [PATCH v12 10/16] perf record: Introduce compressor at mmap buffer object
Date: Tue, 23 Nov 2021 17:08:06 +0300	[thread overview]
Message-ID: <acc377ad465a002b48ea01b460415ae94c51460a.1637675515.git.alexey.v.bayduraev@linux.intel.com> (raw)
In-Reply-To: <cover.1637675515.git.alexey.v.bayduraev@linux.intel.com>

Introduce compressor object into mmap object so it could be used to
pack the data stream from the corresponding kernel data buffer.
Initialize and make use of the introduced per mmap compressor.

Acked-by: Andi Kleen <ak@linux.intel.com>
Acked-by: Namhyung Kim <namhyung@gmail.com>
Signed-off-by: Alexey Bayduraev <alexey.v.bayduraev@linux.intel.com>
---
 tools/perf/builtin-record.c | 18 +++++++++++-------
 tools/perf/util/mmap.c      | 10 ++++++++++
 tools/perf/util/mmap.h      |  2 ++
 3 files changed, 23 insertions(+), 7 deletions(-)

diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index cd4f74c311e8..1581da48fa9b 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -243,8 +243,8 @@ static int record__write(struct record *rec, struct mmap *map __maybe_unused,
 
 static int record__aio_enabled(struct record *rec);
 static int record__comp_enabled(struct record *rec);
-static size_t zstd_compress(struct perf_session *session, void *dst, size_t dst_size,
-			    void *src, size_t src_size);
+static size_t zstd_compress(struct perf_session *session, struct mmap *map,
+			    void *dst, size_t dst_size, void *src, size_t src_size);
 
 #ifdef HAVE_AIO_SUPPORT
 static int record__aio_write(struct aiocb *cblock, int trace_fd,
@@ -378,7 +378,7 @@ static int record__aio_pushfn(struct mmap *map, void *to, void *buf, size_t size
 	 */
 
 	if (record__comp_enabled(aio->rec)) {
-		size = zstd_compress(aio->rec->session, aio->data + aio->size,
+		size = zstd_compress(aio->rec->session, NULL, aio->data + aio->size,
 				     mmap__mmap_len(map) - aio->size,
 				     buf, size);
 	} else {
@@ -605,7 +605,7 @@ static int record__pushfn(struct mmap *map, void *to, void *bf, size_t size)
 	struct record *rec = to;
 
 	if (record__comp_enabled(rec)) {
-		size = zstd_compress(rec->session, map->data, mmap__mmap_len(map), bf, size);
+		size = zstd_compress(rec->session, map, map->data, mmap__mmap_len(map), bf, size);
 		bf   = map->data;
 	}
 
@@ -1398,13 +1398,17 @@ static size_t process_comp_header(void *record, size_t increment)
 	return size;
 }
 
-static size_t zstd_compress(struct perf_session *session, void *dst, size_t dst_size,
-			    void *src, size_t src_size)
+static size_t zstd_compress(struct perf_session *session, struct mmap *map,
+			    void *dst, size_t dst_size, void *src, size_t src_size)
 {
 	size_t compressed;
 	size_t max_record_size = PERF_SAMPLE_MAX_SIZE - sizeof(struct perf_record_compressed) - 1;
+	struct zstd_data *zstd_data = &session->zstd_data;
 
-	compressed = zstd_compress_stream_to_records(&session->zstd_data, dst, dst_size, src, src_size,
+	if (map && map->file)
+		zstd_data = &map->zstd_data;
+
+	compressed = zstd_compress_stream_to_records(zstd_data, dst, dst_size, src, src_size,
 						     max_record_size, process_comp_header);
 
 	session->bytes_transferred += src_size;
diff --git a/tools/perf/util/mmap.c b/tools/perf/util/mmap.c
index 23ecdba9e670..e0e95abfc983 100644
--- a/tools/perf/util/mmap.c
+++ b/tools/perf/util/mmap.c
@@ -230,6 +230,10 @@ void mmap__munmap(struct mmap *map)
 {
 	bitmap_free(map->affinity_mask.bits);
 
+#ifndef PYTHON_PERF
+	zstd_fini(&map->zstd_data);
+#endif
+
 	perf_mmap__aio_munmap(map);
 	if (map->data != NULL) {
 		munmap(map->data, mmap__mmap_len(map));
@@ -291,6 +295,12 @@ int mmap__mmap(struct mmap *map, struct mmap_params *mp, int fd, int cpu)
 	map->core.flush = mp->flush;
 
 	map->comp_level = mp->comp_level;
+#ifndef PYTHON_PERF
+	if (zstd_init(&map->zstd_data, map->comp_level)) {
+		pr_debug2("failed to init mmap commpressor, error %d\n", errno);
+		return -1;
+	}
+#endif
 
 	if (map->comp_level && !perf_mmap__aio_enabled(map)) {
 		map->data = mmap(NULL, mmap__mmap_len(map), PROT_READ|PROT_WRITE,
diff --git a/tools/perf/util/mmap.h b/tools/perf/util/mmap.h
index a3370a8bf307..9e4d3965641a 100644
--- a/tools/perf/util/mmap.h
+++ b/tools/perf/util/mmap.h
@@ -14,6 +14,7 @@
 #endif
 #include "auxtrace.h"
 #include "event.h"
+#include "util/compress.h"
 
 struct aiocb;
 
@@ -45,6 +46,7 @@ struct mmap {
 	void		*data;
 	int		comp_level;
 	struct perf_data_file *file;
+	struct zstd_data      zstd_data;
 };
 
 struct mmap_params {
-- 
2.19.0


  parent reply	other threads:[~2021-11-23 14:10 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-23 14:07 [PATCH v12 00/16] Introduce threaded trace streaming for basic perf record operation Alexey Bayduraev
2021-11-23 14:07 ` [PATCH v12 01/16] perf record: Introduce thread affinity and mmap masks Alexey Bayduraev
2021-12-05 15:13   ` Jiri Olsa
2021-12-20 10:37     ` Bayduraev, Alexey V
2021-11-23 14:07 ` [PATCH v12 02/16] tools lib: Introduce fdarray duplicate function Alexey Bayduraev
2021-11-23 14:07 ` [PATCH v12 03/16] perf record: Introduce thread specific data array Alexey Bayduraev
2021-11-23 14:08 ` [PATCH v12 04/16] perf record: Introduce function to propagate control commands Alexey Bayduraev
2021-11-23 14:08 ` [PATCH v12 05/16] perf record: Introduce thread local variable Alexey Bayduraev
2021-12-05 15:14   ` Jiri Olsa
2021-12-20  9:49     ` Bayduraev, Alexey V
2021-11-23 14:08 ` [PATCH v12 06/16] perf record: Stop threads in the end of trace streaming Alexey Bayduraev
2021-11-23 14:08 ` [PATCH v12 07/16] perf record: Start threads in the beginning " Alexey Bayduraev
2021-11-23 14:08 ` [PATCH v12 08/16] perf record: Introduce data file at mmap buffer object Alexey Bayduraev
2021-12-05 15:14   ` Jiri Olsa
2021-11-23 14:08 ` [PATCH v12 09/16] perf record: Introduce bytes written stats Alexey Bayduraev
2021-12-05 15:14   ` Jiri Olsa
2021-12-06 11:22     ` Bayduraev, Alexey V
2021-11-23 14:08 ` Alexey Bayduraev [this message]
2021-11-23 14:08 ` [PATCH v12 11/16] perf record: Introduce data transferred and compressed stats Alexey Bayduraev
2021-11-23 14:08 ` [PATCH v12 12/16] perf record: Introduce --threads command line option Alexey Bayduraev
2021-11-23 14:08 ` [PATCH v12 13/16] perf record: Extend " Alexey Bayduraev
2021-12-05 15:13   ` Jiri Olsa
2021-12-05 15:14   ` Jiri Olsa
2021-12-05 15:14   ` Jiri Olsa
2021-12-05 15:14   ` Jiri Olsa
2021-11-23 14:08 ` [PATCH v12 14/16] perf record: Implement compatibility checks Alexey Bayduraev
2021-11-23 14:08 ` [PATCH v12 15/16] perf session: Load data directory files for analysis Alexey Bayduraev
2021-11-23 14:08 ` [PATCH v12 16/16] perf report: Output data file name in raw trace dump Alexey Bayduraev
2021-12-05 15:15 ` [PATCH v12 00/16] Introduce threaded trace streaming for basic perf record operation Jiri Olsa
2021-12-09 17:56   ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acc377ad465a002b48ea01b460415ae94c51460a.1637675515.git.alexey.v.bayduraev@linux.intel.com \
    --to=alexey.v.bayduraev@linux.intel.com \
    --cc=abudankov@huawei.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.antonov@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rickyman7@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.