All of lore.kernel.org
 help / color / mirror / Atom feed
From: Derrick Stolee <derrickstolee@github.com>
To: Kevin Locke <kevin@kevinlocke.name>,
	Elijah Newren <newren@gmail.com>,
	Junio C Hamano <gitster@pobox.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] setup: don't die if realpath(3) fails on getcwd(3)
Date: Mon, 23 May 2022 14:44:27 -0400	[thread overview]
Message-ID: <acc3c765-7476-ae00-1546-f6cc07fb5c75@github.com> (raw)
In-Reply-To: <Yoji02YhO+sE817q@kevinlocke.name>

On 5/21/22 9:02 AM, Kevin Locke wrote:
> Thanks Elijah and Junio,
> 
> I appreciate your reviews.  I agree with all of your suggestions. I'll
> send a revised patch that incorporates the suggested changes shortly.
> 
> Cheers,
> Kevin
> 
> 
> On Fri, 2022-05-20 at 17:14 -0700, Elijah Newren wrote:
>> On Thu, May 19, 2022 at 4:39 PM Kevin Locke <kevin@kevinlocke.name> wrote:

Hi Kevin,

Welcome to the Git mailing list!

One minor thing to keep in mind is that we try to avoid
top-posting.

A few other things that were mentioned in this v1 would
be noticed by reading a few documents in the tree:

 * Documentation/CodingGuidelines
 * Documentation/MyFirstContribution.txt
 * Documentation/SubmittingPatches

There's A LOT in there, so we all forget some of the
things some of the time.

Thanks,
-Stolee

  reply	other threads:[~2022-05-23 19:07 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-19 23:39 [PATCH] setup: don't die if realpath(3) fails on getcwd(3) Kevin Locke
2022-05-20 18:38 ` Junio C Hamano
2022-05-21  0:14 ` Elijah Newren
2022-05-21 13:02   ` Kevin Locke
2022-05-23 18:44     ` Derrick Stolee [this message]
2022-05-21 13:53 ` [PATCH v2] " Kevin Locke
2022-05-23 18:57   ` Derrick Stolee
2022-05-24 14:02     ` Kevin Locke
2022-05-24 15:20       ` Elijah Newren
2022-05-24 17:38         ` Derrick Stolee
2022-05-25  3:47           ` Elijah Newren
2022-05-27  7:48         ` Ævar Arnfjörð Bjarmason
2022-05-28  1:27           ` Elijah Newren
2022-05-24 14:51   ` [PATCH v3] " Kevin Locke
2022-05-24 15:21     ` Elijah Newren
2022-05-24 17:41     ` Derrick Stolee
2022-05-24 18:00       ` Kevin Locke
2022-05-24 19:20     ` [PATCH v4] " Kevin Locke
2022-05-24 20:40       ` Derrick Stolee
2022-05-24 21:25       ` Junio C Hamano
2022-05-25  3:51         ` Elijah Newren
2022-05-25  5:11           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acc3c765-7476-ae00-1546-f6cc07fb5c75@github.com \
    --to=derrickstolee@github.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kevin@kevinlocke.name \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.