From: Arnout Vandecappelle <arnout@mind.be>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>,
buildroot@buildroot.org
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>,
Mahyar Koshkouei <mahyar.koshkouei@gmail.com>
Subject: Re: [Buildroot] [PATCH] package/ffmpeg: fix build on mips_32
Date: Wed, 22 Sep 2021 22:34:57 +0200 [thread overview]
Message-ID: <acc54600-0ace-c758-ae9e-afc04f30977b@mind.be> (raw)
In-Reply-To: <20210913204551.2328033-1-giulio.benetti@benettiengineering.com>
On 13/09/2021 22:45, Giulio Benetti wrote:
> mips_32 is not supported by ffmpeg and it tries to build with loongson3
> SIMD support that leads to build failure due to:
> /tmp/ccFO2LRa.s: Assembler messages:
> /tmp/ccFO2LRa.s:15314: Error: opcode not supported on this processor: mips32 (mips32) `dmult $2,$6'
> /tmp/ccFO2LRa.s:15316: Error: opcode not supported on this processor: mips32 (mips32) `dsrl $2,$2,32'
I don't think *any* of the archs we define in Config.in.mips supports these
instructions... It's just that these are the only ones we test in the autobuilders.
>
> So let's --disable-asm to prevent using those unsupported opcodes.
>
> Fixes:
> http://autobuild.buildroot.net/results/f01/f01d9cedec8e1b371308d0f7af561a75883fa27c/
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> package/ffmpeg/ffmpeg.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/ffmpeg/ffmpeg.mk b/package/ffmpeg/ffmpeg.mk
> index 8ff8ea8c6c..5e405d0f60 100644
> --- a/package/ffmpeg/ffmpeg.mk
> +++ b/package/ffmpeg/ffmpeg.mk
> @@ -508,7 +508,7 @@ FFMPEG_CONF_OPTS += --enable-mipsfpu
> endif
>
> # Fix build failure on "addi opcode not supported"
> -ifeq ($(BR2_mips_32r6)$(BR2_mips_64r6),y)
> +ifeq ($(BR2_mips_32)$(BR2_mips_32r6)$(BR2_mips_64r6),y)
> FFMPEG_CONF_OPTS += --disable-asm
Given that mips seems so problematic, I think it's best to disable asm on mips
in general, not even for specific subarches.
If someone needs some specific subarch to be optimized, they can give us a
(tested!) patch that enables asm again for that specific subarch.
Regards,
Arnout
> endif
> endif # MIPS
>
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2021-09-22 20:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 20:45 [Buildroot] [PATCH] package/ffmpeg: fix build on mips_32 Giulio Benetti
2021-09-22 20:34 ` Arnout Vandecappelle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acc54600-0ace-c758-ae9e-afc04f30977b@mind.be \
--to=arnout@mind.be \
--cc=bernd.kuhls@t-online.de \
--cc=buildroot@buildroot.org \
--cc=giulio.benetti@benettiengineering.com \
--cc=mahyar.koshkouei@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.