From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Alexandru Stefan ISAILA <aisaila@bitdefender.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
"jbeulich@suse.com" <jbeulich@suse.com>
Cc: "paul.durrant@citrix.com" <paul.durrant@citrix.com>
Subject: Re: [PATCH v5] x86/hvm: Implement hvmemul_write() using real mappings
Date: Wed, 27 Sep 2017 13:11:05 +0100 [thread overview]
Message-ID: <acd6903e-6e35-6012-47fa-02e3eb181bc4@citrix.com> (raw)
In-Reply-To: <1506512898.26526.19.camel@bitdefender.com>
On 27/09/17 12:48, Alexandru Stefan ISAILA wrote:
> On Mi, 2017-09-27 at 09:38 +0100, Andrew Cooper wrote:
>> On 27/09/2017 09:04, Alexandru Isaila wrote:
>>> From: Andrew Cooper <andrew.cooper3@citrix.com>
>>>
>>>
>>> - return X86EMUL_EXCEPTION;
>>> - case HVMTRANS_bad_gfn_to_mfn:
>>> - return hvmemul_linear_mmio_write(addr, bytes, p_data,
>>> pfec, hvmemul_ctxt, 0);
>> Where has the if ( !mapping ) test gone? The HVMTRANS_bad_gfn_to_mfn
>> case needs handling.
> There was a comment form Jan in V2. NOTE: "v1
> comment:'Pointless"else".'"
That means that the "else " text is pointless, not the clause. (Jan:
Please do try to be clearer when stating "pointless else", because it
really is ambiguous and this mistake is a valid interpretation of your
statement.)
The call to hvmemul_linear_mmio_write(addr, bytes, p_data, pfec,
hvmemul_ctxt, 0); is important, and needs to stay.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-09-27 12:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 8:04 [PATCH v5] x86/hvm: Implement hvmemul_write() using real mappings Alexandru Isaila
2017-09-27 8:38 ` Andrew Cooper
2017-09-27 9:16 ` Jan Beulich
2017-09-27 11:48 ` Alexandru Stefan ISAILA
2017-09-27 12:11 ` Andrew Cooper [this message]
2017-09-27 12:40 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acd6903e-6e35-6012-47fa-02e3eb181bc4@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=aisaila@bitdefender.com \
--cc=jbeulich@suse.com \
--cc=paul.durrant@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.