From: Shannon Nelson <snelson@pensando.io>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH net-next 2/2] ionic: prevent early watchdog check
Date: Tue, 29 Sep 2020 17:17:45 -0700 [thread overview]
Message-ID: <ace43069-fb8e-a4e8-af96-30d59c5e86d3@pensando.io> (raw)
In-Reply-To: <20200929171521.654fdef9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 9/29/20 5:15 PM, Jakub Kicinski wrote:
> On Tue, 29 Sep 2020 15:19:56 -0700 Shannon Nelson wrote:
>> In one corner case scenario, the driver device lif setup can
>> get delayed such that the ionic_watchdog_cb() timer goes off
>> before the ionic->lif is set, thus causing a NULL pointer panic.
>> We catch the problem by checking for a NULL lif just a little
>> earlier in the callback.
>>
>> Signed-off-by: Shannon Nelson <snelson@pensando.io>
> Hah, I should have looked at the second patch :D
Am I making my patches too small now? :-)
sln
next prev parent reply other threads:[~2020-09-30 0:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 22:19 [PATCH net-next 0/2] ionic watchdog training Shannon Nelson
2020-09-29 22:19 ` [PATCH net-next 1/2] ionic: stop watchdog timer earlier on remove Shannon Nelson
2020-09-30 0:15 ` Jakub Kicinski
2020-09-29 22:19 ` [PATCH net-next 2/2] ionic: prevent early watchdog check Shannon Nelson
2020-09-30 0:15 ` Jakub Kicinski
2020-09-30 0:17 ` Shannon Nelson [this message]
2020-09-30 0:26 ` Jakub Kicinski
2020-09-30 1:20 ` [PATCH net-next 0/2] ionic watchdog training David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ace43069-fb8e-a4e8-af96-30d59c5e86d3@pensando.io \
--to=snelson@pensando.io \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.