From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E24B2C4332F for ; Mon, 25 Oct 2021 14:22:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C722060F46 for ; Mon, 25 Oct 2021 14:22:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233502AbhJYOYj (ORCPT ); Mon, 25 Oct 2021 10:24:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:44010 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233493AbhJYOYg (ORCPT ); Mon, 25 Oct 2021 10:24:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635171734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HpaqUtGVB++dG0RuCTiBEYznGy9v/KDIt/5yYlz7/xg=; b=AWDyRtmXaPlPbYzj8fAN5bBexxIM6tuTRoW6wwZGk+WGblmxKtG5MyTVuWylZenb9CA0CL i3pU9wOQo2Tirj2iPAchWCF5sByL4bwwPAHxREgMydhUAgJL4u0zMm8U0923aU6Y6Dtp1H x+tl8/aF8EeAZhDeHJmG5ZMxHB0IO/c= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-48-NILMiXqlMfigrGEAzqvmYA-1; Mon, 25 Oct 2021 10:22:13 -0400 X-MC-Unique: NILMiXqlMfigrGEAzqvmYA-1 Received: by mail-wr1-f70.google.com with SMTP id i3-20020a5d5223000000b00167f0515e90so2757365wra.4 for ; Mon, 25 Oct 2021 07:22:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=HpaqUtGVB++dG0RuCTiBEYznGy9v/KDIt/5yYlz7/xg=; b=vQbuWgJJOO6AiCIhbu8DfiBFh7mmJUEa7dY8kXEIigugBx+5SaKkysHm+UCMHGiLHI rxy4dz0ugGKm1rdBNzZqteJdkyf9JJwyqeOv5Npvx+v/d6qsLDIyp2Rn9raoiru7AGrL mWUTCng+Dd6q1L/pGmE+6vq6xRUrly3xuDTu4DVEkum97qPY2aXLbOQfDBLo67tRZics HJZtknNbZnAHSpMU+eXFihRAZPkuEn7D14GUaHKHcB7Cd8tbCPBVuDAyJU8z6X8RTqYP PTM8CdJatjdkAup2p+ykRq6Ih5k8zW0+WO/VOzTf7eTDu0EyDkvq0rifkbrbDD7pzY24 YZxg== X-Gm-Message-State: AOAM532si50eSTZm4ewl4IQ55GOi3h44qZJfKq7gTticUFrrtqPIAEVJ kGEJhNAopR3cLf2TbpJU6mPloYflAvfdhy14VmZ/9LbpSAf5f0AX9NpLtAPPwBOo/rpWDR4cML+ FpBIbewmxiAMVvJC+c6SJf91D X-Received: by 2002:adf:ef8f:: with SMTP id d15mr23887309wro.72.1635171731940; Mon, 25 Oct 2021 07:22:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzadqpNa9sRFm6T5pRsCXL5a0VdPZvR+Z2HC9JjGJpxIRL6ejj2cNhckiUN6d6SszWigGu00w== X-Received: by 2002:adf:ef8f:: with SMTP id d15mr23887262wro.72.1635171731758; Mon, 25 Oct 2021 07:22:11 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id v6sm2568505wrx.17.2021.10.25.07.22.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Oct 2021 07:22:10 -0700 (PDT) Message-ID: Date: Mon, 25 Oct 2021 16:22:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v2 37/43] KVM: SVM: Unconditionally mark AVIC as running on vCPU load (with APICv) Content-Language: en-US To: Sean Christopherson , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank Cc: James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , Oliver Upton , Jing Zhang References: <20211009021236.4122790-1-seanjc@google.com> <20211009021236.4122790-38-seanjc@google.com> From: Paolo Bonzini In-Reply-To: <20211009021236.4122790-38-seanjc@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/10/21 04:12, Sean Christopherson wrote: > + /* TODO: Document why the unblocking path checks for updates. */ Is that a riddle or what? :) Paolo > + if (kvm_vcpu_is_blocking(vcpu) && > + kvm_check_request(KVM_REQ_APICV_UPDATE, vcpu)) { > + kvm_vcpu_update_apicv(vcpu); > + > + if (!kvm_vcpu_apicv_active(vcpu)) > + return; > + } > + From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 392C9C433F5 for ; Mon, 25 Oct 2021 14:22:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF18360EC0 for ; Mon, 25 Oct 2021 14:22:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BF18360EC0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kAbdZ4+VBwRrVRZ2pOloyEt0Chb7TqgDOiatVYZ+uNo=; b=UADwiKDy5aclsR VtH+NI60BEHHse1V3UbhVs6Tuv/Rl+VZxV0OtgfCGXdFaHV22SHUKnphvaqk4kTtUOh8XqihZHYzi 3fg/xsWy1Mf2qd1j3KJmrL8VTECuh/BEloLVnJsEvRhUujPKXE6m59s2kRLZ+mI9WBFX12p6JmZ8a rlzUfJw7+axG0Kp1F2pjlRvlsQ3MwZGTsb7CREbcBnT4D+2onCV/ka9F/SpFUV7lKGFjRPFJZRVvF SA+h6K59w0W+jNw68RX882va3s8QDBaRgC/EI3kjX9gpJkObniXjyHETSGVpibczl8XNni12bzB1g Iv4mC0xEuwzvz0NIge1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mf0ri-00GffI-31; Mon, 25 Oct 2021 14:22:18 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mf0rf-00GfeF-Em for linux-riscv@lists.infradead.org; Mon, 25 Oct 2021 14:22:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635171734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HpaqUtGVB++dG0RuCTiBEYznGy9v/KDIt/5yYlz7/xg=; b=AWDyRtmXaPlPbYzj8fAN5bBexxIM6tuTRoW6wwZGk+WGblmxKtG5MyTVuWylZenb9CA0CL i3pU9wOQo2Tirj2iPAchWCF5sByL4bwwPAHxREgMydhUAgJL4u0zMm8U0923aU6Y6Dtp1H x+tl8/aF8EeAZhDeHJmG5ZMxHB0IO/c= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-48-2twSdKJiOXO3M03PCcn82g-1; Mon, 25 Oct 2021 10:22:13 -0400 X-MC-Unique: 2twSdKJiOXO3M03PCcn82g-1 Received: by mail-wr1-f71.google.com with SMTP id n14-20020a5d420e000000b00167c303d862so3284872wrq.9 for ; Mon, 25 Oct 2021 07:22:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=HpaqUtGVB++dG0RuCTiBEYznGy9v/KDIt/5yYlz7/xg=; b=DcGnMWwH14uqSRpXbwBLqlBqnEgDb55ry4iu2T6P1DgwnJ3LGgvsqdG51MRDaezGs4 msPcW+hF9jX0gCVH4de6vr5HE58FddNcP3SF4rXNIreK1FFjSmJSUoXMDBlJaQgkOklv 9/aiST05AQp+8PDgfg4Vl1suMH8JWAs8sSWaGRJxpX7Yxn+n9Ty+sOt8xZk2uBZTvnWj 8SA6YvxVnDGMmwxXnnO4R2qUYR8kFR/Apn5Qhp5RTa+QvzHhYkc4KlSN9ZidmNOL4Coz 7PAYxuV3nV5qlfO+tHAb4j3gA6xClv/M5TfMdui+7qYHLDjXHJ7+B9DxX9YOlTA9ZWQA DVrA== X-Gm-Message-State: AOAM532a3TsFN94z9zTjVZtC7zJ+hvfWKI3Y4FQFmlItiDkR27X+loaB TFVgCXVB3mNrrbLXB4Fkv4/o1OEiwNJE0RZfqLVygwp32EDuNql/CuVPkUx9ZHjsOZb38dntRNd qqCzWyoJe5zCWbcjXws78XhXBQ+ib X-Received: by 2002:adf:ef8f:: with SMTP id d15mr23887290wro.72.1635171731939; Mon, 25 Oct 2021 07:22:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzadqpNa9sRFm6T5pRsCXL5a0VdPZvR+Z2HC9JjGJpxIRL6ejj2cNhckiUN6d6SszWigGu00w== X-Received: by 2002:adf:ef8f:: with SMTP id d15mr23887262wro.72.1635171731758; Mon, 25 Oct 2021 07:22:11 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id v6sm2568505wrx.17.2021.10.25.07.22.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Oct 2021 07:22:10 -0700 (PDT) Message-ID: Date: Mon, 25 Oct 2021 16:22:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v2 37/43] KVM: SVM: Unconditionally mark AVIC as running on vCPU load (with APICv) To: Sean Christopherson , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank Cc: James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , Oliver Upton , Jing Zhang References: <20211009021236.4122790-1-seanjc@google.com> <20211009021236.4122790-38-seanjc@google.com> From: Paolo Bonzini In-Reply-To: <20211009021236.4122790-38-seanjc@google.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211025_072215_592980_6FA61892 X-CRM114-Status: UNSURE ( 7.39 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 09/10/21 04:12, Sean Christopherson wrote: > + /* TODO: Document why the unblocking path checks for updates. */ Is that a riddle or what? :) Paolo > + if (kvm_vcpu_is_blocking(vcpu) && > + kvm_check_request(KVM_REQ_APICV_UPDATE, vcpu)) { > + kvm_vcpu_update_apicv(vcpu); > + > + if (!kvm_vcpu_apicv_active(vcpu)) > + return; > + } > + _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C13D4C433FE for ; Mon, 25 Oct 2021 14:22:18 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 3CB3260F46 for ; Mon, 25 Oct 2021 14:22:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3CB3260F46 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 9BA284B0CC; Mon, 25 Oct 2021 10:22:17 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vjoHTlflP+VM; Mon, 25 Oct 2021 10:22:16 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4708940762; Mon, 25 Oct 2021 10:22:16 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 86DF54025B for ; Mon, 25 Oct 2021 10:22:15 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DCaVm8ON6r4W for ; Mon, 25 Oct 2021 10:22:14 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 8668640256 for ; Mon, 25 Oct 2021 10:22:14 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635171734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HpaqUtGVB++dG0RuCTiBEYznGy9v/KDIt/5yYlz7/xg=; b=AWDyRtmXaPlPbYzj8fAN5bBexxIM6tuTRoW6wwZGk+WGblmxKtG5MyTVuWylZenb9CA0CL i3pU9wOQo2Tirj2iPAchWCF5sByL4bwwPAHxREgMydhUAgJL4u0zMm8U0923aU6Y6Dtp1H x+tl8/aF8EeAZhDeHJmG5ZMxHB0IO/c= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-421-mOf0rRG4P4iESkMMFI3R0g-1; Mon, 25 Oct 2021 10:22:13 -0400 X-MC-Unique: mOf0rRG4P4iESkMMFI3R0g-1 Received: by mail-wr1-f69.google.com with SMTP id j12-20020adf910c000000b0015e4260febdso3245803wrj.20 for ; Mon, 25 Oct 2021 07:22:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=HpaqUtGVB++dG0RuCTiBEYznGy9v/KDIt/5yYlz7/xg=; b=HC6K4nZMxAqzboWhDa5KDNiqR1dBflm1kpLJI4KIO1k7HKLEs9uNGQS67ENJMEIa0G sr8rI4a6yoAm2TSwj4LLw+Q10ldjzul+nvqzOgSXNKcqnFC2Q8jGErur9EYYfroqcnca 13CdZsoNGRevAEYFBQEyePj07OBIXb6xDrLapnQBge7U93rlAcM5RTlZ+Yl1+12DWKze TUS1oDIT9/NhM1RjNp7KZs0+sL3hM69zRXZi0J9AJMLkZSI34QIlrRqFhCnFSQJKgtW/ YZ2AabUUrvd6NoOHuWNZrXt6ffCxQjhLm575hYMqz1mN6SLtubhAri3TsH8rV+78rfzk t9GA== X-Gm-Message-State: AOAM5303eHecbGGh3+bezC9yFiUag5h1FyPS4eB0/eMyUAYC7H3mAe5p wqAl8zHERCDryWhGjWJwlvY/JhPVQCbln8Gwp68Yt22Zulq+iKVT8oyesIToOjt9tHPXiPA8IX0 opT1Zp/ReMldKM94fQS9kLJLg X-Received: by 2002:adf:ef8f:: with SMTP id d15mr23887305wro.72.1635171731940; Mon, 25 Oct 2021 07:22:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzadqpNa9sRFm6T5pRsCXL5a0VdPZvR+Z2HC9JjGJpxIRL6ejj2cNhckiUN6d6SszWigGu00w== X-Received: by 2002:adf:ef8f:: with SMTP id d15mr23887262wro.72.1635171731758; Mon, 25 Oct 2021 07:22:11 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id v6sm2568505wrx.17.2021.10.25.07.22.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Oct 2021 07:22:10 -0700 (PDT) Message-ID: Date: Mon, 25 Oct 2021 16:22:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v2 37/43] KVM: SVM: Unconditionally mark AVIC as running on vCPU load (with APICv) To: Sean Christopherson , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank References: <20211009021236.4122790-1-seanjc@google.com> <20211009021236.4122790-38-seanjc@google.com> From: Paolo Bonzini In-Reply-To: <20211009021236.4122790-38-seanjc@google.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: Wanpeng Li , kvm@vger.kernel.org, David Hildenbrand , linux-kernel@vger.kernel.org, Atish Patra , linux-riscv@lists.infradead.org, Claudio Imbrenda , kvmarm@lists.cs.columbia.edu, Joerg Roedel , kvm-ppc@vger.kernel.org, David Matlack , linux-arm-kernel@lists.infradead.org, Jim Mattson , Cornelia Huck , linux-mips@vger.kernel.org, kvm-riscv@lists.infradead.org, Vitaly Kuznetsov X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 09/10/21 04:12, Sean Christopherson wrote: > + /* TODO: Document why the unblocking path checks for updates. */ Is that a riddle or what? :) Paolo > + if (kvm_vcpu_is_blocking(vcpu) && > + kvm_check_request(KVM_REQ_APICV_UPDATE, vcpu)) { > + kvm_vcpu_update_apicv(vcpu); > + > + if (!kvm_vcpu_apicv_active(vcpu)) > + return; > + } > + _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97495C433EF for ; Mon, 25 Oct 2021 14:23:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5902E60EE3 for ; Mon, 25 Oct 2021 14:23:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5902E60EE3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R2NDhPQJIiETAgo0/7ofebotSWPHYhnKtiAZK/+NpYA=; b=NVtLKTcMCPUXjw 1d/PB6yMKbrPsly6780RSWTseU1DPsX8J0KufAD/Vv2E9fwPz/6PZuS1Otg4jg0xznlH471qDbivG AfdfrEeO2q745uOOBIItmvMIAGQLoWdiwmy4keMXQE70K7R1iYXBzk8GRjbK668GvQN6IQ7vH5CVN +6EnAMAgJz3ujSQevA3cPwrqpQiKQr7UDmLHwEkkBraIhB5q90VhuPXeSgmvps35Qx+2g1SadvldG zxD1nAzCokuWtkHk2vYqCKT4EZv9BMOutsioLvfYtL7oPmyBzNh+J9JYNIT7gPo6vInAT1/3M0emh IOUkMkTTGd++E4loHjaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mf0rl-00GfgL-9y; Mon, 25 Oct 2021 14:22:21 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mf0rh-00Gfeo-4U for linux-arm-kernel@lists.infradead.org; Mon, 25 Oct 2021 14:22:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635171736; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HpaqUtGVB++dG0RuCTiBEYznGy9v/KDIt/5yYlz7/xg=; b=NiT0D/aQ+DSaMi0PBMafE+SOBZtHAJ7fcxhA7AAyEwZed2MoP9OfI4iaOw4nMX5cT2X8vP honAzVQQZ6Hz/g60jCpZquls0ZmBgTy8oreOxTBVZxPWjEHGfm+BMrycC5eR4h/JcKxXkf wapY3gY7VI52uq8yJEqHi1X7ya6Yh3o= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-48-m80fmr75NFaUsr7SM2QcTw-1; Mon, 25 Oct 2021 10:22:13 -0400 X-MC-Unique: m80fmr75NFaUsr7SM2QcTw-1 Received: by mail-wr1-f70.google.com with SMTP id a15-20020a056000188f00b00161068d8461so3289123wri.11 for ; Mon, 25 Oct 2021 07:22:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=HpaqUtGVB++dG0RuCTiBEYznGy9v/KDIt/5yYlz7/xg=; b=brc8wd/9YJsXWIUL7dhuzY9m+B8zanIo3vKij4rrfFaDftgkIT85v9rZiqwwJr4lDM OUqVrdpoyf/mel65MFpCqA9T0AzTYWH2+jOX1q7epJ1qzMaHJfijX/Z2veAoGxqvGBhp cuI2pyiSeTQCzdNFtty1YJwGKzG4n71jVnQZ99Q4fGsdowa54S2CWhWAJVIKdIfntTZn FDrIIN2NVKVTDbiONzdkTvOb+DWHArk/MT9dVceDqhVhpZYuuPWNt2EqmIh+Ky7XPBLO SBu6JlvHm/Dljyj8wOiuYP0alsMZjjw1IENTnrHopMpxNjIjFXrI/3zs7jJYo/z4KQAj 7A6Q== X-Gm-Message-State: AOAM533QxLDGFuRdajtLEhGKKvTkqzWoLXu7HBFylOmDtm0NKl7Tap2r Q6yjKN0uyptD/Xbmn4340/sdFLOx6j2k+P9+4OR0W5TfDeXFoGQSAxDSTUJuH2b3TbXunASzCzz EFdYdLD/ahL0HXurnFDnQrnjOjBfw9MTOYls= X-Received: by 2002:adf:ef8f:: with SMTP id d15mr23887314wro.72.1635171731940; Mon, 25 Oct 2021 07:22:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzadqpNa9sRFm6T5pRsCXL5a0VdPZvR+Z2HC9JjGJpxIRL6ejj2cNhckiUN6d6SszWigGu00w== X-Received: by 2002:adf:ef8f:: with SMTP id d15mr23887262wro.72.1635171731758; Mon, 25 Oct 2021 07:22:11 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id v6sm2568505wrx.17.2021.10.25.07.22.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Oct 2021 07:22:10 -0700 (PDT) Message-ID: Date: Mon, 25 Oct 2021 16:22:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v2 37/43] KVM: SVM: Unconditionally mark AVIC as running on vCPU load (with APICv) To: Sean Christopherson , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank Cc: James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , Oliver Upton , Jing Zhang References: <20211009021236.4122790-1-seanjc@google.com> <20211009021236.4122790-38-seanjc@google.com> From: Paolo Bonzini In-Reply-To: <20211009021236.4122790-38-seanjc@google.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211025_072217_257474_93BB357B X-CRM114-Status: UNSURE ( 8.91 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/10/21 04:12, Sean Christopherson wrote: > + /* TODO: Document why the unblocking path checks for updates. */ Is that a riddle or what? :) Paolo > + if (kvm_vcpu_is_blocking(vcpu) && > + kvm_check_request(KVM_REQ_APICV_UPDATE, vcpu)) { > + kvm_vcpu_update_apicv(vcpu); > + > + if (!kvm_vcpu_apicv_active(vcpu)) > + return; > + } > + _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Date: Mon, 25 Oct 2021 14:22:07 +0000 Subject: Re: [PATCH v2 37/43] KVM: SVM: Unconditionally mark AVIC as running on vCPU load (with APICv) Message-Id: List-Id: References: <20211009021236.4122790-1-seanjc@google.com> <20211009021236.4122790-38-seanjc@google.com> In-Reply-To: <20211009021236.4122790-38-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sean Christopherson , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank Cc: James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , Oliver Upton , Jing Zhang On 09/10/21 04:12, Sean Christopherson wrote: > + /* TODO: Document why the unblocking path checks for updates. */ Is that a riddle or what? :) Paolo > + if (kvm_vcpu_is_blocking(vcpu) && > + kvm_check_request(KVM_REQ_APICV_UPDATE, vcpu)) { > + kvm_vcpu_update_apicv(vcpu); > + > + if (!kvm_vcpu_apicv_active(vcpu)) > + return; > + } > +