From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v4 4/4] doc: add usage doc for ENETC PMD
Date: Mon, 1 Oct 2018 17:00:41 +0100
Message-ID: <aceb847f-cc49-2847-b844-88d442ec0ab3@intel.com>
References: <20180928051647.32341-1-g.singh@nxp.com>
 <20180928074601.4287-1-g.singh@nxp.com>
 <20180928074601.4287-5-g.singh@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: pankaj.chauhan@nxp.com
To: Gagandeep Singh <g.singh@nxp.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id 126E21B3D2
 for <dev@dpdk.org>; Mon,  1 Oct 2018 18:00:43 +0200 (CEST)
In-Reply-To: <20180928074601.4287-5-g.singh@nxp.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/28/2018 8:46 AM, Gagandeep Singh wrote:
> Add enetc usage document to compile and run the
> DPDK application on enetc supported platform.
> This document introduces the enetc driver, supported
> platforms and supported features.
> 
> Signed-off-by: Gagandeep Singh <g.singh@nxp.com>

<...>

> @@ -643,6 +643,13 @@ F: drivers/net/dpaa2/
>  F: doc/guides/nics/dpaa2.rst
>  F: doc/guides/nics/features/dpaa2.ini
>  
> +NXP enetc
> +M: Gagandeep Singh <g.singh@nxp.com>
> +M: Pankaj Chauhan <pankaj.chauhan@nxp.com>
> +F: drivers/net/enetc/

Can you please add above part with patch 1/4, and append rest with this patch.

<...>

> @@ -0,0 +1,11 @@
> +;
> +; Supported features of the 'enetc' network poll mode driver.
> +;
> +; Refer to default.ini for the full list of available PMD features.
> +;
> +[Features]
> +Packet type parsing  = Y
> +Link status          = Y
> +Linux VFIO           = Y
> +ARMv8                = Y
> +Usage doc            = Y

Can you please add .ini file with patch 1/4, so you will need to above
MAINTAINERS part to add .ini file too

And add "Packet type parsing  = Y" part with patch 3/4

<...>

> @@ -156,6 +161,7 @@ The libraries prepended with a plus sign were incremented in this version.
>       librte_pmd_ixgbe.so.2
>       librte_pmd_dpaa2_cmdif.so.1
>       librte_pmd_dpaa2_qdma.so.1
> +   + librte_pmd_enetc.so.1

No need to add this one, there is no API that this PMD provides.