From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751662AbdFIRxa (ORCPT ); Fri, 9 Jun 2017 13:53:30 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:44968 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751545AbdFIRx1 (ORCPT ); Fri, 9 Jun 2017 13:53:27 -0400 Authentication-Results: inbox.ru; dkim=none (message not signed) header.d=none;inbox.ru; dmarc=none action=none header.from=fb.com; Subject: Re: hackbench vs select_idle_sibling; was: [tip:sched/core] sched/fair, cpumask: Export for_each_cpu_wrap() To: Peter Zijlstra , Matt Fleming References: <20170414122005.o35me2h5nowqkxbv@hirez.programming.kicks-ass.net> <20170517105350.hk5m4h4jb6dfr65a@hirez.programming.kicks-ass.net> <20170519150035.GA2879@codeblueprint.co.uk> <20170605130021.GA3339@codeblueprint.co.uk> <20170606092158.wqaianvbyhs5k6xk@hirez.programming.kicks-ass.net> CC: , , , , , , , , , From: Chris Mason Message-ID: Date: Fri, 9 Jun 2017 13:52:06 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170606092158.wqaianvbyhs5k6xk@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [2620:10d:c091:180::304c] X-ClientProxiedBy: BN6PR20CA0068.namprd20.prod.outlook.com (10.171.181.158) To CY4PR15MB1656.namprd15.prod.outlook.com (10.175.120.143) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PR15MB1656: X-MS-Office365-Filtering-Correlation-Id: 075678a6-4639-458d-4676-08d4af604139 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:CY4PR15MB1656; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1656;3:MTtFUmT+EznDXnFc68sLc7omtntNLYa6gJiMp6OyQaUrwAIXkofepQI/1Qn0P/YtoY1+HiPpB1cbvHlsnc7twptCr3APketD8o2uINzUuY4u9B5jB5oaDHi8rJI9wxlvUFP69EJ8u2JIVXcSGAVcT+r6iIyHosjD2FUSjTyBH3pqFk/znbISeaHR9cSkCA3nGXBIwnyun/Zj57h+z98UTGfijrmfqrM0LX1/o3s7oRlzoX9JBpQ/3DDeo1VuvMQn0J1s7Qf7/kpswIgZ3nk9k1u/VpHLbCMAY9q/QPGppo7fntH2QLmGpGdAC2quSHTsgGPAJYIHelqowknPMgmADA==;25:zrf75zeNvjLHb44KFr6KfZ2moZWRXJGfLYdMUXQ773pXtM7UECI3RZhsSooyU5guBQTmvl97mWxilM2C+YsbL+BzfeLgulOYvlnFmNz/6AUGuZ/bigQ/hNI9i60pUXH9vynnw6k+895FLPZehaj2AceNSHl0tChMxoAD/je/cLvr2AGxNNJKGrIp98Hetpg5ZOixK2ntnWQRB7O6K2keGY8bB/jqayQ8tirXlizTBNTDFMdJQvKd9l3Zolw9nNUsRTJC5xwmams5FmXn2XhHY1SFKHS1n+WCWoFkYCjslnW6Oq4bAFkvUjJQcz3g1NwY0GNr70J8sZz4VKA4JiTQ8XR3Rqs/3qvf06MtVMcxTLQd8eZl1GcqDCPPT+pm4/k/IgqBNwAKNwns4CqMfBUfKxziY2I187HwBwWMYykzdBUIDi0qdcfMaj1PYCoykhYg0doB0YpY9v+daH29YzLjm5kvIvdDbhCVKloEOB0+rAo= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1656;31:0DciVcqL87DngKuV2CHq38qaHSINOKeONcUz3cdqD+bBHhtPuNDhm2XpNE0CHzMAZf2+rMYCYhNUj51DCZJ56y6MH8YZgUN6AwCGdYRYZTS3Rsck+EnquUUAYbxvmHTBNe5Dl4u+IAe2cccWHen2pLxCOy0hTueWENEt6ysHRYbGzT2TWbqgw0IJG7cvGugI2PG6la6clM1jrdR4HGLr8a8evjZTq6AR9G71J68+Q8FRDWeppG24GoaHJPiHePmahRqsVVM4/rhB0EBOaevwBA==;20:zVtuRFGx1/dba5nBl8jO32u/OaT+/F2G3ReIaX4TXEi4V1OlXBZ3FpmwvR3oWusk88KiJTWhYZzLOUOaZb3Q3OpVSQ0XIsq644eVG/zvJDSJ2QHTWMHcG25aDfxTCMu44I7gPyAWGZRcAQ13AHuL5gTTGE912797sthwvBbjquVLtmYUDLbIG5VKuo7t708TXc8GLkRMHWqrUr8X1he0Lbb5a3A3ASKgTg51BK3P6GN1k6t5Mo6VWdxizHghJTIocIoJsbcAJIH+viUWq0BLut0cyZf7a9PAef9eYWKzhsEMsyXdEZyaOg7CfotYORJgGv92Ri/t4Nn1vJJ1M+U2V9SUh4SpEgn2ZTgRekZuuq0kdZz90fa3kRAI65eeZZQNac37JzRxwlRKsiCuBVEbXj0FtDovS4IpwCOdT8BV+g5PU9B8TJQsHraZOF4OSQK+NJ6UjEK2ysBAEqJFRmzlLxfYe926RjfaHouAPxOSZt0AGmtEYM1+qpyMjmXH8OGW X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6041248)(20161123564025)(20161123558100)(20161123562025)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY4PR15MB1656;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY4PR15MB1656; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY4PR15MB1656;4:UaUPGXVtGIRj3rTAq3GNXD4SQ1nOorpi46PATd?= =?Windows-1252?Q?ejO/xCaKZolWZcBpZbc5r/zKJhEdavblHkwE+VPVHak4CaOGs7ZQYPnD?= =?Windows-1252?Q?wojlHYC+oVUq2JUa3CdlSCqhyHV1bim3tyDr0fVzETXq0gz5raiSlI8j?= =?Windows-1252?Q?p7hkLZsZnnM6E7DSaLNTSoG7fLGG68HBwH5oHgxyUsPdzI3GCi9OehaQ?= =?Windows-1252?Q?Sv16D6wwtm7YKlE0JyumwdOwE7DSrk0lZQc3q7Yu+oKukx96osZWkPwN?= =?Windows-1252?Q?JRQcoc/7K2JAXf85S1nL4gODAiMgFFMBNu2MRBXFtZpnTu2/UEjkF8SR?= =?Windows-1252?Q?YN7/AzdXJqrXTiXI49cvB28pVr3ZkKnbFDjsEXWl/WSsLGAMjWGPrjOb?= =?Windows-1252?Q?afhVi4wCRzckUKuzr/7vE16L3RebOU5OzbYMiANLB7TEdgavqJ+6HO2c?= =?Windows-1252?Q?adl4KtV0Lta7vaYkk8cIECwGxK+J1P1vnOOxLXExxxbHjUDyrylY/SDW?= =?Windows-1252?Q?w9letp6WZQP7K/zL/DzGepGLHnElyfebIftkyDuKHSHEZWVa4Fx7mFTO?= =?Windows-1252?Q?jz5A2endq5CuCsS+3uK5RSwgSDhsvG8L69SWjW1DJTP7Qa+9NwM2WTMZ?= =?Windows-1252?Q?eRGjZe90c8A74U3dkN6WQ0IXx4otx1DfIvNmXXUDxPR76g+SpVOW+EhV?= =?Windows-1252?Q?NkzkpyKpv/Qlz4SfDpKG31UaIhm0OEjFYLDMa1Y7ZGDXOo4IMuMYgJqU?= =?Windows-1252?Q?iymh87jUV79A89WrBSBStYEW6ikpRpOcdPWof52TnDUrIHg3l6dzzc73?= =?Windows-1252?Q?dmZ/H5n1m47gpGYrtBiYoKYeE0QpC4tExBiM4FlNChIwOaDZNyiqNvcz?= =?Windows-1252?Q?YVpBztQxVKeIjudsDzc0+hSY3GEn/qipgNmdqlreojmg5o+nLI5TiBP3?= =?Windows-1252?Q?I0WcVIqDP134RtTquuBK4Nr5NtSS4gvErYth/kbbMO+mAbw2ZLlnWzsI?= =?Windows-1252?Q?KkhnofiI7pPsA2ea7cD+Qlfm+LYR8BIhTpLjEBmJDlg5usmpeZnIhW19?= =?Windows-1252?Q?IEsOz95mfVg8Gh6IXc4kB+AgkENoQm7Efk0nuLYB7/KsX9XkzcBx9n0w?= =?Windows-1252?Q?W1EjCHrQFpej67LWcxv8pshGGFyT8dU7HCiD4O+NRYLCpxuWoQBVhnX/?= =?Windows-1252?Q?Af+T1+fIYrCslLLQ3q0ll/9A2oAyRlce0RVwIoroqCur23IBBW?= X-Forefront-PRVS: 03333C607F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(39840400002)(39850400002)(39410400002)(39400400002)(39450400003)(24454002)(377454003)(81166006)(42186005)(6666003)(4326008)(65826007)(2906002)(64126003)(8666007)(86362001)(2950100002)(229853002)(65956001)(65806001)(189998001)(47776003)(31696002)(76176999)(54356999)(53936002)(8676002)(6246003)(50986999)(6486002)(38730400002)(31686004)(230700001)(5660300001)(93886004)(23746002)(25786009)(53546009)(478600001)(7416002)(33646002)(36756003)(305945005)(7736002)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR15MB1656;H:[IPv6:2620:10d:c0a1:1110::1002];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY4PR15MB1656;23:ENZbKI+lI3z90SfyS1gX60lHsxG5PxB0lfABJ?= =?Windows-1252?Q?uZ4YNgHChL2jbX7/t7ZAYR5thQ0tmUYDEldlypXZ5ZCzgpzFi00DDo0p?= =?Windows-1252?Q?b7FiufgP+UmORyMsnK+b86QR6hoO+/dZH++mq76nBI4G3G4LJCMrousz?= =?Windows-1252?Q?z6tSrhufkJuN3BXPo8OUb6ACIJ8tkhm9sVmZduqAj4BfjwNr/3CrlOZN?= =?Windows-1252?Q?8hbk4SZTiQXh0usgDy0LA+RTYPVGRMwaHhmkMOm5rYJ1nh3MgND2PixQ?= =?Windows-1252?Q?s7JeH2Vkuf3fd5LRuSqWQhmnKrCEVQRpsLcfK6nje2QZ+bzSVTtp0Bh3?= =?Windows-1252?Q?AnmTbY00F5Nnkg57U23isUb7pBBQwLzHoq5hvUszGTccR2wWYnr7vb50?= =?Windows-1252?Q?y/cjdkblvpdxsWpqDHeUuxCNOkFngLXpwJcUkYMw+EnUuBVvMU4s9Ofh?= =?Windows-1252?Q?+7DOSH38vpL6B4nvL2ka/8h3Pz1GwITDd8syHyLi4AUMrUjk9PKvZ4z+?= =?Windows-1252?Q?b9EDh4r3fG/V1jaMcvYakj9fteI3pRxxVp4tZBusnv+GFgbVGa8mvWWq?= =?Windows-1252?Q?gD9wDHe4J3BVt34dkVXkrQ0rTAi+POVXPtSxl5Zuv97MKgk0+CMDhZA0?= =?Windows-1252?Q?16mnhOZrKchuruwhbPvxWz6CGfJYkR2QGdabnkFqqr0nIYf877L3ytmV?= =?Windows-1252?Q?u7Hz1bdlkeZXcyWuv9PhBQs3cFPUF/jyOXVjetLFJsKWNLQjFt9xlfgW?= =?Windows-1252?Q?AqCUNjQ+gYSkiJy4JLFUEgs5n0l4XRWfyOG08RuLOAcbsuWzBKa30oWe?= =?Windows-1252?Q?me9wsxCJgQH9sDjfOqCDvrL0qoKZOZWW+jtdc7jMbCzCVAVwXINx0YUx?= =?Windows-1252?Q?BEgxpzmS/ObrBtu5j3hYjJNEOu1fQgvgjIeT7a3UlM384lKYV9MAtrkO?= =?Windows-1252?Q?UIRzXnms0ZD6oTJ7bDynIwNQ8xWNjdHv0CTxoKe+6wF8+gDci555Ae9G?= =?Windows-1252?Q?TtbQk4Dg+enDCtsRiLQn7vfZd3qjKjxIebL0I81stMrQWV2/cPmQlRVX?= =?Windows-1252?Q?CvZxC/mAYdxy30qF/6o2QH1xrQHKgU9MYSd4uLvjCvBgcbfLbZWPLEn3?= =?Windows-1252?Q?miCAMJN09ZpSvQoq5TfQ7vhj/F+kyvTQ2MA8izm17Xd1Q3C6qtW59h+u?= =?Windows-1252?Q?Z8OsnC5ivqzwdxMB2889Ue88/vDp5xx6/eVB6rcdxYJzePHMN0vxE2Zu?= =?Windows-1252?Q?ueS64xbTwtnWYXZUDkDHU6Z6qXvNNpkSW5geCE=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1656;6:dRZezw+z8tFjUL5q0bJQvvwCUZNM6Fv7g4dZZ+oY/2mKfgOxOcY008zMoqatr7TazmuTh+7F0/YdsY4wpsWweuaGb6yNE1c43qHSNZLQJfGn1jqetnJwjeG7cqLZOEDYwK8MlbqmZb+y5/7FGPzjLVnYgRO4nm1I9lv34CR0zaA8T9/TAa/jkLAtAQewfwJDc5yNLf5D/FLElFs1PQesRzZN7VlKOkDCSmXop7icITuxDkb4jkpndMiNW1gV2r/mm5pM/XMzxucLGq727TRrXw/prqTOmlDzpmMVzTWjkW9JZOC8NjqbkceOENBTSI4O8Z+oJJRXOaZCnlBzz/rdBAjmgpCWtMSTNP1k2t5oex+1clJsUt5gQXnuuCa/Q1b0XOb/kS2e8uJYkQ4cYEeIR0Pk0rnRgd40GU/ls4jmPUopCZMSy0EfgPrikQDfj1qX3iesZy1b7asPt2j2Mp50k4FzKb4NwzbF8c6BtG6+VwjfP0zCA22OuN38S/3z6cddedE399aMewpi3qNV4OJjlQ== X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1656;5:dFEFtYEdPE1Hd1UahzQMPSMVuBDvGW8BVhPEuKG2fSGZHO3RKrfqwQFSIeC5elIU8vxIwhbytps/yNwo/XQ1aqVc/9bMPQsdNGfCU8TD61bUS2ZwGoc//dgV1D4SML5ZULq15jnwKWHPtciqWmgt+Thy3j3kaDZvsOiBsPu2ocBxKUqx+8TRWY/6lQyRvaMAwbaPn9/vAW4RubT61DQgK7hGA1kcXr2suLppev+tCVHQvLyQZ2HOWZILwi+lujvhB9BTu8nj5dUWYiSacfFf17HXDM7464BVlouDa5zwlZeY0AmQbb0EcSfEfS8GLCPauISGj4kofsIw9bmpbVsG/2WVFFRzYVKVKiOYiBfkRcZ8buJf+U0s2fRVTkwsenTk6QinZEwPW5r09LL2H2CShPoNmGDMWyym2mT2026Xbst5ic6YdQmjSDDOxY0RfNGIOBaFluya+T33HKHV8ynwv4a3Z6sPJW/NO2ffyKbPa23IFw+eKpVoZRitI501Avxa;24:vCW6p8Be+/qm6vRjlTvT6M8Gp8mTS0q27SilJPlfEnmx0nh/6p1CMRqn5zkW4l434yDHTmQVaISEkLgZYR0Bya95389keT37y7pqsPmSDDw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1656;7:XkYYh9aAW26EVfpy0fYfpID/IdkWg+uTynh+4KvrZSgLzxkGDcCWaoWbXCFSpjLk8lmJ9jf6eZwpVS0vi39US4/VQjI+DRsivZgbQcprdLMgtNHMZPJp1qc4VoiGokuee7rTcl2ki3A4NWevNHsPjKJes8zzCp4qlqWVCFd6lZuxlbcr+jRVWokBbDblIXVnFxTjrwTohAKVLGr+DjbaCIx0xZp218G62u/OoZeWBek71E5kkXIw2CZls4hchqqZYni+83psO6v4P5OPhzgQd1YdKLVOnEGRWMkyFSoOdX2bwWEB/RuRo6gW6iScYejM6E0a9OHHt0eQiq55e5FokA==;20:jmz9t+2ehTH5PTRZFGscBBSFYNOwJa/8FQ7GRHlJXikKPtvU4cwa/z+Iv9J2HyJrbLvi/spetXjya8cKn3wYAO7RDINLFnK40rJvF9TPIOEMbhvLzligxfUZxD3IuYhAK5Vg8o5Ab3I1ppFf9sKaXxMAw/5Wvye0U2lBggLBktg= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2017 17:52:09.5842 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1656 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-09_07:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/06/2017 05:21 AM, Peter Zijlstra wrote: > On Mon, Jun 05, 2017 at 02:00:21PM +0100, Matt Fleming wrote: >> On Fri, 19 May, at 04:00:35PM, Matt Fleming wrote: >>> On Wed, 17 May, at 12:53:50PM, Peter Zijlstra wrote: >>>> >>>> Please test.. >>> >>> Results are still coming in but things do look better with your patch >>> applied. >>> >>> It does look like there's a regression when running hackbench in >>> process mode and when the CPUs are not fully utilised, e.g. check this >>> out: >> >> This turned out to be a false positive; your patch improves things as >> far as I can see. > > Hooray, I'll move it to a part of the queue intended for merging. It's a little late, but Roman Gushchin helped get some runs of this with our production workload. The patch is every so slightly better. Thanks! -chris