All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Nilesh Javali <njavali@marvell.com>, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, GR-QLogic-Storage-Upstream@marvell.com
Subject: Re: [PATCH 0/3] qla2xxx SAN Congestion Management (SCM) support
Date: Thu, 14 May 2020 07:11:50 -0700	[thread overview]
Message-ID: <ad298d9c-92ad-0f7a-6873-6f346ce46c14@acm.org> (raw)
In-Reply-To: <20200514101026.10040-1-njavali@marvell.com>

On 2020-05-14 03:10, Nilesh Javali wrote:
> Please apply the qla2xxx patch series implementing SAN Congestion Management
> (SCM) support to the scsi tree at your earliest convenience.

Hi Nilesh,

This patch series introduces the following compiler warnings (W=1):

drivers/scsi/qla2xxx/qla_isr.c:27:1: warning: no previous prototype for
‘qla_link_integrity_tgt_stats_update’ [-Wmissing-prototypes]
   27 | qla_link_integrity_tgt_stats_update(struct fpin_descriptor
*fpin_desc,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/qla2xxx/qla_isr.c:83:1: warning: no previous prototype for
‘qla_scm_process_link_integrity_d’ [-Wmissing-prototypes]
   83 | qla_scm_process_link_integrity_d(struct scsi_qla_host *vha,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/qla2xxx/qla_isr.c:143:1: warning: no previous prototype for
‘qla_delivery_tgt_stats_update’ [-Wmissing-prototypes]
  143 | qla_delivery_tgt_stats_update(struct fpin_descriptor *fpin_desc,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/qla2xxx/qla_isr.c:173:1: warning: no previous prototype for
‘qla_scm_process_delivery_notification_d’ [-Wmissing-prototypes]
  173 | qla_scm_process_delivery_notification_d(struct scsi_qla_host *vha,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/qla2xxx/qla_isr.c:204:1: warning: no previous prototype for
‘qla_scm_set_target_device_state’ [-Wmissing-prototypes]
  204 | qla_scm_set_target_device_state(fc_port_t *fcport,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/qla2xxx/qla_isr.c:227:1: warning: no previous prototype for
‘qla_peer_congestion_tgt_stats_update’ [-Wmissing-prototypes]
  227 | qla_peer_congestion_tgt_stats_update(struct fpin_descriptor
*fpin_desc,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/qla2xxx/qla_isr.c:270:1: warning: no previous prototype for
‘qla_scm_process_peer_congestion_notification_d’ [-Wmissing-prototypes]
  270 | qla_scm_process_peer_congestion_notification_d(struct
scsi_qla_host *vha,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/qla2xxx/qla_isr.c:313:1: warning: no previous prototype for
‘qla_scm_process_congestion_notification_d’ [-Wmissing-prototypes]
  313 | qla_scm_process_congestion_notification_d(struct scsi_qla_host *vha,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/qla2xxx/qla_isr.c:343:1: warning: no previous prototype for
‘qla27xx_process_purex_fpin’ [-Wmissing-prototypes]
  343 | qla27xx_process_purex_fpin(struct scsi_qla_host *vha, struct
purex_item *item)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/qla2xxx/qla_isr.c:1136:1: warning: no previous prototype
for ‘qla24xx_alloc_purex_item’ [-Wmissing-prototypes]
 1136 | qla24xx_alloc_purex_item(scsi_qla_host_t *vha, uint16_t size)
      | ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/qla2xxx/qla_isr.c:1192:2: warning: no previous prototype
for ‘qla24xx_copy_std_pkt’ [-Wmissing-prototypes]
 1192 | *qla24xx_copy_std_pkt(struct scsi_qla_host *vha, void *pkt)
      |  ^~~~~~~~~~~~~~~~~~~~
drivers/scsi/qla2xxx/qla_isr.c:1213:1: warning: no previous prototype
for ‘qla27xx_copy_fpin_pkt’ [-Wmissing-prototypes]
 1213 | qla27xx_copy_fpin_pkt(struct scsi_qla_host *vha, void **pkt,
      | ^~~~~~~~~~~~~~~~~~~~~
  CC [M]  drivers/scsi/qla2xxx/qla_gs.o
  CC [M]  drivers/scsi/qla2xxx/qla_dbg.o
  CC [M]  drivers/scsi/qla2xxx/qla_sup.o
  CC [M]  drivers/scsi/qla2xxx/qla_attr.o
  CC [M]  drivers/scsi/qla2xxx/qla_mid.o
  CC [M]  drivers/scsi/qla2xxx/qla_dfs.o
drivers/scsi/qla2xxx/qla_dfs.c: In function
‘qla2x00_dfs_tgt_port_database_show’:
drivers/scsi/qla2xxx/qla_dfs.c:107:1: warning: the frame size of 1280
bytes is larger than 1024 bytes [-Wframe-larger-than=]
  107 | }
      | ^


and also the following sparse complaints:

$ make M=drivers/scsi/qla2xxx C=2
  CHECK   drivers/scsi/qla2xxx/qla_os.c
  CC [M]  drivers/scsi/qla2xxx/qla_os.o
  CHECK   drivers/scsi/qla2xxx/qla_init.c
drivers/scsi/qla2xxx/qla_init.c:8520:22: warning: cast to restricted __le16
  CC [M]  drivers/scsi/qla2xxx/qla_init.o
  CHECK   drivers/scsi/qla2xxx/qla_mbx.c
  CC [M]  drivers/scsi/qla2xxx/qla_mbx.o
  CHECK   drivers/scsi/qla2xxx/qla_iocb.c
  CC [M]  drivers/scsi/qla2xxx/qla_iocb.o
  CHECK   drivers/scsi/qla2xxx/qla_isr.c
drivers/scsi/qla2xxx/qla_isr.c:27:1: warning: symbol
'qla_link_integrity_tgt_stats_update' was not declared. Should it be static?
drivers/scsi/qla2xxx/qla_isr.c:106:38: warning: restricted __be32
degrades to integer
drivers/scsi/qla2xxx/qla_isr.c:83:1: warning: symbol
'qla_scm_process_link_integrity_d' was not declared. Should it be static?
drivers/scsi/qla2xxx/qla_isr.c:143:1: warning: symbol
'qla_delivery_tgt_stats_update' was not declared. Should it be static?
drivers/scsi/qla2xxx/qla_isr.c:173:1: warning: symbol
'qla_scm_process_delivery_notification_d' was not declared. Should it be
static?
drivers/scsi/qla2xxx/qla_isr.c:204:1: warning: symbol
'qla_scm_set_target_device_state' was not declared. Should it be static?
drivers/scsi/qla2xxx/qla_isr.c:240:56: warning: incorrect type in
assignment (different base types)
drivers/scsi/qla2xxx/qla_isr.c:240:56:    expected unsigned int
[usertype] event_period
drivers/scsi/qla2xxx/qla_isr.c:240:56:    got restricted __be32
[usertype] event_period
drivers/scsi/qla2xxx/qla_isr.c:227:1: warning: symbol
'qla_peer_congestion_tgt_stats_update' was not declared. Should it be
static?
drivers/scsi/qla2xxx/qla_isr.c:270:1: warning: symbol
'qla_scm_process_peer_congestion_notification_d' was not declared.
Should it be static?
drivers/scsi/qla2xxx/qla_isr.c:313:1: warning: symbol
'qla_scm_process_congestion_notification_d' was not declared. Should it
be static?
drivers/scsi/qla2xxx/qla_isr.c:343:1: warning: symbol
'qla27xx_process_purex_fpin' was not declared. Should it be static?
drivers/scsi/qla2xxx/qla_isr.c:1135:19: warning: symbol
'qla24xx_alloc_purex_item' was not declared. Should it be static?
drivers/scsi/qla2xxx/qla_isr.c:1192:1: warning: symbol
'qla24xx_copy_std_pkt' was not declared. Should it be static?
drivers/scsi/qla2xxx/qla_isr.c:1225:23: warning: restricted __le16
degrades to integer
drivers/scsi/qla2xxx/qla_isr.c:1225:23: warning: cast to restricted __le16
drivers/scsi/qla2xxx/qla_isr.c:1212:19: warning: symbol
'qla27xx_copy_fpin_pkt' was not declared. Should it be static?
  CC [M]  drivers/scsi/qla2xxx/qla_isr.o
  CHECK   drivers/scsi/qla2xxx/qla_gs.c
  CC [M]  drivers/scsi/qla2xxx/qla_gs.o
  CHECK   drivers/scsi/qla2xxx/qla_dbg.c
  CC [M]  drivers/scsi/qla2xxx/qla_dbg.o
  CHECK   drivers/scsi/qla2xxx/qla_sup.c
  CC [M]  drivers/scsi/qla2xxx/qla_sup.o
  CHECK   drivers/scsi/qla2xxx/qla_attr.c
  CC [M]  drivers/scsi/qla2xxx/qla_attr.o
  CHECK   drivers/scsi/qla2xxx/qla_mid.c
  CC [M]  drivers/scsi/qla2xxx/qla_mid.o
  CHECK   drivers/scsi/qla2xxx/qla_dfs.c
  CC [M]  drivers/scsi/qla2xxx/qla_dfs.o
drivers/scsi/qla2xxx/qla_dfs.c: In function
‘qla2x00_dfs_tgt_port_database_show’:
drivers/scsi/qla2xxx/qla_dfs.c:107:1: warning: the frame size of 1280
bytes is larger than 1024 bytes [-Wframe-larger-than=]
  107 | }
      | ^

Please fix these issues.

Thanks,

Bart.

      parent reply	other threads:[~2020-05-14 14:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-14 10:10 [PATCH 0/3] qla2xxx SAN Congestion Management (SCM) support Nilesh Javali
2020-05-14 10:10 ` [PATCH 1/3] qla2xxx: Change in PUREX to handle FPIN ELS requests Nilesh Javali
2020-05-14 17:03   ` himanshu.madhani
2020-05-15 18:52   ` James Smart
2020-05-14 10:10 ` [PATCH 2/3] qla2xxx: SAN congestion management(SCM) implementation Nilesh Javali
2020-05-14 18:52   ` himanshu.madhani
2020-05-15 22:48   ` James Smart
     [not found]     ` <CA+ihqdiA7AN05k5MjPG=o8_pf=L-La6UigY4t0emKgJMXm=hnQ@mail.gmail.com>
     [not found]       ` <BYAPR18MB2805AEA357302FCFA20D2B57B48F0@BYAPR18MB2805.namprd18.prod.outlook.com>
2020-06-11 17:42         ` Shyam Sundar
2020-06-25 23:25           ` James Smart
2020-06-26  0:14             ` Shyam Sundar
2020-07-30 16:10             ` Shyam Sundar
2020-09-21 17:48               ` James Smart
     [not found]     ` <CA+ihqdjtoA=1q7N0pg1TQDAMGo1XtNN8+XnO1qXORyqGYfpq=A@mail.gmail.com>
2020-06-11 18:10       ` Shyam S
2020-05-14 10:10 ` [PATCH 3/3] qla2xxx: Pass SCM counters to the application Nilesh Javali
2020-05-14 19:15   ` himanshu.madhani
2020-05-14 14:11 ` Bart Van Assche [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad298d9c-92ad-0f7a-6873-6f346ce46c14@acm.org \
    --to=bvanassche@acm.org \
    --cc=GR-QLogic-Storage-Upstream@marvell.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=njavali@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.