From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C8BAC433F5 for ; Tue, 21 Sep 2021 18:21:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 01FA161186 for ; Tue, 21 Sep 2021 18:21:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233363AbhIUSWl (ORCPT ); Tue, 21 Sep 2021 14:22:41 -0400 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]:34222 "EHLO smtp-relay-internal-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233373AbhIUSWU (ORCPT ); Tue, 21 Sep 2021 14:22:20 -0400 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 5D2FD4027C for ; Tue, 21 Sep 2021 18:20:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1632248450; bh=s1x0s0nZoSfkDljorxbVXRoxNOeXqYSIOV8lCyGgV/M=; h=To:Cc:References:From:Subject:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=OuMq8TuW98drYQVUd6qIyfwLIV+l0aD1dljAtR9Qgrut7WqnGE7qjLMfn9gS0Uz2q 7k8akZJm8/yItZ1RAYIpdAjDeGzxA3NUOv9XTMgGSOb+NmwR/AhRSRZIrGpdDFQD+H YkowoHGlYv7UHc0JcZHQHATJbnDj47YTSjydUa3HPxPwPvEYs+piTLxdwFtFEEXqWm gmPDfcr7rfrgfYBwwZS8WmIqY37yFNB201YUgMOnSVkwRZjzUmojCzGU+lJauHbb3I PlyVsoC5n5Ad7+6plKI5trJrzbgieb3p48CdU9GggF+iaiRkt0g8jme6xawxj4EIfr RkbeDiWD1LJLw== Received: by mail-wr1-f70.google.com with SMTP id f7-20020a5d50c7000000b0015e288741a4so9558639wrt.9 for ; Tue, 21 Sep 2021 11:20:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=s1x0s0nZoSfkDljorxbVXRoxNOeXqYSIOV8lCyGgV/M=; b=Feg+n/LN++B5RyH9YHtQfijdxvawAD4f6hf31AmiB5q6a9bDdiodj7A9vtEGznljwX HPcyJ3NReNzPx3odUeWRfW8DDIQ6cxtszAP4gAo3GNOcmzpPFpDFkLBzUwj4x6G5slpx ntrV8m2JPkUwxFPGQ+ZUlpNVlEQQ1YIZGloXQJlUMWjmgwA8ghzL6EGhCT63arTOSutD CwfIcR+sQpYuJLPemZQrWGSbZ2PGtopmuSYSAP4EMVnA9euQ1i1BLl53licU3v7nTsjV yE6TYXFJTRYgAcTUiYBIohGnhsMdomm5NAnUClLZTiyDoM5m+Q3nsQLDqq4Zu+/Mu+C+ G/yA== X-Gm-Message-State: AOAM532+4Je7gyCsrBCBN1yl9Ov+yvJ/W92OwbKinRIAUoo7LUiTKH/J Bfi8z7T3Y3qU8bvlelCoYkfSSQTrsvajXqd0dfSV0UUPF8lpArm8bUK+HdTYSDc4PRXSamqTuWf 7V7ER7ELGvVZUhPbHeNwV9vxNPG5qHJse/UEcMkCtcQ== X-Received: by 2002:a1c:7714:: with SMTP id t20mr6116127wmi.163.1632248450029; Tue, 21 Sep 2021 11:20:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwzFXWldxf5QmNutieh/xiyRvCC3i4k/pd4YG3SgGB01SyUaFQH3M57JkcGsRr4RuTJRGTbMw== X-Received: by 2002:a1c:7714:: with SMTP id t20mr6116109wmi.163.1632248449844; Tue, 21 Sep 2021 11:20:49 -0700 (PDT) Received: from [192.168.0.134] (lk.84.20.244.219.dc.cable.static.lj-kabel.net. [84.20.244.219]) by smtp.gmail.com with ESMTPSA id l124sm3715171wml.8.2021.09.21.11.20.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 11:20:49 -0700 (PDT) To: Will McVicker , Lee Jones Cc: Catalin Marinas , Will Deacon , "Cc: Android Kernel" , linux-arm-kernel@lists.infradead.org, Linux Kernel Mailing List , linux-samsung-soc@vger.kernel.org References: <20210920190350.3860821-1-willmcvicker@google.com> <20210920190350.3860821-3-willmcvicker@google.com> <2b48a41a-9130-b4cc-40d3-0bc7930ac76a@canonical.com> From: Krzysztof Kozlowski Subject: Re: [PATCH v1 2/4] soc: samsung: change SOC_SAMSUNG default config logic Message-ID: Date: Tue, 21 Sep 2021 20:20:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/09/2021 19:45, Will McVicker wrote: > On Tue, Sep 21, 2021 at 1:19 AM Lee Jones wrote: >> >> On Tue, 21 Sep 2021, Krzysztof Kozlowski wrote: >> >>> On 20/09/2021 21:03, Will McVicker wrote: >>>> Switch the default logic to enable SOC_SAMSUNG and it's sub-configs to >>>> be enabled by default via "default y if ARCH_EXYNOS" versus being >>>> selected by the ARCH_EXYNOS config directly. This allows vendors to >>>> disable these configs if they wish and provides additional flexibility >>>> to modularize them in the presence of a generic kernel. >>> >>> This is not true. Vendors cannot disable these options as they are not >>> visible. >> >> Good point, well made. >> >>> Although I understand that Arnd prefers this way and I do not >>> object it, but your explanation is incorrect. > > Thanks Krzysztof for the reviews! I'm sorry I missed the whole "hidden > configs" part. I'll upload the series to include the fix that refactos > the Samsung SoC drivers menuconfig which will address that and allow > one to enable/disable those configs. I'm going to hold off though > until we hash out the rest of the discussion in the cover letter > email. No, please first read our discussions, including Lee's and Geert's comments. The drivers should not be converted to modules or made visible if such configuration does not work. If it works, please describe your testing setup. All these drivers are *necessary* for a multiplatform kernel supporting Exynos platforms, therefore disabling them does not make any sense (if you support Exynos platform). If your kernel does not support Exynos platform, just do not select ARCH_EXYNOS and problem disappears because none of these drivers will be visible and selected. Unless you describe here some out-of-tree kernel which wants ARCH_EXYNOS, because vendor did not upstream it's code, but you do not want existing Exynos upstream drivers. We do not support such configuration. Please push your lovely vendor to work with upstream. That's the only solution. It's the third time this abuse re-usage of ARCH_EXYNOS appears and the same as before - the vendor does not like to upstream stuff. There are few guys trying to upstream recent Samsung SoC support by themself (ping me for contacts if you would like to participate) but the one party which should be doing it - the lovely vendor - does not actually participate and instead sends ridiculous patches like this one here... or like this [1] [2]. Nope, please work with upstreaming SoC support, instead of abusing ARCH_EXYNOS for out of tree code from the vendor. [1] https://lore.kernel.org/linux-samsung-soc/001001d5a03d$05de1f70$119a5e50$@samsung.com/ [2] https://lore.kernel.org/linux-usb/20210303022628.6540-1-taehyun.cho@samsung.com/ Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4FCFC433EF for ; Tue, 21 Sep 2021 18:23:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75F8A61186 for ; Tue, 21 Sep 2021 18:23:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 75F8A61186 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:Subject:From:References:Cc:To:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=JZrgP7vsyiiw3xrzDzEqwqAkfIkoWDUToktJzz532uo=; b=U2ERQ6lAp/NykMBzi++lkgzyCN EMTWa9BoJlA5lm9CmE5kHONx5NSNn/rBtSt+GY6CESWviM5aZrNAl03oFyjuMu6opLuftyRs5YCJC BSvCGq4bp9UHV4CaUsMLMpS93ik+yHf7zuh3ats+ERTcJNYPhmCGH7HAx8nVWfqmuTia1FkkBSESj d5f3pThgTgjQPqzTlQtt+kDq6RIctb+Aqdb/G3NYbiAadKh72L1vpRRzRn1aAFkC3jNWVZoJPIu/a GMeUY/SemNrACGhh6mG4/3iuD2/ObxdFYctvgP9acVWW0TNnD9Ug6nwuBFxiH/+oVVlFUD/3UfrPS ciB8Lzbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSkNz-005TF0-LZ; Tue, 21 Sep 2021 18:20:55 +0000 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSkNv-005TEZ-TI for linux-arm-kernel@lists.infradead.org; Tue, 21 Sep 2021 18:20:53 +0000 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 50AFA40261 for ; Tue, 21 Sep 2021 18:20:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1632248450; bh=s1x0s0nZoSfkDljorxbVXRoxNOeXqYSIOV8lCyGgV/M=; h=To:Cc:References:From:Subject:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=OuMq8TuW98drYQVUd6qIyfwLIV+l0aD1dljAtR9Qgrut7WqnGE7qjLMfn9gS0Uz2q 7k8akZJm8/yItZ1RAYIpdAjDeGzxA3NUOv9XTMgGSOb+NmwR/AhRSRZIrGpdDFQD+H YkowoHGlYv7UHc0JcZHQHATJbnDj47YTSjydUa3HPxPwPvEYs+piTLxdwFtFEEXqWm gmPDfcr7rfrgfYBwwZS8WmIqY37yFNB201YUgMOnSVkwRZjzUmojCzGU+lJauHbb3I PlyVsoC5n5Ad7+6plKI5trJrzbgieb3p48CdU9GggF+iaiRkt0g8jme6xawxj4EIfr RkbeDiWD1LJLw== Received: by mail-wr1-f70.google.com with SMTP id v15-20020adff68f000000b0015df51efa18so9539510wrp.16 for ; Tue, 21 Sep 2021 11:20:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=s1x0s0nZoSfkDljorxbVXRoxNOeXqYSIOV8lCyGgV/M=; b=p8UXu5S04t38u5MJ0zgXa8j8vse/9OSnw3cjvQxhCyrRchVnVxd5EmW2lDixHHzpmh ZFjyXLeSFffSpZmRHppcg4cxMjLCs0/addshU8GzHKTakF/5oP54yklVO1LviuYwl5N5 /OgpSMu5Dw7aThPbUtVGCQLMo4I6pEQdW0OGoX+kXlynRFKExlqjTJyZ1Ilu/QQx7h15 57u4o45xMu0IbTniR0rGeeWCpel81ZOCvlZTxT1qoQV8y+6n+3KAj1Ox9H/X4kRazl6D qd4uWdoUDA1J5x/6UKb2w0WXazsJgG7m2to31uhEUWehyjpyHOmFKlkgqQvTlVO29KEs 0PgA== X-Gm-Message-State: AOAM53360a3XfITjNQ15oK5rMmTCiNyS4CJV9WJ08n/uIhxdyyG8ePsy 6YCf8/ht2SvAfVnYhKNiPBUBVkGjOsaL2XRBCKM8Lpp4jooG0ZEBWjMVJ2GPfd4YwlUDvrpnIWc 3LI8obEnHjqLh4NSsJ/ctHaO0eW9St419/ceCDDp4LiH8kOJvbJWB X-Received: by 2002:a1c:7714:: with SMTP id t20mr6116128wmi.163.1632248450030; Tue, 21 Sep 2021 11:20:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwzFXWldxf5QmNutieh/xiyRvCC3i4k/pd4YG3SgGB01SyUaFQH3M57JkcGsRr4RuTJRGTbMw== X-Received: by 2002:a1c:7714:: with SMTP id t20mr6116109wmi.163.1632248449844; Tue, 21 Sep 2021 11:20:49 -0700 (PDT) Received: from [192.168.0.134] (lk.84.20.244.219.dc.cable.static.lj-kabel.net. [84.20.244.219]) by smtp.gmail.com with ESMTPSA id l124sm3715171wml.8.2021.09.21.11.20.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 11:20:49 -0700 (PDT) To: Will McVicker , Lee Jones Cc: Catalin Marinas , Will Deacon , "Cc: Android Kernel" , linux-arm-kernel@lists.infradead.org, Linux Kernel Mailing List , linux-samsung-soc@vger.kernel.org References: <20210920190350.3860821-1-willmcvicker@google.com> <20210920190350.3860821-3-willmcvicker@google.com> <2b48a41a-9130-b4cc-40d3-0bc7930ac76a@canonical.com> From: Krzysztof Kozlowski Subject: Re: [PATCH v1 2/4] soc: samsung: change SOC_SAMSUNG default config logic Message-ID: Date: Tue, 21 Sep 2021 20:20:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210921_112052_203402_9E835B62 X-CRM114-Status: GOOD ( 24.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/09/2021 19:45, Will McVicker wrote: > On Tue, Sep 21, 2021 at 1:19 AM Lee Jones wrote: >> >> On Tue, 21 Sep 2021, Krzysztof Kozlowski wrote: >> >>> On 20/09/2021 21:03, Will McVicker wrote: >>>> Switch the default logic to enable SOC_SAMSUNG and it's sub-configs to >>>> be enabled by default via "default y if ARCH_EXYNOS" versus being >>>> selected by the ARCH_EXYNOS config directly. This allows vendors to >>>> disable these configs if they wish and provides additional flexibility >>>> to modularize them in the presence of a generic kernel. >>> >>> This is not true. Vendors cannot disable these options as they are not >>> visible. >> >> Good point, well made. >> >>> Although I understand that Arnd prefers this way and I do not >>> object it, but your explanation is incorrect. > > Thanks Krzysztof for the reviews! I'm sorry I missed the whole "hidden > configs" part. I'll upload the series to include the fix that refactos > the Samsung SoC drivers menuconfig which will address that and allow > one to enable/disable those configs. I'm going to hold off though > until we hash out the rest of the discussion in the cover letter > email. No, please first read our discussions, including Lee's and Geert's comments. The drivers should not be converted to modules or made visible if such configuration does not work. If it works, please describe your testing setup. All these drivers are *necessary* for a multiplatform kernel supporting Exynos platforms, therefore disabling them does not make any sense (if you support Exynos platform). If your kernel does not support Exynos platform, just do not select ARCH_EXYNOS and problem disappears because none of these drivers will be visible and selected. Unless you describe here some out-of-tree kernel which wants ARCH_EXYNOS, because vendor did not upstream it's code, but you do not want existing Exynos upstream drivers. We do not support such configuration. Please push your lovely vendor to work with upstream. That's the only solution. It's the third time this abuse re-usage of ARCH_EXYNOS appears and the same as before - the vendor does not like to upstream stuff. There are few guys trying to upstream recent Samsung SoC support by themself (ping me for contacts if you would like to participate) but the one party which should be doing it - the lovely vendor - does not actually participate and instead sends ridiculous patches like this one here... or like this [1] [2]. Nope, please work with upstreaming SoC support, instead of abusing ARCH_EXYNOS for out of tree code from the vendor. [1] https://lore.kernel.org/linux-samsung-soc/001001d5a03d$05de1f70$119a5e50$@samsung.com/ [2] https://lore.kernel.org/linux-usb/20210303022628.6540-1-taehyun.cho@samsung.com/ Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel