From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48F26C433E0 for ; Mon, 8 Feb 2021 07:52:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DAAD064E78 for ; Mon, 8 Feb 2021 07:52:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229707AbhBHHvo convert rfc822-to-8bit (ORCPT ); Mon, 8 Feb 2021 02:51:44 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]:2513 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229608AbhBHHvo (ORCPT ); Mon, 8 Feb 2021 02:51:44 -0500 Received: from fraeml736-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4DYymD3b6dz67m3R; Mon, 8 Feb 2021 15:47:24 +0800 (CST) Received: from lhreml718-chm.china.huawei.com (10.201.108.69) by fraeml736-chm.china.huawei.com (10.206.15.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 8 Feb 2021 08:50:59 +0100 Received: from dggemi761-chm.china.huawei.com (10.1.198.147) by lhreml718-chm.china.huawei.com (10.201.108.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2106.2; Mon, 8 Feb 2021 07:50:57 +0000 Received: from dggemi761-chm.china.huawei.com ([10.9.49.202]) by dggemi761-chm.china.huawei.com ([10.9.49.202]) with mapi id 15.01.2106.006; Mon, 8 Feb 2021 15:50:56 +0800 From: "Song Bao Hua (Barry Song)" To: Jonathan Cameron , "linux-iio@vger.kernel.org" CC: Lars-Peter Clausen , Michael Hennerich , "robh+dt@kernel.org" , Jonathan Cameron Subject: RE: [PATCH 20/24] staging:iio:cdc:ad7150: Add of_match_table Thread-Topic: [PATCH 20/24] staging:iio:cdc:ad7150: Add of_match_table Thread-Index: AQHW/WjOz1HcIZ4+F0WGI66byv11FKpN4Rlg Date: Mon, 8 Feb 2021 07:50:56 +0000 Message-ID: References: <20210207154623.433442-1-jic23@kernel.org> <20210207154623.433442-21-jic23@kernel.org> In-Reply-To: <20210207154623.433442-21-jic23@kernel.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.126.200.200] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org > -----Original Message----- > From: Jonathan Cameron [mailto:jic23@kernel.org] > Sent: Monday, February 8, 2021 4:46 AM > To: linux-iio@vger.kernel.org > Cc: Lars-Peter Clausen ; Michael Hennerich > ; Song Bao Hua (Barry Song) > ; robh+dt@kernel.org; Jonathan Cameron > > Subject: [PATCH 20/24] staging:iio:cdc:ad7150: Add of_match_table > > From: Jonathan Cameron > > Rather than using the fallback path in the i2c subsystem and hoping > for no clashes across vendors, lets put in an explicit table for > matching. > > Signed-off-by: Jonathan Cameron > --- > drivers/staging/iio/cdc/ad7150.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/staging/iio/cdc/ad7150.c > b/drivers/staging/iio/cdc/ad7150.c > index 0bc8c7a99883..33c8a78c076f 100644 > --- a/drivers/staging/iio/cdc/ad7150.c > +++ b/drivers/staging/iio/cdc/ad7150.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -655,9 +656,16 @@ static const struct i2c_device_id ad7150_id[] = { > > MODULE_DEVICE_TABLE(i2c, ad7150_id); > > +static const struct of_device_id ad7150_of_match[] = { > + { "adi,ad7150" }, > + { "adi,ad7151" }, > + { "adi,ad7156" }, > + {} > +}; Does it compile if CONFIG_OF is not enabled? > static struct i2c_driver ad7150_driver = { > .driver = { > .name = "ad7150", > + .of_match_table = ad7150_of_match, of_match_ptr(ad7150_of_match)? Do we need dt-binding doc? > }, > .probe = ad7150_probe, > .id_table = ad7150_id, > -- > 2.30.0 Thanks Barry