All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] x86: baytrail: Add 2nd eMMC controller to the PCI probe list
Date: Mon, 26 Sep 2016 08:39:53 +0200	[thread overview]
Message-ID: <ad438384-8dd9-d2a5-f4ec-980eb7c4796f@denx.de> (raw)
In-Reply-To: <CAEUhbmW9J8w0Z8MG=EpTSr4ZTNpP6dSgXx2dAp4o5fS2+xBhTg@mail.gmail.com>

Hi Bin,

On 26.09.2016 08:33, Bin Meng wrote:
> On Fri, Sep 16, 2016 at 8:37 PM, Stefan Roese <sr@denx.de> wrote:
>> With this addition, the eMMC device available on the congatec and DFI
>> BayTrail SoM is detected correctly.
>>
>> Signed-off-by: Stefan Roese <sr@denx.de>
>> Cc: Simon Glass <sjg@chromium.org>
>> Cc: Bin Meng <bmeng.cn@gmail.com>
>> ---
>>  arch/x86/cpu/baytrail/valleyview.c | 1 +
>>  include/pci_ids.h                  | 1 +
>>  2 files changed, 2 insertions(+)
>>
>> diff --git a/arch/x86/cpu/baytrail/valleyview.c b/arch/x86/cpu/baytrail/valleyview.c
>> index b31f24e..9868de0 100644
>> --- a/arch/x86/cpu/baytrail/valleyview.c
>> +++ b/arch/x86/cpu/baytrail/valleyview.c
>> @@ -14,6 +14,7 @@
>>  static struct pci_device_id mmc_supported[] = {
>>         { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VALLEYVIEW_SDIO },
>>         { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VALLEYVIEW_SDCARD },
>> +       { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BYT_EMMC2 },
>
> pure nits, should we use VALLEYVIEW_EMMC2? or should we change
> previous VALLEYVIEW_SDIO/SDCARD to BYT_SDIO/SDCARD, for consistency?

I've taken the new name from the Linux driver as you might have
already suspected. I would prefer to change the other (old) names
to the Linux ones. I can prepare a v2 of this patch or a follow-up
patch for this. What would you prefer?

Thanks,
Stefan

  reply	other threads:[~2016-09-26  6:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-16 12:37 [U-Boot] [PATCH] x86: baytrail: Add 2nd eMMC controller to the PCI probe list Stefan Roese
2016-09-26  6:33 ` Bin Meng
2016-09-26  6:39   ` Stefan Roese [this message]
2016-09-26  6:42     ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad438384-8dd9-d2a5-f4ec-980eb7c4796f@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.