From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C96E8C54EBC for ; Tue, 10 Jan 2023 22:08:39 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EBE40854B9; Tue, 10 Jan 2023 23:08:37 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; secure) header.d=gmx.de header.i=@gmx.de header.b="ZdFXFE+O"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A743E854B9; Tue, 10 Jan 2023 23:08:36 +0100 (CET) Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3E204854B9 for ; Tue, 10 Jan 2023 23:08:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1673388510; bh=IvpVwePzqzOtmHao1JwqJxuRI1Iw/9KWD3RNnNEmekY=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=ZdFXFE+OMbIvPgKaXE6hJRewwZ/pYIy7DuVmHKIE54Oc+J5C/9hzXGy38It+X6iIV 6BeqKTEDETrcKdMxTN1hZn36W82NPgfXOrpYL9YExWRwPcdUIiGczDtqZ6Y23s9Zvs aHCD0L4H8i/5w79zXH8OSq16h0cyj31WdOtsAL3U/Qm7cAZV7sJWiPzQDL87lifiLi /C5PG0S7w60JvlETvqXMl28dCOH/Fz0p6ETY4vNNcoZ79+oHwUqGVf3mhW6rynXMbQ CeY3ymdNFsrZwc+OIKqdLGjLkMBe10rKeOZn3jofYz9D4bmpGcIFO0/Hu+ujTFi6L5 C9HS89CNPrtGg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.123.94] ([88.152.145.137]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mlw3N-1oXTP30Swd-00j4Am; Tue, 10 Jan 2023 23:08:30 +0100 Message-ID: Date: Tue, 10 Jan 2023 23:08:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 0/5] tpm: Support boot measurements Content-Language: en-US To: Eddie James Cc: ilias.apalodimas@linaro.org, sjg@chromium.org, u-boot@lists.denx.de References: <20230109215525.79046-1-eajames@linux.ibm.com> <0279d066-b0ff-64f9-a4d2-7d908af5b747@linux.ibm.com> From: Heinrich Schuchardt In-Reply-To: <0279d066-b0ff-64f9-a4d2-7d908af5b747@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:H4dyD0IAF1iL/62isRaO2QRvXzuM9LLtRBgvQtNGRvgIRZmv/cc Z2oVj6IJG207Y6Io1K2IAftfsrW1qHFKRME4N0DzKYNykrjmuUUWyJcGbg4LkWUtRemNORx l9gbkh2//ym9hEgZrzu4qQ3MvkZJfBa8/HCsVvR5qamMZ8p4v6CfklKyTBG0dOJe4rTUghz nwXUkojsBiBGCStq/imgg== UI-OutboundReport: notjunk:1;M01:P0:ccXUxaeu1T0=;ZtH6qqLJq4+AzJUqHCSaG8Kr99t Wow0JdJvTeo1y+50bLhAEZkl/rTkd/Lc1BynJiPSyjkqH+zVBZHZoQiA1NThBpJ/wB+5Va5TL V5YTlWflczVGi/XYiPQ68681rblaoNLluvfiG6RM99jsTed/xjBpcBtaCPmTTswPPkdE6LfBW hU0zwUxzmcPoLpyREfSLa5V9CebN7Fl8SYG+43aXut7mWqKxc5fvfjm66vciSgNLOB0OkdPXv SGwD5Y3xMDZtSVeAB7ipZDRKcIFgzxSBX+tZ++nKlzQGj6v2lN9pmKgtwQz9LdbRseHjl8u5R NWFsEUgcUUA/lh3pvfGVxiKqYt/Vmzy877F8C+iUoCsxOEIn6mYobAATLNXKw8R8XdMdTEHAS PvXgVbAi4Ymoqd1oPjIxK66wsVMcu0fBD58Z+gdNrUVB7mQOlmYZYEtMXssT0DAy1SeFKZAK2 XlrbDDGgM97GmDvJlb5HINlPTtsURWqrvQIWUBhfEJL9OPxmZsWSIsz+gwZA8XPkr02tE6EsP 93orhUP5klqy41Jt5i1ne6Lgg8lbBJgHuSuoXpIQW3K9Mq/YGKo1t1tFMFmmwu+CD+thHPw3x s+XVtZZ7Ar2HtaDhUrh7OFlOQ5a8icyPUomjcVr3WwIBb/OuRHcS9koSq9ukfN6O1golqqzaA mz3809qwtSRwab+mBzVFFXQg8Zychvj20tYxkFvnoSxkUM5X0Sit3jx4i4H9pZhtRV9fwLt53 BpLytCbD0kYWfwbFr6QTy6MJLlPJLwtoEMz4HVzM5YfPiT0QIZuS7zp1MFq/2BXj7+0nXpB8W s02Y20Dej/yJQElMpYGqc5nYLXRZnL62MA4zzXGm20vWEBg7gXw/UO/QB6k1yLOgTeNVg6lwa /X3rT53TFqF5ODhTH6FIyUmRgIhbcMU9mgP2k5/bGNlGGiHKf8YljdemeyxPIAjLTZwmJJAXB 0roN11I6gzBXZ+eLIa2+XjN26/I= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 1/10/23 22:42, Eddie James wrote: > > On 1/9/23 17:35, Heinrich Schuchardt wrote: >> On 1/9/23 22:55, Eddie James wrote: >>> This series adds support for measuring the boot images more genericall= y >>> than the existing EFI support. Several EFI functions have been moved t= o >>> the TPM layer. The series includes optional measurement from the bootm >>> command. >>> A new test case has been added for the bootm measurement to test the n= ew >>> path, and the sandbox TPM2 driver has been updated to support this use >>> case. >>> >>> Changes since v1: >>> =C2=A0 - Refactor TPM layer functions to allow EFI system to use them,= and >>> =C2=A0=C2=A0=C2=A0 remove duplicate EFI functions. >>> =C2=A0 - Add test case >>> =C2=A0 - Drop #ifdefs for bootm >>> =C2=A0 - Add devicetree measurement config option >>> =C2=A0 - Update sandbox TPM driver >> >> This looks like a useful feature to me. Some questions remain: >> >> How about the booti and bootz commands. Are they covered by the change? > > > No, not yet. Please, add the measurements in common code for all boot commands (except bootefi). > > >> >> What are the consequences of your changes for UEFI FIT images (cf. >> CONFIG_BOOTM_EFI)? > > > I suppose the image would be measured twice, but only if the user > selected both of the relevant config options. We should have a test case for this. Best regards Heinrich