All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felix Kuehling <felix.kuehling-5C7GfCeVMHo@public.gmane.org>
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	"Christian König" <christian.koenig-5C7GfCeVMHo@public.gmane.org>
Subject: Re: VRAM manager
Date: Fri, 7 Oct 2016 18:11:16 -0400	[thread overview]
Message-ID: <ad665321-d00c-1ded-051f-2ca8eae014b4@amd.com> (raw)
In-Reply-To: <1474969797-1882-1-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>

Hi Christian,

I'm back from vacation and finally caught up with my email and
code-review backlog.

I added a comment on patch 1.

I don't understand patch 2. I couldn't find where a non-0 lpfn would
trigger any reallocation. I think this would have to be somewhere in
ttm_bo_validate or ttm_bo_mem_compat. I also grepped for all uses of
lpfn in TTM and AMDGPU. Maybe I'm looking for the wrong thing in the
wrong place.

Patches 3-6 look good to me (other than the copyright date pointed out
by David). Please add my Reviewed-by.

Regards,
  Felix


On 16-09-27 05:49 AM, Christian König wrote:
> Hi guys,
>
> after fixing all those nasty little bugs this seems to be stable now.
>
> Anybody brave enough to give it an review?
>
> Cheers,
> Christian.
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2016-10-07 22:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-27  9:49 VRAM manager Christian König
     [not found] ` <1474969797-1882-1-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2016-09-27  9:49   ` [PATCH 1/6] drm/amdgpu: add AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS flag v3 Christian König
     [not found]     ` <1474969797-1882-2-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2016-10-07 21:19       ` Felix Kuehling
     [not found]         ` <627af621-8fb2-ba41-c87e-96bb12e594d8-5C7GfCeVMHo@public.gmane.org>
2016-10-11  9:35           ` Christian König
2016-09-27  9:49   ` [PATCH 2/6] drm/amdgpu: use explicit limit for VRAM_CONTIGUOUS Christian König
2016-09-27  9:49   ` [PATCH 3/6] drm/amdgpu: set at least the node size in the gtt manager Christian König
2016-09-27  9:49   ` [PATCH 4/6] drm/amdgpu: handle multiple MM nodes in the VMs v2 Christian König
2016-09-27  9:49   ` [PATCH 5/6] drm/amdgpu: enable amdgpu_move_blit to handle multiple MM nodes v2 Christian König
2016-09-27  9:49   ` [PATCH 6/6] drm/amdgpu: add VRAM manager v2 Christian König
     [not found]     ` <1474969797-1882-7-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2016-09-27  9:57       ` zhoucm1
2016-09-27 10:50   ` VRAM manager Mike Lothian
2016-09-27 11:17   ` Edward O'Callaghan
2016-10-07 22:11   ` Felix Kuehling [this message]
     [not found]     ` <ad665321-d00c-1ded-051f-2ca8eae014b4-5C7GfCeVMHo@public.gmane.org>
2016-10-11  9:34       ` Christian König
     [not found]         ` <6235e143-b44a-0039-b84c-c1be81de4a4c-5C7GfCeVMHo@public.gmane.org>
2016-10-11 18:59           ` Felix Kuehling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad665321-d00c-1ded-051f-2ca8eae014b4@amd.com \
    --to=felix.kuehling-5c7gfcevmho@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.