From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergio Gonzalez Monroy Subject: Re: [PATCH] cryptodev: fix NULL pointer dereference Date: Mon, 31 Jul 2017 13:32:58 +0100 Message-ID: References: <20170731023050.28956-1-pablo.de.lara.guarch@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Pablo de Lara , declan.doherty@intel.com Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id CF5347CAB for ; Mon, 31 Jul 2017 14:33:02 +0200 (CEST) In-Reply-To: <20170731023050.28956-1-pablo.de.lara.guarch@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 31/07/2017 03:30, Pablo de Lara wrote: > When registering a crypto driver, if memory allocation > fails, application should exit and do not allow > a NULL pointer dereference. > > Coverity issue: 158645 > > Fixes: 7a364faef185 ("cryptodev: remove crypto device type enumeration") > > Signed-off-by: Pablo de Lara > --- > lib/librte_cryptodev/rte_cryptodev.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c > index 327d7e8..4492b0d 100644 > --- a/lib/librte_cryptodev/rte_cryptodev.c > +++ b/lib/librte_cryptodev/rte_cryptodev.c > @@ -1404,6 +1404,12 @@ rte_cryptodev_allocate_driver(const struct rte_driver *drv) > struct cryptodev_driver *driver; > > driver = malloc(sizeof(*driver)); > + > + if (driver == NULL) > + rte_exit(EXIT_FAILURE, > + "Could not allocate memory for crypto driver %u\n", > + nb_drivers); > + > driver->driver = drv; > driver->id = nb_drivers; > Acked-by: Sergio Gonzalez Monroy