From: Tao Xu <tao3.xu@intel.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: pbonzini@redhat.com, rth@twiddle.net, qemu-devel@nongnu.org,
robert.hu@linux.intel.com, thomas.lendacky@amd.com
Subject: Re: [Qemu-devel] [PATCH 2/2] i386: Add some MSR based features on Cascadelake-Server CPU model
Date: Mon, 21 Jan 2019 17:29:32 +0800 [thread overview]
Message-ID: <ad912a4e-986b-61d3-0fd8-1047ecabd651@intel.com> (raw)
In-Reply-To: <20190114183545.GB28115@habkost.net>
On 1/15/2019 2:35 AM, Eduardo Habkost wrote:
> Sorry, we do have a problem here:
>
> On Thu, Dec 27, 2018 at 10:43:04AM +0800, Tao Xu wrote:
> [...]
>> #define PC_COMPAT_3_0 \
>> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
>> index 09706ad51a..5296c73cd5 100644
>> --- a/target/i386/cpu.c
>> +++ b/target/i386/cpu.c
>> @@ -2499,7 +2499,8 @@ static X86CPUDefinition builtin_x86_defs[] = {
>> CPUID_7_0_ECX_PKU | CPUID_7_0_ECX_OSPKE |
>> CPUID_7_0_ECX_AVX512VNNI,
>> .features[FEAT_7_0_EDX] =
>> - CPUID_7_0_EDX_SPEC_CTRL | CPUID_7_0_EDX_SPEC_CTRL_SSBD,
>> + CPUID_7_0_EDX_SPEC_CTRL | CPUID_7_0_EDX_SPEC_CTRL_SSBD |
>> + CPUID_7_0_EDX_ARCH_CAPABILITIES,
>
> CPUID_7_0_EDX_ARCH_CAPABILITIES is still set on
> unmigratable_flags. We need to make it migratable before adding
> it by default to a named CPU model.
>
Hi Eduardo,
Do you mean I need to remove CPUID_7_0_EDX_ARCH_CAPABILITIES
from .migratable_flags? Or CPUID_7_0_EDX_ARCH_CAPABILITIES can not
support migration now?
> Also, why are you setting this only on Cascadelake-Server and not
> on all the other Intel CPUs?
>
Thank you for your notice. I reviewed the git log of KVM.
"MSR_IA32_ARCH_CAPABILITIES is emulated in kvm, there is no dependency
on hardware support for this feature". So do you mean we should also add
features based on ARCH_CAPABILITIES in former CPU(such as skylake)?
> I'm queueing only patch 1/2 until we sort this out.
>
next prev parent reply other threads:[~2019-01-21 9:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-27 2:43 [Qemu-devel] [PATCH 0/2] Add MSR based features on Cascadelake CPU model Tao Xu
2018-12-27 2:43 ` [Qemu-devel] [PATCH 1/2] i386: Update stepping of Cascadelake-Server Tao Xu
2018-12-27 2:43 ` [Qemu-devel] [PATCH 2/2] i386: Add some MSR based features on Cascadelake-Server CPU model Tao Xu
2019-01-14 18:35 ` Eduardo Habkost
2019-01-21 9:29 ` Tao Xu [this message]
2019-01-23 19:15 ` Eduardo Habkost
2019-01-28 8:33 ` Tao Xu
2019-01-28 14:48 ` Eduardo Habkost
2019-01-29 8:55 ` Tao Xu
2019-03-08 18:56 ` Eduardo Habkost
2019-01-02 1:16 ` [Qemu-devel] [PATCH 0/2] Add MSR based features on Cascadelake " Tao Xu
2019-01-02 1:20 ` Tao Xu
2019-01-14 18:16 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad912a4e-986b-61d3-0fd8-1047ecabd651@intel.com \
--to=tao3.xu@intel.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=robert.hu@linux.intel.com \
--cc=rth@twiddle.net \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.