From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [RESEND 5/6] drm/i915: Remove pci private pointer after destroying the device private Date: Mon, 16 Jul 2018 11:04:20 +0100 Message-ID: References: <20180716080332.32283-1-chris@chris-wilson.co.uk> <20180716080332.32283-5-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id F12096E0BE for ; Mon, 16 Jul 2018 10:04:22 +0000 (UTC) In-Reply-To: <20180716080332.32283-5-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE2LzA3LzIwMTggMDk6MDMsIENocmlzIFdpbHNvbiB3cm90ZToKPiBPbiBhbiBhYm9ydGVk IG1vZHVsZSBsb2FkLCB3ZSB1bndpbmQgYW5kIGZyZWUgb3VyIGRldmljZSBwcml2YXRlIC0gYnV0 Cj4gd2UgbGVmdCBhIGRhbmdsaW5nIHBvaW50ZXIgdG8gb3VyIHByaXZhdGVzIGluc2lkZSB0aGUg cGNpX2RldmljZS4gQWZ0ZXIKPiB0aGUgYXR0ZW1wdGVkIGFib3J0ZWQgdW5sb2FkLCB3ZSBtYXkg c3RpbGwgZ2V0IGEgY2FsbCB0byBpOTE1X3BjaV9yZW1vdmUoKQo+IHdoZW4gdGhlIG1vZHVsZSBp cyByZW1vdmVkLCBwb3RlbnRpYWxseSBjaGFzaW5nIHN0YWxlIGRhdGEuCj4gCj4gU2lnbmVkLW9m Zi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gLS0tCj4gICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jIHwgIDEgKwo+ICAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9wY2kuYyB8IDEzICsrKysrKysrKysrKy0KPiAgIDIgZmlsZXMgY2hhbmdlZCwg MTMgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYu Ywo+IGluZGV4IDcwMGZmYjYxMTE4Ny4uMzgzNGJkNzU4YTJlIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2Rydi5jCj4gQEAgLTE0MjQsNiArMTQyNCw3IEBAIGludCBpOTE1X2RyaXZlcl9sb2FkKHN0 cnVjdCBwY2lfZGV2ICpwZGV2LCBjb25zdCBzdHJ1Y3QgcGNpX2RldmljZV9pZCAqZW50KQo+ICAg CWRybV9kZXZfZmluaSgmZGV2X3ByaXYtPmRybSk7Cj4gICBvdXRfZnJlZToKPiAgIAlrZnJlZShk ZXZfcHJpdik7Cj4gKwlwY2lfc2V0X2RydmRhdGEocGRldiwgTlVMTCk7Cj4gICAJcmV0dXJuIHJl dDsKPiAgIH0KPiAgIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Bj aS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wY2kuYwo+IGluZGV4IDU1NTQzZjFiMDIz Ni4uNmE0ZDEzODhhZDJkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf cGNpLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BjaS5jCj4gQEAgLTY3NCwx MCArNjc0LDE2IEBAIE1PRFVMRV9ERVZJQ0VfVEFCTEUocGNpLCBwY2lpZGxpc3QpOwo+ICAgCj4g ICBzdGF0aWMgdm9pZCBpOTE1X3BjaV9yZW1vdmUoc3RydWN0IHBjaV9kZXYgKnBkZXYpCj4gICB7 Cj4gLQlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gcGNpX2dldF9kcnZkYXRhKHBkZXYpOwo+ICsJ c3RydWN0IGRybV9kZXZpY2UgKmRldjsKPiArCj4gKwlkZXYgPSBwY2lfZ2V0X2RydmRhdGEocGRl dik7Cj4gKwlpZiAoIWRldikgLyogZHJpdmVyIGxvYWQgYWJvcnRlZCwgbm90aGluZyB0byBjbGVh bnVwICovCj4gKwkJcmV0dXJuOwo+ICAgCj4gICAJaTkxNV9kcml2ZXJfdW5sb2FkKGRldik7Cj4g ICAJZHJtX2Rldl9wdXQoZGV2KTsKPiArCj4gKwlwY2lfc2V0X2RydmRhdGEocGRldiwgTlVMTCk7 Cj4gICB9Cj4gICAKPiAgIHN0YXRpYyBpbnQgaTkxNV9wY2lfcHJvYmUoc3RydWN0IHBjaV9kZXYg KnBkZXYsIGNvbnN0IHN0cnVjdCBwY2lfZGV2aWNlX2lkICplbnQpCj4gQEAgLTcxMiw2ICs3MTgs MTEgQEAgc3RhdGljIGludCBpOTE1X3BjaV9wcm9iZShzdHJ1Y3QgcGNpX2RldiAqcGRldiwgY29u c3Qgc3RydWN0IHBjaV9kZXZpY2VfaWQgKmVudCkKPiAgIAlpZiAoZXJyKQo+ICAgCQlyZXR1cm4g ZXJyOwo+ICAgCj4gKwlpZiAoaTkxNV9pbmplY3RfbG9hZF9mYWlsdXJlKCkpIHsKPiArCQlpOTE1 X3BjaV9yZW1vdmUocGRldik7Cj4gKwkJcmV0dXJuIC1FTk9ERVY7Cj4gKwl9Cj4gKwo+ICAgCWVy ciA9IGk5MTVfbGl2ZV9zZWxmdGVzdHMocGRldik7Cj4gICAJaWYgKGVycikgewo+ICAgCQlpOTE1 X3BjaV9yZW1vdmUocGRldik7Cj4gCgpSZXZpZXdlZC1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRr by51cnN1bGluQGludGVsLmNvbT4KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==