All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Svensson <johan.svensson692@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: wsa@the-dreams.de, driverdev-devel@linuxdriverproject.org
Subject: Re: [PATCH] staging: ks7010: Change capability field to __le16
Date: Thu, 20 Apr 2017 21:02:26 +0200	[thread overview]
Message-ID: <ada817c4-a34a-6f5c-0e7d-44f87d27faae@gmail.com> (raw)
In-Reply-To: <20170418183826.GA1259@kroah.com>


On 2017-04-18 20:38, Greg KH wrote:
> On Tue, Apr 18, 2017 at 08:24:01PM +0200, Johan Svensson wrote:
>> Change capability field to __le16 in struct ap_info_t,
>> struct link_ap_info_t, and struct local_ap_t.
>> This fixes a sparse warning.
> What warning is it fixing?  And are you sure this is the correct fix?
> How did you test it?
>
> thanks,
>
> greg k-h
Without the patch, sparse reports:
drivers/staging/ks7010/ks_wlan_net.c:1459:24: warning: cast to restricted __le16

The capability field in the structs that are changed are already being treated as little endian i.e. the patch is correct if the le16_to_cpu conversion in ks_wlan_net.c:1459 is correct.

regards,
Johan Svensson

  reply	other threads:[~2017-04-20 19:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-18 18:24 [PATCH] staging: ks7010: Change capability field to __le16 Johan Svensson
2017-04-18 18:38 ` Greg KH
2017-04-20 19:02   ` Johan Svensson [this message]
2017-04-24 10:44     ` Tobin C. Harding
2017-04-25 21:11       ` Tobin C. Harding
2017-04-28  9:43 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ada817c4-a34a-6f5c-0e7d-44f87d27faae@gmail.com \
    --to=johan.svensson692@gmail.com \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.