From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roland Dreier Subject: Re: [PATCH v2 13/51] IB/qib: Add qib_driver.c Date: Wed, 31 Mar 2010 16:20:22 -0700 Message-ID: References: <20091203190305.29507.58158.stgit@chromite.mv.qlogic.com> <20091203190413.29507.17962.stgit@chromite.mv.qlogic.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ralph Campbell Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org > +unsigned qib_debug; > +module_param_named(debug, qib_debug, uint, S_IWUSR | S_IRUGO); > +MODULE_PARM_DESC(debug, "mask for debug prints"); Did you look at using trace events for this stuff? That gives you extremely low overhead when tracing is turned off (dynamic patching to NOP out the tracing when it's disabled) and also very fine-grained (per trace site) control over what gets printed; plus you get dumping of the trace buffer on crash, etc. - R. -- Roland Dreier || For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/index.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html