Re: [PATCHv10 02/12] ib_core: IBoE CMA device binding

[Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>]

 > In cma_acquire_dev, we try to match up a portion of the dev_addr with
 > a GID.  The current code does this by checking the dev_type to
 > determine if the GID would start at offset 0 or 4 in the dev_addr.
 > With IBoE, this check is no longer possible, so we select the offset
 > based on the rdma device that we're trying to compare against, rather
 > than using data stored with the net_device.
 > 
 > Maybe it's just so unlikely that we don't care, but can this lead to
 > a false match?  (and maybe the current code can have a false match..)

I don't think there's any chance of a false positive.  We can tell if
the GID offset is 0 or 4 based on the ARPHRD type of the address we're
comparing, so that should always be correct.  The only difference with
between IBoE and iWARP GIDs is that the IBoE GIDs are actually IPv6
link-local addresses, so they need some munging to convert back to
ethernet hardware addresses.  But in any case there shouldn't be a
collision unless there are duplicate ethernet addresses.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html