From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v8 6/9] ethdev: add common devargs parser Date: Thu, 26 Apr 2018 15:21:24 +0100 Message-ID: References: <20180416130605.6509-1-declan.doherty@intel.com> <20180426104105.18342-1-declan.doherty@intel.com> <20180426104105.18342-7-declan.doherty@intel.com> <2601191342CEEE43887BDE71AB977258AEBD049D@IRSMSX102.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Adrien Mazarguil , Thomas Monjalon , Shahaf Shuler , "Horton, Remy" To: "Ananyev, Konstantin" , "Doherty, Declan" , "dev@dpdk.org" Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id EB5F57CB6 for ; Thu, 26 Apr 2018 16:21:28 +0200 (CEST) In-Reply-To: <2601191342CEEE43887BDE71AB977258AEBD049D@IRSMSX102.ger.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/26/2018 1:03 PM, Ananyev, Konstantin wrote: > > >> -----Original Message----- >> From: Doherty, Declan >> Sent: Thursday, April 26, 2018 11:41 AM >> To: dev@dpdk.org >> Cc: Adrien Mazarguil ; Yigit, Ferruh ; Thomas Monjalon ; >> Shahaf Shuler ; Ananyev, Konstantin ; Horton, Remy ; >> Doherty, Declan >> Subject: [dpdk-dev][PATCH v8 6/9] ethdev: add common devargs parser >> >> From: Remy Horton >> >> Introduces a new structure, rte_eth_devargs, to support generic >> ethdev arguments common across NET PMDs, with a new API >> rte_eth_devargs_parse API to support PMD parsing these arguments. The >> patch add support for a representor argument passed with passed with >> the EAL -w option. The representor parameter allows the user to specify >> which representor ports to initialise on a device. >> >> The argument supports passing a single representor port, a list of >> port values or a range of port values. >> >> -w BDF,representor=1 # create representor port 1 on pci device BDF >> -w BDF,representor=[1,2,5,6,10] # create representor ports in list >> -w BDF,representor=[0-31] # create representor ports in range >> >> Signed-off-by: Remy Horton >> Signed-off-by: Declan Doherty >> --- >> doc/guides/prog_guide/poll_mode_drv.rst | 19 ++++ >> lib/Makefile | 1 + >> lib/librte_ether/rte_ethdev.c | 182 ++++++++++++++++++++++++++++++++ >> lib/librte_ether/rte_ethdev_driver.h | 30 ++++++ >> lib/librte_ether/rte_ethdev_version.map | 1 + >> 5 files changed, 233 insertions(+) >> >> diff --git a/doc/guides/prog_guide/poll_mode_drv.rst b/doc/guides/prog_guide/poll_mode_drv.rst >> index e5d01874e..09a93baec 100644 >> --- a/doc/guides/prog_guide/poll_mode_drv.rst >> +++ b/doc/guides/prog_guide/poll_mode_drv.rst >> @@ -345,6 +345,25 @@ Ethernet Device API >> >> The Ethernet device API exported by the Ethernet PMDs is described in the *DPDK API Reference*. >> >> +Ethernet Device Standard Device Arguments >> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> + >> +Standard Ethernet device arguments allow for a set of commonly used arguments/ >> +parameters which are applicable to all Ethernet devices to be available to for >> +specification of specific device and for passing common configuration >> +parameters to those ports. >> + >> +* ``representor`` for a device which supports the creation of representor ports >> + this argument allows user to specify which switch ports to enable port >> + representors for.:: >> + >> + -w BDBF,representor=0 >> + -w BDBF,representor=[0,4,6,9] >> + -w BDBF,representor=[0-31] >> + >> +Note: PMDs are not required to support the standard device arguments and users >> +should consult the relevant PMD documentation to see support devargs. >> + >> Extended Statistics API >> ~~~~~~~~~~~~~~~~~~~~~~~ >> >> diff --git a/lib/Makefile b/lib/Makefile >> index 965be6c8d..536775e59 100644 >> --- a/lib/Makefile >> +++ b/lib/Makefile >> @@ -21,6 +21,7 @@ DEPDIRS-librte_cmdline := librte_eal >> DIRS-$(CONFIG_RTE_LIBRTE_ETHER) += librte_ether >> DEPDIRS-librte_ether := librte_net librte_eal librte_mempool librte_ring >> DEPDIRS-librte_ether += librte_mbuf >> +DEPDIRS-librte_ether += librte_kvargs >> DIRS-$(CONFIG_RTE_LIBRTE_BBDEV) += librte_bbdev >> DEPDIRS-librte_bbdev := librte_eal librte_mempool librte_mbuf >> DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += librte_cryptodev >> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c >> index 621f8af7f..cb85d8bb7 100644 >> --- a/lib/librte_ether/rte_ethdev.c >> +++ b/lib/librte_ether/rte_ethdev.c >> @@ -34,6 +34,7 @@ >> #include >> #include >> #include >> ++#include >> >> #include "rte_ether.h" >> #include "rte_ethdev.h" >> @@ -4101,6 +4102,187 @@ rte_eth_dev_pool_ops_supported(uint16_t port_id, const char *pool) >> return (*dev->dev_ops->pool_ops_supported)(dev, pool); >> } >> >> +typedef int (*rte_eth_devargs_callback_t)(char *str, void *data); >> + >> +static int >> +rte_eth_devargs_tokenise(struct rte_kvargs *arglist, const char *str_in) >> +{ > > I still think that if you'd like to extend rte_kvarrgs to be able to parse something like: "key=[val1,val2,...,valn]", > you have to make it generic kvargs ability and put it into librte_kvargs, not try to introduce your own new parser here. > Imagine that in addition to your 'port=[val1,val2, ..valn]' devargs string would contain some extra (let say device specific) > parameters. > What would happen, when PMD will try to use rte_kvargs_parse() on such string? > My understanding - it would fail, correct? > > As an alternative - as I remember rte_kvargs allows you to have multiple identical key, i.e: "key=val1,key=val2,...,key=valn". > Why not to use that way, if you don't want to introduce extra code in rte_kvargs? Hi Declan, Remy, I will continue with existing patchset, for the sake of the rc1, can you please address these comments as incremental updates to the set? >> +static int >> +rte_eth_devargs_process_range(char *str, uint16_t *list, uint16_t *len_list, >> + const uint16_t max_list) >> +{ >> + uint16_t lo, hi, val; >> + int result; >> + >> + result = sscanf(str, "%hu-%hu", &lo, &hi); >> + if (result == 1) { >> + if (*len_list >= max_list) >> + return -ENOMEM; >> + list[(*len_list)++] = lo; >> + } else if (result == 2) { >> + if (lo >= hi || lo > RTE_MAX_ETHPORTS || hi > RTE_MAX_ETHPORTS) > > lo > RTE_MAX_ETHPORTS is redundant here. Same here, thanks.