From: "Christian König" <deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
To: Alex Deucher
<alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH] drm/amdgpu/gfx9: use actual gpu num se setting for ngg allocation
Date: Tue, 2 May 2017 09:55:38 +0200 [thread overview]
Message-ID: <adb7390b-355b-4d92-12d7-517f387188b2@vodafone.de> (raw)
In-Reply-To: <1493670134-17268-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
Am 01.05.2017 um 22:22 schrieb Alex Deucher:
> Rather than using a hardcoded value.
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> index cdd9ad5..d4a2212 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> @@ -39,7 +39,6 @@
>
> #define GFX9_NUM_GFX_RINGS 1
> #define GFX9_NUM_COMPUTE_RINGS 8
> -#define GFX9_NUM_SE 4
The other defines look superfluous as well, should be get rid of them?
Anyway this patch is Reviewed-by: Christian König <christian.koenig@amd.com>
Regards,
Christian.
> #define RLCG_UCODE_LOADING_START_ADDRESS 0x2000
>
> MODULE_FIRMWARE("amdgpu/vega10_ce.bin");
> @@ -814,7 +813,7 @@ static int gfx_v9_0_ngg_create_buf(struct amdgpu_device *adev,
> }
> size_se = size_se ? size_se : default_size_se;
>
> - ngg_buf->size = size_se * GFX9_NUM_SE;
> + ngg_buf->size = size_se * adev->gfx.config.max_shader_engines;
> r = amdgpu_bo_create_kernel(adev, ngg_buf->size,
> PAGE_SIZE, AMDGPU_GEM_DOMAIN_VRAM,
> &ngg_buf->bo,
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2017-05-02 7:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-01 20:22 [PATCH] drm/amdgpu/gfx9: use actual gpu num se setting for ngg allocation Alex Deucher
[not found] ` <1493670134-17268-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2017-05-02 7:55 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adb7390b-355b-4d92-12d7-517f387188b2@vodafone.de \
--to=deathsimple-antagkrnahcb1svskn2v4q@public.gmane.org \
--cc=alexander.deucher-5C7GfCeVMHo@public.gmane.org \
--cc=alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.