From: Himanshu Madhani <himanshu.madhani@oracle.com>
To: Zhen Lei <thunder.leizhen@huawei.com>,
Nilesh Javali <njavali@marvell.com>,
GR-QLogic-Storage-Upstream@marvell.com,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Giridhar Malavali <giridhar.malavali@qlogic.com>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 1/1] scsi: qla2xxx: Fix error return code in qla82xx_write_flash_dword()
Date: Fri, 14 May 2021 09:00:12 -0500 [thread overview]
Message-ID: <adc45319-21f4-db03-89ae-972ab17b5172@oracle.com> (raw)
In-Reply-To: <20210514090952.6715-1-thunder.leizhen@huawei.com>
On 5/14/21 4:09 AM, Zhen Lei wrote:
> Fix to return a negative error code from the error handling case instead
> of 0, as done elsewhere in this function.
>
> Fixes: a9083016a531 ("[SCSI] qla2xxx: Add ISP82XX support.")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> drivers/scsi/qla2xxx/qla_nx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_nx.c b/drivers/scsi/qla2xxx/qla_nx.c
> index 0677295957bc5cb..615e44af1ca6043 100644
> --- a/drivers/scsi/qla2xxx/qla_nx.c
> +++ b/drivers/scsi/qla2xxx/qla_nx.c
> @@ -1063,7 +1063,8 @@ qla82xx_write_flash_dword(struct qla_hw_data *ha, uint32_t flashaddr,
> return ret;
> }
>
> - if (qla82xx_flash_set_write_enable(ha))
> + ret = qla82xx_flash_set_write_enable(ha);
> + if (ret < 0)
> goto done_write;
>
> qla82xx_wr_32(ha, QLA82XX_ROMUSB_ROM_WDATA, data);
>
Makes sense.
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
next prev parent reply other threads:[~2021-05-14 14:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 9:09 [PATCH 1/1] scsi: qla2xxx: Fix error return code in qla82xx_write_flash_dword() Zhen Lei
2021-05-14 14:00 ` Himanshu Madhani [this message]
2021-05-15 22:14 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adc45319-21f4-db03-89ae-972ab17b5172@oracle.com \
--to=himanshu.madhani@oracle.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=giridhar.malavali@qlogic.com \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=njavali@marvell.com \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.