Re: [PATCH v1 3/9] perf util: Reconstruct rblist for supporting per-thread shadow stats

From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
	mingo@redhat.com, alexander.shishkin@linux.intel.com,
	Linux-kernel@vger.kernel.org, ak@linux.intel.com,
	kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v1 3/9] perf util: Reconstruct rblist for supporting per-thread shadow stats
Date: Wed, 22 Nov 2017 14:57:12 +0800	[thread overview]
Message-ID: <adc71144-0026-6fed-224e-de619f76ba43@linux.intel.com> (raw)
In-Reply-To: <d60a2182-26b0-7df9-db02-4b2b092effbd@linux.vnet.ibm.com>

On 11/22/2017 2:31 PM, Ravi Bangoria wrote:
> 
> On 11/20/2017 08:13 PM, Jin Yao wrote:
>> @@ -76,6 +97,17 @@ static struct rb_node *saved_value_new(struct 
>> rblist *rblist __maybe_unused,
>>       return &nd->rb_node;
>>   }
>>
>> +static void saved_value_delete(struct rblist *rblist __maybe_unused,
>> +                   struct rb_node *rb_node)
>> +{
>> +    struct saved_value *v = container_of(rb_node,
>> +                         struct saved_value,
>> +                         rb_node);
>> +
>> +    if (v)
>> +        free(v);
>> +}
> 
> Do we really need if(v) ?
> 
> Thanks,
> Ravi
> 

Hi Ravi,

Looks it doesn't need if(v).

I put if(v) here is from my coding habits (checking pointer before free).

It's OK for me if you think the code should be removed.

Thanks
Jin Yao