From: "Raphaël Gertz" <mageia@rapsys.eu>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Ralf Thielow" <ralf.thielow@gmail.com>,
"Jakub Narębski" <jnareb@gmail.com>,
git@vger.kernel.org
Subject: Re: gitweb html validation
Date: Wed, 16 Nov 2016 10:25:44 +0100 [thread overview]
Message-ID: <add4ba7fced68430c421c6b0ec388a13@rapsys.eu> (raw)
In-Reply-To: <xmqqy40ks301.fsf@gitster.mtv.corp.google.com>
Le 16.11.2016 01:05, Junio C Hamano a écrit :
> Ralf Thielow <ralf.thielow@gmail.com> writes:
>
>> Only block level elements are
>> allowed to be inside form tags, according to
>> https://www.w3.org/2010/04/xhtml10-strict.html#elem_form
>> ...
>> I think it's better to just move the <form>-Tag outside of the
>> surrounding div?
>> Something like this perhaps, I didn't test it myself yet.
>
> That sounds like a sensible update to me (no, I do not run gitweb
> myself). Is this the only <form> we have in the UI, or is it the
> only one that is problematic?
>
There is an other form in the cgi line 4110 :
print $cgi->start_form(-method => "get", -action => $action) .
"<div class=\"search\">\n" .
But this one has a <div class="search"> inside.
The problem with projsearch I want to change is that the div is around
the form without a container inside.
I agree with moving the <div class="projsearch"> inside the form if it's
a better option.
Best regards
next prev parent reply other threads:[~2016-11-16 9:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 15:13 gitweb html validation Raphaël Gertz
2016-11-15 18:26 ` Ralf Thielow
2016-11-16 0:05 ` Junio C Hamano
2016-11-16 9:25 ` Raphaël Gertz [this message]
2016-11-18 20:06 ` Ralf Thielow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=add4ba7fced68430c421c6b0ec388a13@rapsys.eu \
--to=mageia@rapsys.eu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=ralf.thielow@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.