From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net-next 09/11] devlink: convert occ_get op to separate registration Date: Wed, 4 Apr 2018 17:00:18 -0600 Message-ID: References: <20180329203334.25575-1-idosch@mellanox.com> <20180329203334.25575-10-idosch@mellanox.com> <5f2dc834-0d8a-77ef-3d33-2228e7bd530c@gmail.com> <20180403073212.GI3313@nanopsycho> <20180403153020.GJ3313@nanopsycho> <289e6c36-5e8d-139a-9fa4-575cf9fe86a1@gmail.com> <20180404062511.GO3313@nanopsycho> <20180404155910.7baf2ec9@cakuba.netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Ido Schimmel , netdev@vger.kernel.org, davem@davemloft.net, jiri@mellanox.com, petrm@mellanox.com, mlxsw@mellanox.com To: Jakub Kicinski , Jiri Pirko Return-path: Received: from mail-pl0-f68.google.com ([209.85.160.68]:33271 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752365AbeDDXAV (ORCPT ); Wed, 4 Apr 2018 19:00:21 -0400 Received: by mail-pl0-f68.google.com with SMTP id s10-v6so14338381plp.0 for ; Wed, 04 Apr 2018 16:00:21 -0700 (PDT) In-Reply-To: <20180404155910.7baf2ec9@cakuba.netronome.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 4/4/18 4:59 PM, Jakub Kicinski wrote: > On Wed, 4 Apr 2018 08:25:11 +0200, Jiri Pirko wrote: >>> Jiri, I am not aware of any other API where a driver registers with it >>> yet doesn't want the handler to be called so either waits to register >> >> Again, the thing is, this is kind of unusual because of the reload >> thing. > > FWIW my knee jerk thought is that it's strange that devlink ops can > be executed at all while reload is happening (incl. another reload > request). I'm probably missing the real issue.. > Just responding with the same question ... Why are you not unregistering resources on a reload?