From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7FA2C433F5 for ; Wed, 16 Mar 2022 05:33:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238258AbiCPFfB (ORCPT ); Wed, 16 Mar 2022 01:35:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232644AbiCPFfA (ORCPT ); Wed, 16 Mar 2022 01:35:00 -0400 Received: from mx1.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F0B35A5A8 for ; Tue, 15 Mar 2022 22:33:45 -0700 (PDT) Received: from [192.168.0.3] (ip5f5aef39.dynamic.kabel-deutschland.de [95.90.239.57]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id 55D1061EA1929; Wed, 16 Mar 2022 06:33:44 +0100 (CET) Message-ID: Date: Wed, 16 Mar 2022 06:33:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: bnx2x: ppc64le: Unable to set message level greater than 0x7fff Content-Language: en-US From: Paul Menzel To: Jakub Kicinski , Michal Kubecek Cc: Ariel Elior , Sudarsana Kalluru , Manish Chopra , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, it+netdev@molgen.mpg.de References: <0497a560-8c7b-7cf8-84ee-bde1470ae360@molgen.mpg.de> <20220315183529.255f2795@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Dear Jakub, Sorry, one more addition. Am 16.03.22 um 06:16 schrieb Paul Menzel: > Am 16.03.22 um 02:35 schrieb Jakub Kicinski: >> On Tue, 15 Mar 2022 22:58:57 +0100 Paul Menzel wrote: >>> On the POWER8 server IBM S822LC (ppc64le), I am unable to set the >>> message level for the network device to 0x0100000 but it fails. >>> >>>       $ sudo ethtool -s enP1p1s0f2 msglvl 0x0100000 >>>       netlink error: cannot modify bits past kernel bitset size (offset 56) >>>       netlink error: Invalid argument >>> >>> Below is more information. 0x7fff is the largest value I am able to set. >>> >>> ``` >>> $ sudo ethtool -i enP1p1s0f2 >>> driver: bnx2x >>> version: 5.17.0-rc7+ >>> firmware-version: bc 7.10.4 >>> expansion-rom-version: >>> bus-info: 0001:01:00.2 >>> supports-statistics: yes >>> supports-test: yes >>> supports-eeprom-access: yes >>> supports-register-dump: yes >>> supports-priv-flags: yes >>> $ sudo ethtool -s enP1p1s0f2 msglvl 0x7fff >>> $ sudo ethtool enP1p1s0f2 >>> Settings for enP1p1s0f2: >>>           Supported ports: [ TP ] >>>           Supported link modes:   10baseT/Half 10baseT/Full >>>                                   100baseT/Half 100baseT/Full >>>                                   1000baseT/Full >>>           Supported pause frame use: Symmetric Receive-only >>>           Supports auto-negotiation: Yes >>>           Supported FEC modes: Not reported >>>           Advertised link modes:  10baseT/Half 10baseT/Full >>>                                   100baseT/Half 100baseT/Full >>>                                   1000baseT/Full >>>           Advertised pause frame use: Symmetric Receive-only >>>           Advertised auto-negotiation: Yes >>>           Advertised FEC modes: Not reported >>>           Speed: Unknown! >>>           Duplex: Unknown! (255) >>>           Auto-negotiation: on >>>           Port: Twisted Pair >>>           PHYAD: 17 >>>           Transceiver: internal >>>           MDI-X: Unknown >>>           Supports Wake-on: g >>>           Wake-on: d >>>           Current message level: 0x00007fff (32767) >>>                                  drv probe link timer ifdown ifup rx_err tx_err tx_queued intr tx_done rx_status pktdata hw wol >>>           Link detected: no >>> $ sudo ethtool -s enP1p1s0f2 msglvl 0x8000 >>> netlink error: cannot modify bits past kernel bitset size (offset 56) >>> netlink error: Invalid argument >>> ``` >> >> The new ethtool-over-netlink API limits the msg levels to the ones >> officially defined by the kernel (NETIF_MSG_CLASS_COUNT). >> >> CC: Michal > > Thank you for the prompt reply. So, it’s unrelated to the architecture, > and to the Linux kernel version, as it works on x86_64 with Linux 5.10.x. > > Michal, how do I turn on certain bnx2x messages? > >     $ git grep BNX2X_MSG_SP drivers/net/ethernet/broadcom/bnx2x/bnx2x.h >     drivers/net/ethernet/broadcom/bnx2x/bnx2x.h:#define BNX2X_MSG_SP >                      0x0100000 /* was: NETIF_MSG_INTR */ Testing this on the x86_64 Dell OptiPlex 5055 with a Broadcom NetXtreme BCM5762 Gigabit Ethernet PCIe [14e4:1687], it still works. ``` $ uname -a Linux serotimor.molgen.mpg.de 5.17.0-rc5.mx64.428 #1 SMP PREEMPT Mon Feb 21 04:00:47 CET 2022 x86_64 GNU/Linux $ sudo ethtool -s net00 msglvl 0x0100000 $ ethtool net00 Settings for net00: Supported ports: [ TP ] Supported link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Half 1000baseT/Full Supported pause frame use: No Supports auto-negotiation: Yes Advertised link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Half 1000baseT/Full Advertised pause frame use: Symmetric Advertised auto-negotiation: Yes Link partner advertised link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Full Link partner advertised pause frame use: No Link partner advertised auto-negotiation: Yes Speed: 1000Mb/s Duplex: Full Port: Twisted Pair PHYAD: 1 Transceiver: internal Auto-negotiation: on MDI-X: off Cannot get wake-on-lan settings: Operation not permitted Current message level: 0x00100000 (1048576) 0x100000 Link detected: yes $ sudo ethtool -s net00 msglvl 0xfffffff $ ethtool net00 Settings for net00: Supported ports: [ TP ] Supported link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Half 1000baseT/Full Supported pause frame use: No Supports auto-negotiation: Yes Advertised link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Half 1000baseT/Full Advertised pause frame use: Symmetric Advertised auto-negotiation: Yes Link partner advertised link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Full Link partner advertised pause frame use: No Link partner advertised auto-negotiation: Yes Speed: 1000Mb/s Duplex: Full Port: Twisted Pair PHYAD: 1 Transceiver: internal Auto-negotiation: on MDI-X: off Cannot get wake-on-lan settings: Operation not permitted Current message level: 0x0fffffff (268435455) drv probe link timer ifdown ifup rx_err tx_err tx_queued intr tx_done rx_status pktdata hw wol 0xfff8000 Link detected: yes ``` Kind regards, Paul From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8746C433F5 for ; Wed, 16 Mar 2022 05:34:12 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KJJqR25Hsz3bTf for ; Wed, 16 Mar 2022 16:34:11 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=molgen.mpg.de (client-ip=141.14.17.11; helo=mx1.molgen.mpg.de; envelope-from=pmenzel@molgen.mpg.de; receiver=) Received: from mx1.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KJJpz4VJ7z306d for ; Wed, 16 Mar 2022 16:33:47 +1100 (AEDT) Received: from [192.168.0.3] (ip5f5aef39.dynamic.kabel-deutschland.de [95.90.239.57]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id 55D1061EA1929; Wed, 16 Mar 2022 06:33:44 +0100 (CET) Message-ID: Date: Wed, 16 Mar 2022 06:33:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: bnx2x: ppc64le: Unable to set message level greater than 0x7fff Content-Language: en-US From: Paul Menzel To: Jakub Kicinski , Michal Kubecek References: <0497a560-8c7b-7cf8-84ee-bde1470ae360@molgen.mpg.de> <20220315183529.255f2795@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ariel Elior , Manish Chopra , netdev@vger.kernel.org, it+netdev@molgen.mpg.de, linuxppc-dev@lists.ozlabs.org, Sudarsana Kalluru Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Dear Jakub, Sorry, one more addition. Am 16.03.22 um 06:16 schrieb Paul Menzel: > Am 16.03.22 um 02:35 schrieb Jakub Kicinski: >> On Tue, 15 Mar 2022 22:58:57 +0100 Paul Menzel wrote: >>> On the POWER8 server IBM S822LC (ppc64le), I am unable to set the >>> message level for the network device to 0x0100000 but it fails. >>> >>>       $ sudo ethtool -s enP1p1s0f2 msglvl 0x0100000 >>>       netlink error: cannot modify bits past kernel bitset size (offset 56) >>>       netlink error: Invalid argument >>> >>> Below is more information. 0x7fff is the largest value I am able to set. >>> >>> ``` >>> $ sudo ethtool -i enP1p1s0f2 >>> driver: bnx2x >>> version: 5.17.0-rc7+ >>> firmware-version: bc 7.10.4 >>> expansion-rom-version: >>> bus-info: 0001:01:00.2 >>> supports-statistics: yes >>> supports-test: yes >>> supports-eeprom-access: yes >>> supports-register-dump: yes >>> supports-priv-flags: yes >>> $ sudo ethtool -s enP1p1s0f2 msglvl 0x7fff >>> $ sudo ethtool enP1p1s0f2 >>> Settings for enP1p1s0f2: >>>           Supported ports: [ TP ] >>>           Supported link modes:   10baseT/Half 10baseT/Full >>>                                   100baseT/Half 100baseT/Full >>>                                   1000baseT/Full >>>           Supported pause frame use: Symmetric Receive-only >>>           Supports auto-negotiation: Yes >>>           Supported FEC modes: Not reported >>>           Advertised link modes:  10baseT/Half 10baseT/Full >>>                                   100baseT/Half 100baseT/Full >>>                                   1000baseT/Full >>>           Advertised pause frame use: Symmetric Receive-only >>>           Advertised auto-negotiation: Yes >>>           Advertised FEC modes: Not reported >>>           Speed: Unknown! >>>           Duplex: Unknown! (255) >>>           Auto-negotiation: on >>>           Port: Twisted Pair >>>           PHYAD: 17 >>>           Transceiver: internal >>>           MDI-X: Unknown >>>           Supports Wake-on: g >>>           Wake-on: d >>>           Current message level: 0x00007fff (32767) >>>                                  drv probe link timer ifdown ifup rx_err tx_err tx_queued intr tx_done rx_status pktdata hw wol >>>           Link detected: no >>> $ sudo ethtool -s enP1p1s0f2 msglvl 0x8000 >>> netlink error: cannot modify bits past kernel bitset size (offset 56) >>> netlink error: Invalid argument >>> ``` >> >> The new ethtool-over-netlink API limits the msg levels to the ones >> officially defined by the kernel (NETIF_MSG_CLASS_COUNT). >> >> CC: Michal > > Thank you for the prompt reply. So, it’s unrelated to the architecture, > and to the Linux kernel version, as it works on x86_64 with Linux 5.10.x. > > Michal, how do I turn on certain bnx2x messages? > >     $ git grep BNX2X_MSG_SP drivers/net/ethernet/broadcom/bnx2x/bnx2x.h >     drivers/net/ethernet/broadcom/bnx2x/bnx2x.h:#define BNX2X_MSG_SP >                      0x0100000 /* was: NETIF_MSG_INTR */ Testing this on the x86_64 Dell OptiPlex 5055 with a Broadcom NetXtreme BCM5762 Gigabit Ethernet PCIe [14e4:1687], it still works. ``` $ uname -a Linux serotimor.molgen.mpg.de 5.17.0-rc5.mx64.428 #1 SMP PREEMPT Mon Feb 21 04:00:47 CET 2022 x86_64 GNU/Linux $ sudo ethtool -s net00 msglvl 0x0100000 $ ethtool net00 Settings for net00: Supported ports: [ TP ] Supported link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Half 1000baseT/Full Supported pause frame use: No Supports auto-negotiation: Yes Advertised link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Half 1000baseT/Full Advertised pause frame use: Symmetric Advertised auto-negotiation: Yes Link partner advertised link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Full Link partner advertised pause frame use: No Link partner advertised auto-negotiation: Yes Speed: 1000Mb/s Duplex: Full Port: Twisted Pair PHYAD: 1 Transceiver: internal Auto-negotiation: on MDI-X: off Cannot get wake-on-lan settings: Operation not permitted Current message level: 0x00100000 (1048576) 0x100000 Link detected: yes $ sudo ethtool -s net00 msglvl 0xfffffff $ ethtool net00 Settings for net00: Supported ports: [ TP ] Supported link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Half 1000baseT/Full Supported pause frame use: No Supports auto-negotiation: Yes Advertised link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Half 1000baseT/Full Advertised pause frame use: Symmetric Advertised auto-negotiation: Yes Link partner advertised link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Full Link partner advertised pause frame use: No Link partner advertised auto-negotiation: Yes Speed: 1000Mb/s Duplex: Full Port: Twisted Pair PHYAD: 1 Transceiver: internal Auto-negotiation: on MDI-X: off Cannot get wake-on-lan settings: Operation not permitted Current message level: 0x0fffffff (268435455) drv probe link timer ifdown ifup rx_err tx_err tx_queued intr tx_done rx_status pktdata hw wol 0xfff8000 Link detected: yes ``` Kind regards, Paul