From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51FE6C433E6 for ; Tue, 5 Jan 2021 16:15:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 24C1722C9E for ; Tue, 5 Jan 2021 16:15:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728245AbhAEQOy (ORCPT ); Tue, 5 Jan 2021 11:14:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728097AbhAEQOy (ORCPT ); Tue, 5 Jan 2021 11:14:54 -0500 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F85AC061574 for ; Tue, 5 Jan 2021 08:14:13 -0800 (PST) Received: by mail-ed1-x536.google.com with SMTP id j16so851104edr.0 for ; Tue, 05 Jan 2021 08:14:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=B2XI9Y2wlyHiEShnQJz2HRGu3YR6k36r4B9FvaQe2v8=; b=YaJOy/HjCwM7OcV7prVs8bCAb5x7TlFfJpi1tuXRpUGOxWKA5zOXRpJY6jvPonBBsY 5LE+qXM7gfTmUWKte2mTjSTv19saQ5X/JPU3J9jRe970hhpw5e+oIB1iIkubwoSdrRNj Hil3h4xXaKqON1Vq+BphcOTepo4zTA+HJT20AXIuzlj0g3B6Mik8DWlx8no0d0UqSoOM pNXjc7t53JpCwU5bJ3o/Yo85MGFn4QxP4JRTJ/EEMwcHO8w27ohLvVqwY1IBm7XJfVsT DxNw99rQIrBlWbZny8NBPr5e2toi0zjQTCxwQsCZEXtR56kkfGV/OkjpfTDthxYGK5Lz jRbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=B2XI9Y2wlyHiEShnQJz2HRGu3YR6k36r4B9FvaQe2v8=; b=E7OVDbMJzQoCFuQ0AJ/tWM4w0OyXoObOrg3/2nbo/HMiz3ALK04N8Jhce5yn4CMHVc dnwqR/rzANUsw5G8Ik84907j8h147Z+7AAqQeM4r2zSgy4Tsg+eM89jUBkBI3NgnBu/M d+ntEmR+MwuBXfDyGDuh7t2C4+wxR+ExiLhK3LPP73/wjd6pmggHKyjRNL0bI+VBhMZj iTTIK+vxGndktX0Isd+RIdlpnPu8V4RjTHKmmMcYWJ7slDI3Q96G1j1lIIi6vXoEA3go RIdXL0+2WOLUU7etRIfeY+qn31J3gv7Y0SeOMV6ugOEY74mr/oncLaCui5LXc8c6G9gV M1/A== X-Gm-Message-State: AOAM5304WyLSqME8V4rwT7YvJ4L49EO7RnElgDSAD8jP9xg2K/UGell1 IzVOtsedjEvjTTR/s15h3RM= X-Google-Smtp-Source: ABdhPJzD8DsR/a8w1W08UJoEMY1hsQICAvOTT60gQ5DXupklDi5lRTeaHlxTd6Tmo31Q+ZEBAC/gtA== X-Received: by 2002:a05:6402:c4:: with SMTP id i4mr502209edu.152.1609863252367; Tue, 05 Jan 2021 08:14:12 -0800 (PST) Received: from kontron.lan (2001-1ae9-1e8-b200-9c26-b1f7-3f54-fb94.ip6.tmcz.cz. [2001:1ae9:1e8:b200:9c26:b1f7:3f54:fb94]) by smtp.gmail.com with ESMTPSA id c23sm45724192eds.88.2021.01.05.08.14.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Jan 2021 08:14:11 -0800 (PST) Subject: Re: [PATCH 3/6] media: ov9640: Use the generic clock framework To: Ezequiel Garcia , linux-media@vger.kernel.org, Hans Verkuil Cc: kernel@collabora.com, Arnd Bergmann , Robert Jarzmik , Janusz Krzysztofik , Sakari Ailus References: <20210104165739.116404-1-ezequiel@collabora.com> <20210104165739.116404-4-ezequiel@collabora.com> From: Petr Cvek Message-ID: Date: Tue, 5 Jan 2021 17:18:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210104165739.116404-4-ezequiel@collabora.com> Content-Type: text/plain; charset=iso-8859-2 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org > diff --git a/drivers/media/i2c/ov9640.h b/drivers/media/i2c/ov9640.h > index a8ed6992c1a8..a1f9150b2050 100644 > --- a/drivers/media/i2c/ov9640.h > +++ b/drivers/media/i2c/ov9640.h > @@ -180,6 +180,8 @@ enum { > }; > #define H_SXGA 960 > > +struct clk; > + Seems to be unnecessary as struct clk will be included from ov9640.c (the same way struct v4l2_clk was). The rest seems fine by me. Petr