From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCEA7C10F13 for ; Sun, 14 Apr 2019 09:48:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 909C22084E for ; Sun, 14 Apr 2019 09:48:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l0tTmI/f" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726126AbfDNJsu (ORCPT ); Sun, 14 Apr 2019 05:48:50 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:33644 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725797AbfDNJst (ORCPT ); Sun, 14 Apr 2019 05:48:49 -0400 Received: by mail-wm1-f66.google.com with SMTP id z6so3836512wmi.0 for ; Sun, 14 Apr 2019 02:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=bAG5bBrRfF6Y9kVKnURIPu4MVUhnjOdfwtV2pJqnagw=; b=l0tTmI/ft0LXYpS1xBOx+JuQT/yEXf6Y9laOOS0HEBZODptpvKeA5d/xpBSOjEl+bK ub8CvfUqll6/2iaoRJBa41vJUxK7cJmYzsP4u6zC3YRIJUPfTMN+rNKxQCwvJbvz8uIx M3UZ34d70UwZB+oAusYqn9oEVdr3A3rVAkexbN9LtzSHoTL2J4sHwfy4F7RY1Uf+JGs9 vW1iKrPfS3m+ZpZpxpnp7x3M4v6+FSn9A+bTaBvpm5yLkBAh7Jaq/27Pmromvz+hBUNK isSzVHhvwPGXMihiNLJahHNZOHeICKJzaPLUswSp+TVEAJ+zSSJEBOFHlR10+fUUE7jw vDQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=bAG5bBrRfF6Y9kVKnURIPu4MVUhnjOdfwtV2pJqnagw=; b=m2Y34e8qsesg+inHr+C+QpqXZ8XtHx4bCJrn81PQP64xRjKuxIXF2jnBqY3HbqA0Y4 +P3cnHmVfgbA7QanCTYkgtWeClaH8jefL4sQe5XEEgHbGMlSpdjzCnCMxkmzAY8dW1GX +wbXm1q5mRdwo3l/aoU+CX8VysfBk6wWzUixIjn1T7EtCItvk9E7ZSIRBgJYCQaSs2nj 5UUscUH8/5lFGPk3//yBbeM8Jy4UewWlJInmp+QYhEElvN19EIohtqiGzjn+4qu7JCG5 daHjd/tbA3/+mz5TXZuch+OxhAEBYrIW7HkI1hZBzinMZwg0JEgNj9ZVtE53Lb21obS6 ApcQ== X-Gm-Message-State: APjAAAUxFReRxRUDOuL3U3dtLncXmsz3MNOhLHXYot4fYuqaCWt8yxku IkR/EwzeS3tVTlD2ln765fiH5wSO X-Google-Smtp-Source: APXvYqzEVhW9I/KBCNBi6viB0lN/C8RSukATnfm6DX/b94IeIDXodOopdKoUegTYFcTxDfUW8A1lWg== X-Received: by 2002:a1c:6783:: with SMTP id b125mr17815720wmc.41.1555235327933; Sun, 14 Apr 2019 02:48:47 -0700 (PDT) Received: from ?IPv6:2003:ea:8bd4:5700:9d34:bb86:3225:b2fd? (p200300EA8BD457009D34BB863225B2FD.dip0.t-ipconnect.de. [2003:ea:8bd4:5700:9d34:bb86:3225:b2fd]) by smtp.googlemail.com with ESMTPSA id a4sm28754541wmf.45.2019.04.14.02.48.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 14 Apr 2019 02:48:47 -0700 (PDT) To: Realtek linux nic maintainers , David Miller Cc: "netdev@vger.kernel.org" From: Heiner Kallweit Subject: [PATCH net-next] r8169: change irq handler to always trigger NAPI polling Message-ID: Date: Sun, 14 Apr 2019 11:48:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This check isn't really needed and we can simplify the code and save some CPU cycles by removing it. Only in case of an error none of these bits are set, and calling the NAPI callback doesn't hurt in this case. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 68caa26f0..efaea1a0a 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -6380,10 +6380,8 @@ static irqreturn_t rtl8169_interrupt(int irq, void *dev_instance) set_bit(RTL_FLAG_TASK_RESET_PENDING, tp->wk.flags); } - if (status & (RTL_EVENT_NAPI | LinkChg)) { - rtl_irq_disable(tp); - napi_schedule_irqoff(&tp->napi); - } + rtl_irq_disable(tp); + napi_schedule_irqoff(&tp->napi); out: rtl_ack_events(tp, status); -- 2.21.0