From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Sat, 9 May 2020 13:52:42 +0200 Subject: [PATCH 1/2] arm: mvebu: armada-370-xp.dtsi: add u-boot,dm-pre-reloc to spi0 In-Reply-To: <41088DD6-9363-48BE-B162-0D823C4FE257@easyb.ch> References: <20200503200039.11816-1-ezra@easyb.ch> <62A66494-31C8-4623-80A0-83C7D6050FD7@easyb.ch> <3C150482-1E34-43C3-AC04-F7FB6989B488@easyb.ch> <5b84fa45-c2f6-ff32-35f9-fb874e96f5b6@denx.de> <41088DD6-9363-48BE-B162-0D823C4FE257@easyb.ch> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Ezra, On 09.05.20 10:10, Ezra Buehler wrote: > On 5 May 2020, at 10:58, Stefan Roese wrote: >> >> Hi Ezra, >> >> On 05.05.20 09:10, Ezra Buehler wrote: >>> On 5 May 2020, at 08:45, Stefan Roese wrote: >>>> U-Boot specific DT properties, like "u-boot,dm-pre-reloc" should be >>>> added in U-Boot specific DT dtsi files >>> OK, that makes sense. However, in your commit 1718a9f3b7 (arm: mvebu: >>> armada-370-xp.dtsi: Add "u-boot, dm-pre-reloc" to "internal-regs") you >>> wrote: >>> I'm not adding this property in an *u-boot.dtsi file, since there is >>> none matching the generic rules for all files including this dtsi >>> file. So to not miss any of the boards using this dtsi file, I'm >>> adding it to this file directly, which makes the Linux merge a less >>> easy unforunately. >>> So, do you want me to try this now? >> >> Hmmm, I can't remember the exact details. Thanks for the reference. >> But perhaps there is a matching *-u-boot.dtsi rule / pattern that can >> be used to include such a newly introduced file. I would very much >> welcome it, when you would investigate here. >> >> Thanks, >> Stefan > > From looking at other *.dtsi files I understand one would have to > include the armada-370-xp-u-boot.dtsi in armada-370-xp.dtsi in order to > move the U-Boot-specific properties out. I guess one should then do this > for other boards too. I am not sure if I am confortable with touching > all these boards. Maybe one should do this the next time when syncing > the DTS files with Linux. > > If it is OK for you, for this patch, I would simply introduce a > armada-xp-synology-ds414-u-boot.dtsi as Chris suggested. Yes, please continue this way. Thanks, Stefan