All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Shawn Guo <shawn.guo@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@intel.com>,
	linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 2/2] pinctrl: qcom: sc8180x: add ACPI probe support
Date: Sun, 7 Mar 2021 12:54:34 +0100	[thread overview]
Message-ID: <adf598dc-d000-15d1-d14d-b782455507f2@somainline.org> (raw)
In-Reply-To: <20210304060520.24975-3-shawn.guo@linaro.org>

Hi, 

>  
> +static const int sc8180x_acpi_reserved_gpios[] = {
> +	0, 1, 2, 3,
> +	47, 48, 49, 50,
> +	126, 127, 128, 129,
> +	-1 /* terminator */
> +};
> +
These can vary per device (unless Qualcomm is enforcing something on the SC platform), so I don't think hardcoding is a good option.. Isn't there any data being passed on which ones should not be touched?

Konrad

  parent reply	other threads:[~2021-03-07 11:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-04  6:05 [PATCH v3 0/2] Add ACPI support for SC8180X pinctrl driver Shawn Guo
2021-03-04  6:05 ` [PATCH v3 1/2] pinctrl: qcom: sc8180x: drop the use of tiles Shawn Guo
2021-03-09  1:08   ` Bjorn Andersson
2021-03-09  2:56     ` Shawn Guo
2021-03-09  3:42       ` Bjorn Andersson
2021-03-10 10:37         ` Shawn Guo
2021-03-04  6:05 ` [PATCH v3 2/2] pinctrl: qcom: sc8180x: add ACPI probe support Shawn Guo
2021-03-04 12:44   ` Andy Shevchenko
2021-03-07 11:54   ` Konrad Dybcio [this message]
2021-03-08 23:42     ` Bjorn Andersson
2021-03-04 12:44 ` [PATCH v3 0/2] Add ACPI support for SC8180X pinctrl driver Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adf598dc-d000-15d1-d14d-b782455507f2@somainline.org \
    --to=konrad.dybcio@somainline.org \
    --cc=andriy.shevchenko@intel.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.