From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9270C2BA19 for ; Wed, 15 Apr 2020 15:55:42 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F5CB2063A for ; Wed, 15 Apr 2020 15:55:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F5CB2063A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jOkNr-00020g-TN; Wed, 15 Apr 2020 15:55:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jOkNq-00020Y-HN for xen-devel@lists.xenproject.org; Wed, 15 Apr 2020 15:55:26 +0000 X-Inumbo-ID: 85209668-7f31-11ea-83d8-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 85209668-7f31-11ea-83d8-bc764e2007e4; Wed, 15 Apr 2020 15:55:25 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 794D3ACCE; Wed, 15 Apr 2020 15:55:23 +0000 (UTC) Subject: Re: [XEN PATCH v4 06/18] xen/build: have the root Makefile generates the CFLAGS To: Anthony PERARD References: <20200331103102.1105674-1-anthony.perard@citrix.com> <20200331103102.1105674-7-anthony.perard@citrix.com> <20200415141045.GB4088@perard.uk.xensource.com> From: Jan Beulich Message-ID: Date: Wed, 15 Apr 2020 17:55:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200415141045.GB4088@perard.uk.xensource.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , xen-devel@lists.xenproject.org, Daniel De Graaf , Volodymyr Babchuk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 15.04.2020 16:10, Anthony PERARD wrote: > On Wed, Apr 08, 2020 at 01:50:33PM +0200, Jan Beulich wrote: >> On 31.03.2020 12:30, Anthony PERARD wrote: >>> # Always build obj-bin files as binary even if they come from C source. >>> -$(obj-bin-y): CFLAGS := $(filter-out -flto,$(CFLAGS)) >>> +# FIXME LTO broken, but we would need a different way to filter -flto out >>> +# $(obj-bin-y): CFLAGS := $(filter-out -flto,$(CFLAGS)) >> >> While you mention this in the description, I'm still not overly >> happy with it getting commented out. What's wrong with making the >> construct simply act on c_flags? > > It doesn't work. > > I tried > $(obj-bin-y): c_flags := $(filter-out -flto,$(c_flags)) > but the $@ expansion was empty. Hmm, yes, presumably because of having to use :=. But the old code gives the appearance of having worked despite this fact. > I guess we could do: > $(obj-bin-y): XEN_CFLAGS := $(filter-out -flto,$(XEN_CFLAGS)) > that's probably enough for now. Even if we can't test it properly. If -flto gets added to XEN_CFLAGS (not c_flags) - why not? Jan