From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D315EC4332F for ; Mon, 5 Dec 2022 19:42:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234943AbiLETmZ (ORCPT ); Mon, 5 Dec 2022 14:42:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234868AbiLETly (ORCPT ); Mon, 5 Dec 2022 14:41:54 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70996DFA8 for ; Mon, 5 Dec 2022 11:39:33 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id n7so9581123wms.3 for ; Mon, 05 Dec 2022 11:39:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7pzik94DCRnikniychtCYn/if7UtyQkTWFCyd0BXZAs=; b=mPhxALAdZmhXA3LNUW3pO/6N9g17MLwyztZmXWZVb6a+DOYDAztdnk9+7GRr2lj+ON g3Y0gaqlIYyK/dkcOudswwzJYkV4QDFemDAKFOZfsxvEDrRuEjyHENJguwDr9rneRstQ Ys/AJ4BPPEWzUWUgGjyHCjTxK4WjajfsVRjLXweIKCPHc4b78j6VizaBs97dSVp/C2Wr DutF4W6xrJ9/AQ15NTZHpvCKMvVTx0MJokJnFrUyyrCJn29dWhmWmnTYaJIQAYF8vkik kVbQT0V0Gi2ZLbKIsBVfaoZJYRpYr41h4whRPg/iNg0swzNE/nmLIdcYYFZ9ixr3heC+ uHGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7pzik94DCRnikniychtCYn/if7UtyQkTWFCyd0BXZAs=; b=uLIq58/SAWhtSrujkfuYfCiRFH91LnxghhFJoYbMb62EjoCfIZupYxYkxTkJz7IuYr fteJsLZFMnuHMs3fOLgb8nsy5r0TUtSp5DQygFO0C/1hg9VjUepOI1tOpJ+xtemCJCo5 btcTjeHOJku91MRCmMLqOyn6cRCJkkW2y4S2v0TofCOG/dvbBqE0A6fReU2KV6gc4M1y ENk/BOiyYgA85EyzkSmytoiW3+3J2GD+O7/ajfqOHWfOf4iRdiGLYpwlRzi/ujk7Qvrq cR/OJ+QVctlV+yoTyKwkyS0B/8stzLoRfhQzAODaT6WKDfyifV0grpqboXi4cv73xlmn lZvw== X-Gm-Message-State: ANoB5pna2IYy4EyqTCfCaNpgpsZVNQKVy4meblBf9nzHok7/VKnGu2jz BR0IAsQ84uHscbu0q/XQ2IsSuw== X-Google-Smtp-Source: AA0mqf7D6o5HZCbdZtrrkeiqgEkjfSmeglDG8CxGKl4IAXFIfOgqAXoQLydm+9jhl4i4m7nwJHIssA== X-Received: by 2002:a05:600c:1da2:b0:3cf:147d:ad9a with SMTP id p34-20020a05600c1da200b003cf147dad9amr48581382wms.33.1670269171966; Mon, 05 Dec 2022 11:39:31 -0800 (PST) Received: from [192.168.10.46] (146725694.box.freepro.com. [130.180.211.218]) by smtp.googlemail.com with ESMTPSA id v14-20020a05600c444e00b003a1980d55c4sm23867622wmn.47.2022.12.05.11.39.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Dec 2022 11:39:31 -0800 (PST) Message-ID: Date: Mon, 5 Dec 2022 20:39:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v7 4/4] thermal: mediatek: add another get_temp ops for thermal sensors Content-Language: en-US To: Amjad Ouled-Ameur , "Rafael J. Wysocki" , Amit Kucheria , Rob Herring , Krzysztof Kozlowski , Zhang Rui Cc: AngeloGioacchino Del Regno , Fabien Parent , Matthias Brugger , Markus Schneider-Pargmann , linux-pm@vger.kernel.org, Rob Herring , Michael Kao , linux-kernel@vger.kernel.org, Hsin-Yi Wang , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org References: <20221018-up-i350-thermal-bringup-v7-0-ebf08ff2eddb@baylibre.com> <20221018-up-i350-thermal-bringup-v7-4-ebf08ff2eddb@baylibre.com> <4121bb6b-30db-7a23-f4c8-40afdda7a0b5@linaro.org> From: Daniel Lezcano In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Amjad, On 05/12/2022 11:41, Amjad Ouled-Ameur wrote: [ ... ] >>> @@ -1161,11 +1197,24 @@ static int mtk_thermal_probe(struct platform_device *pdev) >>> >>> platform_set_drvdata(pdev, mt); >>> >>> - tzdev = devm_thermal_of_zone_register(&pdev->dev, 0, mt, >>> - &mtk_thermal_ops); >>> - if (IS_ERR(tzdev)) { >>> - ret = PTR_ERR(tzdev); >>> - goto err_disable_clk_peri_therm; >>> + for (i = 0; i < mt->conf->num_sensors + 1; i++) { >>> + tz = devm_kmalloc(&pdev->dev, sizeof(*tz), GFP_KERNEL); >>> + if (!tz) >>> + return -ENOMEM; >>> + >>> + tz->mt = mt; >>> + tz->id = i; >>> + >>> + tzdev = devm_thermal_of_zone_register(&pdev->dev, i, tz, (i == 0) ? >>> + &mtk_thermal_ops : >>> + &mtk_thermal_sensor_ops); >> >> Here you use again the aggregation > I addressed this concern in V6, could you please take a look and let me > know what you think [0]. > > [0]: https://lore.kernel.org/all/5eb0cdc2-e9f9-dd42-bf80-b7dcd8bcc196@baylibre.com/ May I misunderstanding but AFAICS, this patch is setting the mtk_thermal_ops if the sensor id is zero. The get_temp is computing the max temperature in this ops which is what we don't want to do. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6028AC4332F for ; Mon, 5 Dec 2022 19:40:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3A5W2e/AyoeeskuSlP6CJETGM/+RuQbloxxxZQniU6A=; b=q0V00QGxnB+aHM Uhaqnw4TLlavTZZQkWVKbHI8C6RorrBbAdVkpDRP4dPFy2E4gxK0kpb0FvnaN9K37iZgWeme/Tjo0 LtixTQXyLifpBuOWoqBxjPe4MKB514fdgD29XAMOrpbjacpjgnbTGhmBee1ft89nRvqF+2dbLzJZq jBhHEveETU2YZNDU6TvysdBqdqJWmTgilkESGhoQd2953hEwxuFy+/BnIZZs+Z89rRc8SSgV3swTs StCrMY5Kd6+3qwNds55ka0Y8/HFGbKYNJqn6bpA8UofBh11cd6nx8DepF6iI6NG6tVoZ5ilnf+ZZO jT1+HOnwSg4TRD92KSOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2HJT-009TL5-6h; Mon, 05 Dec 2022 19:39:39 +0000 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2HJP-009T8D-1x for linux-arm-kernel@lists.infradead.org; Mon, 05 Dec 2022 19:39:36 +0000 Received: by mail-wm1-x336.google.com with SMTP id ay27-20020a05600c1e1b00b003d070f4060bso10981376wmb.2 for ; Mon, 05 Dec 2022 11:39:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7pzik94DCRnikniychtCYn/if7UtyQkTWFCyd0BXZAs=; b=mPhxALAdZmhXA3LNUW3pO/6N9g17MLwyztZmXWZVb6a+DOYDAztdnk9+7GRr2lj+ON g3Y0gaqlIYyK/dkcOudswwzJYkV4QDFemDAKFOZfsxvEDrRuEjyHENJguwDr9rneRstQ Ys/AJ4BPPEWzUWUgGjyHCjTxK4WjajfsVRjLXweIKCPHc4b78j6VizaBs97dSVp/C2Wr DutF4W6xrJ9/AQ15NTZHpvCKMvVTx0MJokJnFrUyyrCJn29dWhmWmnTYaJIQAYF8vkik kVbQT0V0Gi2ZLbKIsBVfaoZJYRpYr41h4whRPg/iNg0swzNE/nmLIdcYYFZ9ixr3heC+ uHGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7pzik94DCRnikniychtCYn/if7UtyQkTWFCyd0BXZAs=; b=bQI+AtBYl3yHwCcAImvBU8fLCBHmQyBc5uK0VbC1T2jAnTp1FCeGW9CobI+wb23NLY GUE4NWq4iVdI8KOnEFbZYo6MTwuvqCB8MYABqeex/zofocSgkyhCIyd/hPKGnmd6zHQT 9+J3BzdtYPehLYNxUmOowp0MiTBtz9Y53jnE3If/ad8Vwaxx7vaHUyYTbdh6sKuoWaIF gisyDdH4OfRd9QAJUxYJsR5GZWGmZYhGmErZ4KFxcv7AOyWO8ufbs5hpUmYuMkWY8YjK 8USBlWH0zDLjS0pi0AcbRf4YeeooJ0nrHUYL5JBjd2XwnOfQPfIR5Rz+AeAowhrAz4k+ L8Sg== X-Gm-Message-State: ANoB5plnSEZ7+8Y5YJf4mbv1zkfAlQhZRqd0kRnkKF90wAzSdUeOZuuG 75CoWCrJXCihy951H0jX7PohEQ== X-Google-Smtp-Source: AA0mqf7D6o5HZCbdZtrrkeiqgEkjfSmeglDG8CxGKl4IAXFIfOgqAXoQLydm+9jhl4i4m7nwJHIssA== X-Received: by 2002:a05:600c:1da2:b0:3cf:147d:ad9a with SMTP id p34-20020a05600c1da200b003cf147dad9amr48581382wms.33.1670269171966; Mon, 05 Dec 2022 11:39:31 -0800 (PST) Received: from [192.168.10.46] (146725694.box.freepro.com. [130.180.211.218]) by smtp.googlemail.com with ESMTPSA id v14-20020a05600c444e00b003a1980d55c4sm23867622wmn.47.2022.12.05.11.39.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Dec 2022 11:39:31 -0800 (PST) Message-ID: Date: Mon, 5 Dec 2022 20:39:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v7 4/4] thermal: mediatek: add another get_temp ops for thermal sensors Content-Language: en-US To: Amjad Ouled-Ameur , "Rafael J. Wysocki" , Amit Kucheria , Rob Herring , Krzysztof Kozlowski , Zhang Rui Cc: AngeloGioacchino Del Regno , Fabien Parent , Matthias Brugger , Markus Schneider-Pargmann , linux-pm@vger.kernel.org, Rob Herring , Michael Kao , linux-kernel@vger.kernel.org, Hsin-Yi Wang , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org References: <20221018-up-i350-thermal-bringup-v7-0-ebf08ff2eddb@baylibre.com> <20221018-up-i350-thermal-bringup-v7-4-ebf08ff2eddb@baylibre.com> <4121bb6b-30db-7a23-f4c8-40afdda7a0b5@linaro.org> From: Daniel Lezcano In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221205_113935_222332_2B34CE1E X-CRM114-Status: GOOD ( 15.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CkhpIEFtamFkLAoKCk9uIDA1LzEyLzIwMjIgMTE6NDEsIEFtamFkIE91bGVkLUFtZXVyIHdyb3Rl OgoKWyAuLi4gXQoKPj4+IEBAIC0xMTYxLDExICsxMTk3LDI0IEBAIHN0YXRpYyBpbnQgbXRrX3Ro ZXJtYWxfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPj4+ICAgIAo+Pj4gICAg CXBsYXRmb3JtX3NldF9kcnZkYXRhKHBkZXYsIG10KTsKPj4+ICAgIAo+Pj4gLQl0emRldiA9IGRl dm1fdGhlcm1hbF9vZl96b25lX3JlZ2lzdGVyKCZwZGV2LT5kZXYsIDAsIG10LAo+Pj4gLQkJCQkJ ICAgICAgJm10a190aGVybWFsX29wcyk7Cj4+PiAtCWlmIChJU19FUlIodHpkZXYpKSB7Cj4+PiAt CQlyZXQgPSBQVFJfRVJSKHR6ZGV2KTsKPj4+IC0JCWdvdG8gZXJyX2Rpc2FibGVfY2xrX3Blcmlf dGhlcm07Cj4+PiArCWZvciAoaSA9IDA7IGkgPCBtdC0+Y29uZi0+bnVtX3NlbnNvcnMgKyAxOyBp KyspIHsKPj4+ICsJCXR6ID0gZGV2bV9rbWFsbG9jKCZwZGV2LT5kZXYsIHNpemVvZigqdHopLCBH RlBfS0VSTkVMKTsKPj4+ICsJCWlmICghdHopCj4+PiArCQkJcmV0dXJuIC1FTk9NRU07Cj4+PiAr Cj4+PiArCQl0ei0+bXQgPSBtdDsKPj4+ICsJCXR6LT5pZCA9IGk7Cj4+PiArCj4+PiArCQl0emRl diA9IGRldm1fdGhlcm1hbF9vZl96b25lX3JlZ2lzdGVyKCZwZGV2LT5kZXYsIGksIHR6LCAoaSA9 PSAwKSA/Cj4+PiArCQkJCQkJCSAgICAgJm10a190aGVybWFsX29wcyA6Cj4+PiArCQkJCQkJCSAg ICAgJm10a190aGVybWFsX3NlbnNvcl9vcHMpOwo+Pgo+PiBIZXJlIHlvdSB1c2UgYWdhaW4gdGhl IGFnZ3JlZ2F0aW9uCj4gSSBhZGRyZXNzZWQgdGhpcyBjb25jZXJuIGluIFY2LCBjb3VsZCB5b3Ug cGxlYXNlIHRha2UgYSBsb29rIGFuZCBsZXQgbWUKPiBrbm93IHdoYXQgeW91IHRoaW5rIFswXS4K PiAKPiBbMF06IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2FsbC81ZWIwY2RjMi1lOWY5LWRkNDIt YmY4MC1iN2RjZDhiY2MxOTZAYmF5bGlicmUuY29tLwoKTWF5IEkgbWlzdW5kZXJzdGFuZGluZyBi dXQgQUZBSUNTLCB0aGlzIHBhdGNoIGlzIHNldHRpbmcgdGhlIAptdGtfdGhlcm1hbF9vcHMgaWYg dGhlIHNlbnNvciBpZCBpcyB6ZXJvLiBUaGUgZ2V0X3RlbXAgaXMgY29tcHV0aW5nIHRoZSAKbWF4 IHRlbXBlcmF0dXJlIGluIHRoaXMgb3BzIHdoaWNoIGlzIHdoYXQgd2UgZG9uJ3Qgd2FudCB0byBk by4KCgotLSAKPGh0dHA6Ly93d3cubGluYXJvLm9yZy8+IExpbmFyby5vcmcg4pSCIE9wZW4gc291 cmNlIHNvZnR3YXJlIGZvciBBUk0gU29DcwoKRm9sbG93IExpbmFybzogIDxodHRwOi8vd3d3LmZh Y2Vib29rLmNvbS9wYWdlcy9MaW5hcm8+IEZhY2Vib29rIHwKPGh0dHA6Ly90d2l0dGVyLmNvbS8j IS9saW5hcm9vcmc+IFR3aXR0ZXIgfAo8aHR0cDovL3d3dy5saW5hcm8ub3JnL2xpbmFyby1ibG9n Lz4gQmxvZwoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK