From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH 1/2] test/mempool_perf: Free mempool on exit
Date: Wed, 5 Apr 2017 15:27:27 +0530
Message-ID: <adff3d3a-a6bc-ea1b-ae9c-266a772fa21a@nxp.com>
References: <1491382264-23489-1-git-send-email-santosh.shukla@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <olivier.matz@6wind.com>, <dev@dpdk.org>, <hemant.agrawal@nxp.com>,
 <stable@dpdk.org>
To: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <1491382264-23489-1-git-send-email-santosh.shukla@caviumnetworks.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hello Santosh,

On Wednesday 05 April 2017 02:21 PM, Santosh Shukla wrote:
> Mempool_perf test not freeing pool memory.
>
> Cc: stable@dpdk.org
> Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> ---
>  test/test/test_mempool_perf.c |   31 +++++++++++++++++++------------
>  1 file changed, 19 insertions(+), 12 deletions(-)
>
> diff --git a/test/test/test_mempool_perf.c b/test/test/test_mempool_perf.c
> index ebf1721..3c45971 100644
> --- a/test/test/test_mempool_perf.c
> +++ b/test/test/test_mempool_perf.c
> @@ -312,6 +312,8 @@ struct mempool_test_stats {
>  static int
>  test_mempool_perf(void)
>  {
> +	int ret = -1;
> +
>  	rte_atomic32_init(&synchro);
>
>  	/* create a mempool (without cache) */
> @@ -322,7 +324,7 @@ struct mempool_test_stats {

Can you check why the patch is showing "struct mempool_test_stats" as
the context?
I tried creating this patch and it shows "test_mempool_perf(void)" as
context.

off the topic, does it matter to maintainers if context is not correct?

>  						my_obj_init, NULL,
>  						SOCKET_ID_ANY, 0);
>  	if (mp_nocache == NULL)
> -		return -1;
> +		goto err;
>
>  	/* create a mempool (with cache) */
>  	if (mp_cache == NULL)

[...]

> +err:
> +	rte_mempool_free(mp_cache);
> +	rte_mempool_free(mp_nocache);
> +	return ret;
>  }
>
>  REGISTER_TEST_COMMAND(mempool_perf_autotest, test_mempool_perf);
>

Other than that:

Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>