From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH v8 15/18] ARM: STi: DT: STiH407: Add uniperif reader dt nodes References: <1472223413-7254-1-git-send-email-peter.griffin@linaro.org> <1472223413-7254-16-git-send-email-peter.griffin@linaro.org> <20160830100148.GO1661@dell> <20160830142112.GA22514@griffinp-ThinkPad-X1-Carbon-2nd> <20160831112819.GJ27357@dell> From: Arnaud Pouliquen Message-ID: Date: Mon, 5 Sep 2016 14:20:06 +0200 MIME-Version: 1.0 In-Reply-To: <20160831112819.GJ27357@dell> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Lee Jones , Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, vinod.koul@intel.com, patrice.chotard@st.com, dan.j.williams@intel.com, airlied@linux.ie, kraxel@redhat.com, ohad@wizery.com, bjorn.andersson@linaro.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-remoteproc@vger.kernel.org List-ID: Hello ptere, Lee, Thanks for your remarks, Regards Arnaud On 08/31/2016 01:28 PM, Lee Jones wrote: > On Tue, 30 Aug 2016, Peter Griffin wrote: >> Thanks for reviewing and your very valuable feedback. >> On Tue, 30 Aug 2016, Lee Jones wrote: >>> On Fri, 26 Aug 2016, Peter Griffin wrote: >>> >>>> This patch adds the DT node for the uniperif reader >>>> IP block found on STiH407 family silicon. >>>> >>>> Signed-off-by: Arnaud Pouliquen >>>> Signed-off-by: Peter Griffin >>>> --- >>>> arch/arm/boot/dts/stih407-family.dtsi | 26 ++++++++++++++++++++++++++ >>>> 1 file changed, 26 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi >>>> index d263c96..bdddf2c 100644 >>>> --- a/arch/arm/boot/dts/stih407-family.dtsi >>>> +++ b/arch/arm/boot/dts/stih407-family.dtsi >>>> @@ -956,5 +956,31 @@ >>>> st,version = <5>; >>>> st,mode = "SPDIF"; >>>> }; >>>> + >>>> + sti_uni_reader0: sti-uni-reader@0 { >>>> + compatible = "st,sti-uni-reader"; >>>> + status = "disabled"; >>> >>> I find it's normally nicer to place the status of the node at the >>> bottom, separated by a '\n'. >> >> Ok I'll add a superflous '\n' in the next version. > > Everyone loves a smart arse! > > In this case I believe the '\n' to be a functional separator and not > superfluous at all. > >>>> + dai-name = "Uni Reader #0 (PCM IN)"; >>> >>> Oooo, not seen something like this before. >>> >>> If it does not already have one, it would require a DT Ack. >> >> No idea, the driver got merged 1 year ago. This field could be suppressed and handled in source code, using st,uniperiph-id to retreive it. >> >> Arnaud did you get a DT ack when you merged this driver & binding? i if i remember well, i had sent to Alsa mailing list only, I missed this obvious... >>> >>>> + st,version = <3>; >>> >>> This will likely need a DT Ack too. We usually encode this sort of >>> information in the compatible string. yes, better to use compatibility >> >> See 05c1b4480e86a871b18030d6f3d532dc0ecdf38c > > Well Rob's the boss. We certainly never used to take 'device ID' or > 'version' attributes. I guess something must have changed. I will try to provide patches for code and bindings rework this week. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755419AbcIEMVi (ORCPT ); Mon, 5 Sep 2016 08:21:38 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:63167 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755127AbcIEMVf (ORCPT ); Mon, 5 Sep 2016 08:21:35 -0400 Subject: Re: [PATCH v8 15/18] ARM: STi: DT: STiH407: Add uniperif reader dt nodes To: Lee Jones , Peter Griffin References: <1472223413-7254-1-git-send-email-peter.griffin@linaro.org> <1472223413-7254-16-git-send-email-peter.griffin@linaro.org> <20160830100148.GO1661@dell> <20160830142112.GA22514@griffinp-ThinkPad-X1-Carbon-2nd> <20160831112819.GJ27357@dell> CC: , , , , , , , , , , , , , , From: Arnaud Pouliquen X-Enigmail-Draft-Status: N1110 Message-ID: Date: Mon, 5 Sep 2016 14:20:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160831112819.GJ27357@dell> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.201.23.162] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-05_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello ptere, Lee, Thanks for your remarks, Regards Arnaud On 08/31/2016 01:28 PM, Lee Jones wrote: > On Tue, 30 Aug 2016, Peter Griffin wrote: >> Thanks for reviewing and your very valuable feedback. >> On Tue, 30 Aug 2016, Lee Jones wrote: >>> On Fri, 26 Aug 2016, Peter Griffin wrote: >>> >>>> This patch adds the DT node for the uniperif reader >>>> IP block found on STiH407 family silicon. >>>> >>>> Signed-off-by: Arnaud Pouliquen >>>> Signed-off-by: Peter Griffin >>>> --- >>>> arch/arm/boot/dts/stih407-family.dtsi | 26 ++++++++++++++++++++++++++ >>>> 1 file changed, 26 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi >>>> index d263c96..bdddf2c 100644 >>>> --- a/arch/arm/boot/dts/stih407-family.dtsi >>>> +++ b/arch/arm/boot/dts/stih407-family.dtsi >>>> @@ -956,5 +956,31 @@ >>>> st,version = <5>; >>>> st,mode = "SPDIF"; >>>> }; >>>> + >>>> + sti_uni_reader0: sti-uni-reader@0 { >>>> + compatible = "st,sti-uni-reader"; >>>> + status = "disabled"; >>> >>> I find it's normally nicer to place the status of the node at the >>> bottom, separated by a '\n'. >> >> Ok I'll add a superflous '\n' in the next version. > > Everyone loves a smart arse! > > In this case I believe the '\n' to be a functional separator and not > superfluous at all. > >>>> + dai-name = "Uni Reader #0 (PCM IN)"; >>> >>> Oooo, not seen something like this before. >>> >>> If it does not already have one, it would require a DT Ack. >> >> No idea, the driver got merged 1 year ago. This field could be suppressed and handled in source code, using st,uniperiph-id to retreive it. >> >> Arnaud did you get a DT ack when you merged this driver & binding? i if i remember well, i had sent to Alsa mailing list only, I missed this obvious... >>> >>>> + st,version = <3>; >>> >>> This will likely need a DT Ack too. We usually encode this sort of >>> information in the compatible string. yes, better to use compatibility >> >> See 05c1b4480e86a871b18030d6f3d532dc0ecdf38c > > Well Rob's the boss. We certainly never used to take 'device ID' or > 'version' attributes. I guess something must have changed. I will try to provide patches for code and bindings rework this week. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnaud Pouliquen Subject: Re: [PATCH v8 15/18] ARM: STi: DT: STiH407: Add uniperif reader dt nodes Date: Mon, 5 Sep 2016 14:20:06 +0200 Message-ID: References: <1472223413-7254-1-git-send-email-peter.griffin@linaro.org> <1472223413-7254-16-git-send-email-peter.griffin@linaro.org> <20160830100148.GO1661@dell> <20160830142112.GA22514@griffinp-ThinkPad-X1-Carbon-2nd> <20160831112819.GJ27357@dell> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160831112819.GJ27357@dell> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Lee Jones , Peter Griffin Cc: ohad@wizery.com, devicetree@vger.kernel.org, kernel@stlinux.com, vinod.koul@intel.com, linux-remoteproc@vger.kernel.org, patrice.chotard@st.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, airlied@linux.ie, kraxel@redhat.com, dmaengine@vger.kernel.org, dan.j.williams@intel.com, bjorn.andersson@linaro.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org Hello ptere, Lee, Thanks for your remarks, Regards Arnaud On 08/31/2016 01:28 PM, Lee Jones wrote: > On Tue, 30 Aug 2016, Peter Griffin wrote: >> Thanks for reviewing and your very valuable feedback. >> On Tue, 30 Aug 2016, Lee Jones wrote: >>> On Fri, 26 Aug 2016, Peter Griffin wrote: >>> >>>> This patch adds the DT node for the uniperif reader >>>> IP block found on STiH407 family silicon. >>>> >>>> Signed-off-by: Arnaud Pouliquen >>>> Signed-off-by: Peter Griffin >>>> --- >>>> arch/arm/boot/dts/stih407-family.dtsi | 26 ++++++++++++++++++++++++++ >>>> 1 file changed, 26 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi >>>> index d263c96..bdddf2c 100644 >>>> --- a/arch/arm/boot/dts/stih407-family.dtsi >>>> +++ b/arch/arm/boot/dts/stih407-family.dtsi >>>> @@ -956,5 +956,31 @@ >>>> st,version = <5>; >>>> st,mode = "SPDIF"; >>>> }; >>>> + >>>> + sti_uni_reader0: sti-uni-reader@0 { >>>> + compatible = "st,sti-uni-reader"; >>>> + status = "disabled"; >>> >>> I find it's normally nicer to place the status of the node at the >>> bottom, separated by a '\n'. >> >> Ok I'll add a superflous '\n' in the next version. > > Everyone loves a smart arse! > > In this case I believe the '\n' to be a functional separator and not > superfluous at all. > >>>> + dai-name = "Uni Reader #0 (PCM IN)"; >>> >>> Oooo, not seen something like this before. >>> >>> If it does not already have one, it would require a DT Ack. >> >> No idea, the driver got merged 1 year ago. This field could be suppressed and handled in source code, using st,uniperiph-id to retreive it. >> >> Arnaud did you get a DT ack when you merged this driver & binding? i if i remember well, i had sent to Alsa mailing list only, I missed this obvious... >>> >>>> + st,version = <3>; >>> >>> This will likely need a DT Ack too. We usually encode this sort of >>> information in the compatible string. yes, better to use compatibility >> >> See 05c1b4480e86a871b18030d6f3d532dc0ecdf38c > > Well Rob's the boss. We certainly never used to take 'device ID' or > 'version' attributes. I guess something must have changed. I will try to provide patches for code and bindings rework this week. From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnaud.pouliquen@st.com (Arnaud Pouliquen) Date: Mon, 5 Sep 2016 14:20:06 +0200 Subject: [PATCH v8 15/18] ARM: STi: DT: STiH407: Add uniperif reader dt nodes In-Reply-To: <20160831112819.GJ27357@dell> References: <1472223413-7254-1-git-send-email-peter.griffin@linaro.org> <1472223413-7254-16-git-send-email-peter.griffin@linaro.org> <20160830100148.GO1661@dell> <20160830142112.GA22514@griffinp-ThinkPad-X1-Carbon-2nd> <20160831112819.GJ27357@dell> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello ptere, Lee, Thanks for your remarks, Regards Arnaud On 08/31/2016 01:28 PM, Lee Jones wrote: > On Tue, 30 Aug 2016, Peter Griffin wrote: >> Thanks for reviewing and your very valuable feedback. >> On Tue, 30 Aug 2016, Lee Jones wrote: >>> On Fri, 26 Aug 2016, Peter Griffin wrote: >>> >>>> This patch adds the DT node for the uniperif reader >>>> IP block found on STiH407 family silicon. >>>> >>>> Signed-off-by: Arnaud Pouliquen >>>> Signed-off-by: Peter Griffin >>>> --- >>>> arch/arm/boot/dts/stih407-family.dtsi | 26 ++++++++++++++++++++++++++ >>>> 1 file changed, 26 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi >>>> index d263c96..bdddf2c 100644 >>>> --- a/arch/arm/boot/dts/stih407-family.dtsi >>>> +++ b/arch/arm/boot/dts/stih407-family.dtsi >>>> @@ -956,5 +956,31 @@ >>>> st,version = <5>; >>>> st,mode = "SPDIF"; >>>> }; >>>> + >>>> + sti_uni_reader0: sti-uni-reader at 0 { >>>> + compatible = "st,sti-uni-reader"; >>>> + status = "disabled"; >>> >>> I find it's normally nicer to place the status of the node at the >>> bottom, separated by a '\n'. >> >> Ok I'll add a superflous '\n' in the next version. > > Everyone loves a smart arse! > > In this case I believe the '\n' to be a functional separator and not > superfluous at all. > >>>> + dai-name = "Uni Reader #0 (PCM IN)"; >>> >>> Oooo, not seen something like this before. >>> >>> If it does not already have one, it would require a DT Ack. >> >> No idea, the driver got merged 1 year ago. This field could be suppressed and handled in source code, using st,uniperiph-id to retreive it. >> >> Arnaud did you get a DT ack when you merged this driver & binding? i if i remember well, i had sent to Alsa mailing list only, I missed this obvious... >>> >>>> + st,version = <3>; >>> >>> This will likely need a DT Ack too. We usually encode this sort of >>> information in the compatible string. yes, better to use compatibility >> >> See 05c1b4480e86a871b18030d6f3d532dc0ecdf38c > > Well Rob's the boss. We certainly never used to take 'device ID' or > 'version' attributes. I guess something must have changed. I will try to provide patches for code and bindings rework this week.