From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:42966 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750881AbeCHTmY (ORCPT ); Thu, 8 Mar 2018 14:42:24 -0500 Subject: Re: [pull request][for-next 00/11] Mellanox, mlx5 IPSec updates 2018-02-28-2 (Part 2) To: Randy Dunlap , David Miller , saeedm@mellanox.com Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, leonro@mellanox.com, jgg@mellanox.com, aviadye@mellanox.com, matanb@mellanox.com, borisp@mellanox.com References: <20180308012614.26451-1-saeedm@mellanox.com> <20180308.130402.1324862790728961653.davem@davemloft.net> From: Doug Ledford Message-ID: Date: Thu, 8 Mar 2018 14:42:19 -0500 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iqFAnJ6BlpOeastYezmoZCd1M1PHL76PB" Sender: netdev-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --iqFAnJ6BlpOeastYezmoZCd1M1PHL76PB Content-Type: multipart/mixed; boundary="QWgCVDMc4LYlPySx7dMeH39kMiSLQS6x7"; protected-headers="v1" From: Doug Ledford To: Randy Dunlap , David Miller , saeedm@mellanox.com Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, leonro@mellanox.com, jgg@mellanox.com, aviadye@mellanox.com, matanb@mellanox.com, borisp@mellanox.com Message-ID: Subject: Re: [pull request][for-next 00/11] Mellanox, mlx5 IPSec updates 2018-02-28-2 (Part 2) References: <20180308012614.26451-1-saeedm@mellanox.com> <20180308.130402.1324862790728961653.davem@davemloft.net> In-Reply-To: --QWgCVDMc4LYlPySx7dMeH39kMiSLQS6x7 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 3/8/2018 2:38 PM, Randy Dunlap wrote: > On 03/08/2018 11:14 AM, Doug Ledford wrote: >> On 3/8/2018 1:04 PM, David Miller wrote: >>> From: Saeed Mahameed >>> Date: Wed, 7 Mar 2018 17:26:03 -0800 >>> >>>> Hi Dave and Doug, >>>> >>>> This series includes shared code updates (IPSec part2) for mlx5 core= =20 >>>> driver for both netdev and rdma subsystems. This series should be p= ulled >>>> to both trees so we can continue netdev and rdma specific submission= s >>>> separately. >>> >>> Doug, please give this series a quick review. >>> >>> Thank you. >>> >> >> I'm good with it. Pull it as you see fit. >> >=20 > I got this build error in today's linux-next (20180308): >=20 > ../drivers/net/ethernet/mellanox/mlx5/core/fs_core.c: In function 'mlx5= _init_fs': > ../drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:2652:2: error: imp= licit declaration of function 'mlx5_accel_ipsec_device_caps' [-Werror=3Di= mplicit-function-declaration] > if (mlx5_accel_ipsec_device_caps(steering->dev) & > ^ > ../drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:2653:6: error: 'ML= X5_ACCEL_IPSEC_DEVICE' undeclared (first use in this function) > MLX5_ACCEL_IPSEC_DEVICE) { > ^ > ../drivers/net/ethernet >=20 >=20 > Is this perhaps fixed already? > Do you need the randconfig file? >=20 > thanks, >=20 That's fixed by patch 1 of this series. --QWgCVDMc4LYlPySx7dMeH39kMiSLQS6x7-- --iqFAnJ6BlpOeastYezmoZCd1M1PHL76PB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIzBAEBCAAdFiEErmsb2hIrI7QmWxJ0uCajMw5XL90FAlqhkhsACgkQuCajMw5X L93sABAAwZau6AX+sUir/v+i/nb+1DCwAHb3RlPqGJmhJQxt5CDTSU33UTem5mmU Qf1iuRvLatdsnPWlv2WrH5G6AIn2t5PPbzqnSYL/YzI6y1E1TFurQPLImasQ6tn4 oTqJ/F3cj3fJdPyHxac6fPHzMCIrp4O2+wUIbL5v6KjEUdRT2rpk+rfJ9pa+sK6m b5uRd8tEF9pQkDyyrVKjSW6zePQXXB1ALT36869N8doYSkjTGK9JbqMOpeBAt1fl abOsLXXYR0TxeraXhx1akZewUDWO5XfHB/f2Zm5OrVLmVZJysi0gIhpnKsTWIq+7 T8BaDcUTx5vDs+pZUtF266tPa26bmevu6H6mhJGOKN8bNkKDLbfRxrmOGmh1sFyk rvbKfLo1d8wRly/OoWEmkKYsn4utqtbMCrf3nZHXnA9QpPcW8TIUPRPAPMtVMqcB BfgCaVuuUcbA9kYkjviwMnO3t/O+v3qR0UGQ6WhJoq+W3d0wrF9sn3uA1Z3QUyoP fGHj3rV0LpeDDjF+O/SuUYOw3W5j2mEFsGHA3MkF5v0Q6BaLsNzHQhGUsz2JSqXV xCd2swdU4uiqe0WVeKGIY/sSM80HlNkEfwnEHTlckG2rDfv9jRYGu6WmAv5jvd97 Q73rny67OgCkdrdX5c3cSQafWWBDINQZbtpV/m1A2hzfSn+78K8= =QI62 -----END PGP SIGNATURE----- --iqFAnJ6BlpOeastYezmoZCd1M1PHL76PB--