From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] vdev: free reply.msgs memory for secondary
 process
Date: Thu, 27 Sep 2018 14:28:12 +0100
Message-ID: <ae10c7df-bfe2-9525-f6b7-19a4a81b3789@intel.com>
References: <20180921162557.48249-1-paul.e.luse@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Anatoly Burakov <anatoly.burakov@intel.com>
To: Paul Luse <paul.e.luse@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 43C2B1B4C6
 for <dev@dpdk.org>; Thu, 27 Sep 2018 15:33:25 +0200 (CEST)
In-Reply-To: <20180921162557.48249-1-paul.e.luse@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/21/2018 5:25 PM, Paul Luse wrote:
> From: paul luse <paul.e.luse@intel.com>
> 
> This patch fixes an issue caught with ASAN where a vdev_scan()
> to a secondary bus was failing to free some memory.
> 
> Signed-off-by: paul luse <paul.e.luse@intel.com>

(carry from Anatoly's ack from other thread)
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>


@Anatoly, what do you think about:
 diff --git a/lib/librte_eal/common/include/rte_eal.h
b/lib/librte_eal/common/include/rte_eal.h
 index e114dcbdc..e1a554f5a 100644
 --- a/lib/librte_eal/common/include/rte_eal.h
 +++ b/lib/librte_eal/common/include/rte_eal.h
 @@ -309,7 +309,7 @@ rte_mp_sendmsg(struct rte_mp_msg *msg);
   * This function sends a request message to the peer process, and will
   * block until receiving reply message from the peer process.
   *
 - * @note The caller is responsible to free reply->replies.
 + * @note The caller is responsible to free reply->msgs.
   *
   * @param req
   *   The req argument contains the customized request message.