[PATCH] gtk-icon-cache.bbclass: update RDEPENDS

[PATCH] gtk-icon-cache.bbclass: update RDEPENDS

[Changqing Li]

From: Changqing Li <changqing.li@windriver.com>

fix error:
+ /usr/lib/gdk-pixbuf-2.0/gdk-pixbuf-query-loaders --update-cache
/var/tmp/rpm-tmp.mdYxY6: line 12: /usr/lib/gdk-pixbuf-2.0/gdk-pixbuf-query-loaders: No such file or directory
%post(adwaita-icon-theme-3.36.1-r0.0.noarch): waitpid(2961) rc 2961 status 7f00
warning: %post(adwaita-icon-theme-3.36.1-r0.0.noarch) scriptlet failed, exit status 127

when install adwaita-icon-theme, which inherit gtk-icon-cache
on target, above error reported,  fix by add needeed packages
in RDEPENDS

Signed-off-by: Changqing Li <changqing.li@windriver.com>
---
 meta/classes/gtk-icon-cache.bbclass | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/classes/gtk-icon-cache.bbclass b/meta/classes/gtk-icon-cache.bbclass
index 91cb4ad409..7f218ce7ae 100644
--- a/meta/classes/gtk-icon-cache.bbclass
+++ b/meta/classes/gtk-icon-cache.bbclass
@@ -4,6 +4,8 @@ DEPENDS +=" ${@['hicolor-icon-theme', '']['${BPN}' == 'hicolor-icon-theme']} gtk
 
 PACKAGE_WRITE_DEPS += "gtk+3-native gdk-pixbuf-native"
 
+RDEPENDS_${PN} += "gdk-pixbuf gtk+3"
+
 gtk_icon_cache_postinst() {
 if [ "x$D" != "x" ]; then
 	$INTERCEPT_DIR/postinst_intercept update_gtk_icon_cache ${PKG} \
-- 
2.17.1

Re: [OE-core] [PATCH] gtk-icon-cache.bbclass: update RDEPENDS

[Richard Purdie]

On Tue, 2020-06-30 at 17:49 +0800, Changqing Li wrote:
> From: Changqing Li <changqing.li@windriver.com>
> 
> fix error:
> + /usr/lib/gdk-pixbuf-2.0/gdk-pixbuf-query-loaders --update-cache
> /var/tmp/rpm-tmp.mdYxY6: line 12: /usr/lib/gdk-pixbuf-2.0/gdk-pixbuf-
> query-loaders: No such file or directory
> %post(adwaita-icon-theme-3.36.1-r0.0.noarch): waitpid(2961) rc 2961
> status 7f00
> warning: %post(adwaita-icon-theme-3.36.1-r0.0.noarch) scriptlet
> failed, exit status 127
> 
> when install adwaita-icon-theme, which inherit gtk-icon-cache
> on target, above error reported,  fix by add needeed packages
> in RDEPENDS
> 
> Signed-off-by: Changqing Li <changqing.li@windriver.com>
> ---
>  meta/classes/gtk-icon-cache.bbclass | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta/classes/gtk-icon-cache.bbclass b/meta/classes/gtk-
> icon-cache.bbclass
> index 91cb4ad409..7f218ce7ae 100644
> --- a/meta/classes/gtk-icon-cache.bbclass
> +++ b/meta/classes/gtk-icon-cache.bbclass
> @@ -4,6 +4,8 @@ DEPENDS +=" ${@['hicolor-icon-theme', '']['${BPN}' ==
> 'hicolor-icon-theme']} gtk
>  
>  PACKAGE_WRITE_DEPS += "gtk+3-native gdk-pixbuf-native"
>  
> +RDEPENDS_${PN} += "gdk-pixbuf gtk+3"
> +
>  gtk_icon_cache_postinst() {
>  if [ "x$D" != "x" ]; then
>  	$INTERCEPT_DIR/postinst_intercept update_gtk_icon_cache ${PKG}
> \

This isn't quite right since the postinst may be added to a package
other than ${PN}.

You need to add the RDEPENDS to the code:

        rdepends = ' ' + d.getVar('MLPREFIX', False) + "hicolor-icon-theme"
        d.appendVar('RDEPENDS_%s' % pkg, rdepends)

later in that class.

Cheers,

Richard

Re: [OE-core] [PATCH] gtk-icon-cache.bbclass: update RDEPENDS

[Changqing Li]

On 6/30/20 6:01 PM, Richard Purdie wrote:
> On Tue, 2020-06-30 at 17:49 +0800, Changqing Li wrote:
>> From: Changqing Li <changqing.li@windriver.com>
>>
>> fix error:
>> + /usr/lib/gdk-pixbuf-2.0/gdk-pixbuf-query-loaders --update-cache
>> /var/tmp/rpm-tmp.mdYxY6: line 12: /usr/lib/gdk-pixbuf-2.0/gdk-pixbuf-
>> query-loaders: No such file or directory
>> %post(adwaita-icon-theme-3.36.1-r0.0.noarch): waitpid(2961) rc 2961
>> status 7f00
>> warning: %post(adwaita-icon-theme-3.36.1-r0.0.noarch) scriptlet
>> failed, exit status 127
>>
>> when install adwaita-icon-theme, which inherit gtk-icon-cache
>> on target, above error reported,  fix by add needeed packages
>> in RDEPENDS
>>
>> Signed-off-by: Changqing Li <changqing.li@windriver.com>
>> ---
>>   meta/classes/gtk-icon-cache.bbclass | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/meta/classes/gtk-icon-cache.bbclass b/meta/classes/gtk-
>> icon-cache.bbclass
>> index 91cb4ad409..7f218ce7ae 100644
>> --- a/meta/classes/gtk-icon-cache.bbclass
>> +++ b/meta/classes/gtk-icon-cache.bbclass
>> @@ -4,6 +4,8 @@ DEPENDS +=" ${@['hicolor-icon-theme', '']['${BPN}' ==
>> 'hicolor-icon-theme']} gtk
>>   
>>   PACKAGE_WRITE_DEPS += "gtk+3-native gdk-pixbuf-native"
>>   
>> +RDEPENDS_${PN} += "gdk-pixbuf gtk+3"
>> +
>>   gtk_icon_cache_postinst() {
>>   if [ "x$D" != "x" ]; then
>>   	$INTERCEPT_DIR/postinst_intercept update_gtk_icon_cache ${PKG}
>> \
> This isn't quite right since the postinst may be added to a package
> other than ${PN}.
>
> You need to add the RDEPENDS to the code:
>
>          rdepends = ' ' + d.getVar('MLPREFIX', False) + "hicolor-icon-theme"
>          d.appendVar('RDEPENDS_%s' % pkg, rdepends)
>
> later in that class.
>
> Cheers,
>
> Richard
Thanks, I will correct it.
>

Re: [OE-core] [PATCH] gtk-icon-cache.bbclass: update RDEPENDS

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2985 bytes --]

With this change now in master and dunfell there is signature issue in
allarch adwaita-icon-theme now runtime depending on TUNE_PKGARCH gdk-pixbuf
as shown by sstate-diff-machines.sh/bitbake-diffsigs:

bitbake-diffsigs
tmp-glibc/sstate-diff/1594398219/qemu*/all-webos-linux/adwaita-icon-theme/*do_prepare_recipe_sysroot*
NOTE: Starting bitbake server...
NOTE: Started PRServer with DBfile: cache/prserv.sqlite3, IP: 127.0.0.1,
PORT: 33511, PID: 36423
Hash for dependent task gdk-pixbuf/gdk-pixbuf_2.40.0.bb:do_populate_sysroot
changed from
a72aba8432699c8ce4ca1f71833ef14a89ffde0ea4063e37b9d819fdb1e407f4 to
1ad4e1bd76921b71482657f3b017184e9ade8e2a0b9f43ad64ed2dda83b1520f
Unable to find matching sigdata for
openembedded-core/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.40.0.bb:do_populate_sysroot
with hashes
a72aba8432699c8ce4ca1f71833ef14a89ffde0ea4063e37b9d819fdb1e407f4 or
1ad4e1bd76921b71482657f3b017184e9ade8e2a0b9f43ad64ed2dda83b1520f

On Wed, Jul 1, 2020 at 3:39 AM Changqing Li <changqing.li@windriver.com>
wrote:

>
> On 6/30/20 6:01 PM, Richard Purdie wrote:
> > On Tue, 2020-06-30 at 17:49 +0800, Changqing Li wrote:
> >> From: Changqing Li <changqing.li@windriver.com>
> >>
> >> fix error:
> >> + /usr/lib/gdk-pixbuf-2.0/gdk-pixbuf-query-loaders --update-cache
> >> /var/tmp/rpm-tmp.mdYxY6: line 12: /usr/lib/gdk-pixbuf-2.0/gdk-pixbuf-
> >> query-loaders: No such file or directory
> >> %post(adwaita-icon-theme-3.36.1-r0.0.noarch): waitpid(2961) rc 2961
> >> status 7f00
> >> warning: %post(adwaita-icon-theme-3.36.1-r0.0.noarch) scriptlet
> >> failed, exit status 127
> >>
> >> when install adwaita-icon-theme, which inherit gtk-icon-cache
> >> on target, above error reported,  fix by add needeed packages
> >> in RDEPENDS
> >>
> >> Signed-off-by: Changqing Li <changqing.li@windriver.com>
> >> ---
> >>   meta/classes/gtk-icon-cache.bbclass | 2 ++
> >>   1 file changed, 2 insertions(+)
> >>
> >> diff --git a/meta/classes/gtk-icon-cache.bbclass b/meta/classes/gtk-
> >> icon-cache.bbclass
> >> index 91cb4ad409..7f218ce7ae 100644
> >> --- a/meta/classes/gtk-icon-cache.bbclass
> >> +++ b/meta/classes/gtk-icon-cache.bbclass
> >> @@ -4,6 +4,8 @@ DEPENDS +=" ${@['hicolor-icon-theme', '']['${BPN}' ==
> >> 'hicolor-icon-theme']} gtk
> >>
> >>   PACKAGE_WRITE_DEPS += "gtk+3-native gdk-pixbuf-native"
> >>
> >> +RDEPENDS_${PN} += "gdk-pixbuf gtk+3"
> >> +
> >>   gtk_icon_cache_postinst() {
> >>   if [ "x$D" != "x" ]; then
> >>      $INTERCEPT_DIR/postinst_intercept update_gtk_icon_cache ${PKG}
> >> \
> > This isn't quite right since the postinst may be added to a package
> > other than ${PN}.
> >
> > You need to add the RDEPENDS to the code:
> >
> >          rdepends = ' ' + d.getVar('MLPREFIX', False) +
> "hicolor-icon-theme"
> >          d.appendVar('RDEPENDS_%s' % pkg, rdepends)
> >
> > later in that class.
> >
> > Cheers,
> >
> > Richard
> Thanks, I will correct it.
> >
> 
>

[-- Attachment #2: Type: text/html, Size: 4007 bytes --]

Re: [OE-core] [PATCH] gtk-icon-cache.bbclass: update RDEPENDS

[Changqing Li]

[-- Attachment #1: Type: text/plain, Size: 5633 bytes --]

Hi, Martin

Thanks for tell me the problem.  Maybe I don't understand you 
correctly,  but I don't met your problem, below is what I tried,

if I am wrong, please tell me how I can reproduce your problem, thanks.


Here is what I tried:

bitbake adwaita-icon-themewithout my patch, and then build 
adwaita-icon-theme with my patch, and then run below command:

bitbake-diffsigs 
3.36.1-r0.do_prepare_recipe_sysroot.sigdata.608eb6ea5873c19534fddfeacee59d81fa799ce6c965217ffe76a0141885093a 
3.36.1-r0.do_prepare_recipe_sysroot.sigdata.b10948f26bfd089980c9f9af928e108e9764627201dcfd9db43efc8a455b181b
NOTE: Starting bitbake server...
runtaskdeps changed:
['autoconf/autoconf_2.69.bb:do_populate_sysroot:virtual:native:/poky/meta/recipes-devtools/autoconf/autoconf_2.69.bb 
automake/automake_1.16.2.bb:do_populate_sysroot:virtual:native:/poky/meta/recipes-devtools/automake/automake_1.16.2.bb', 
+gdk-pixbuf/gdk-pixbuf_2.40.0.bb:do_populate_sysroot, 
'gnome/adwaita-icon-theme_3.36.1.bb:do_fetch 
gnu-config/gnu-config_git.bb:do_populate_sysroot:virtual:native:/poky/meta/recipes-devtools/gnu-config/gnu-config_git.bb', 
+gtk+/gtk+3_3.24.21.bb:do_populate_sysroot, 
'gtk+/gtk+3_3.24.21.bb:do_populate_sysroot:virtual:native:/poky/meta/recipes-gnome/gtk+/gtk+3_3.24.21.bb 
hicolor-icon-theme/hicolor-icon-theme_0.17.bb:do_populate_sysroot 
librsvg/librsvg_2.40.20.bb:do_populate_sysroot:virtual:native:/poky/meta/recipes-gnome/librsvg/librsvg_2.40.20.bb 
libtool/libtool-native_2.4.6.bb:do_populate_sysroot 
pkgconfig/pkgconfig_git.bb:do_populate_sysroot:virtual:native:/poky/meta/recipes-devtools/pkgconfig/pkgconfig_git.bb 
pseudo/pseudo_git.bb:do_populate_sysroot:virtual:native:/poky/meta/recipes-devtools/pseudo/pseudo_git.bb']
Number of task dependencies changed
Dependency on task gtk+/gtk+3_3.24.21.bb:do_populate_sysroot was added 
with hash 60018dc07fa11c46226232c0923871b65f88f51a0b7665045f779a1111c1e1dd
Dependency on task gdk-pixbuf/gdk-pixbuf_2.40.0.bb:do_populate_sysroot 
was added with hash 
17cd8a1fe76fa0b342dc50b8e2d71d8d88eec93d0367ae48629ae66f41eca11f


On 7/11/20 12:37 AM, Martin Jansa wrote:
> With this change now in master and dunfell there is signature issue in 
> allarch adwaita-icon-theme now runtime depending on TUNE_PKGARCH 
> gdk-pixbuf as shown by sstate-diff-machines.sh/bitbake-diffsigs 
> <http://sstate-diff-machines.sh/bitbake-diffsigs>:
>
> bitbake-diffsigs 
> tmp-glibc/sstate-diff/1594398219/qemu*/all-webos-linux/adwaita-icon-theme/*do_prepare_recipe_sysroot*
> NOTE: Starting bitbake server...
> NOTE: Started PRServer with DBfile: cache/prserv.sqlite3, IP: 
> 127.0.0.1, PORT: 33511, PID: 36423
> Hash for dependent task 
> gdk-pixbuf/gdk-pixbuf_2.40.0.bb:do_populate_sysroot changed from 
> a72aba8432699c8ce4ca1f71833ef14a89ffde0ea4063e37b9d819fdb1e407f4 to 
> 1ad4e1bd76921b71482657f3b017184e9ade8e2a0b9f43ad64ed2dda83b1520f
> Unable to find matching sigdata for 
> openembedded-core/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.40.0.bb:do_populate_sysroot 
> with hashes 
> a72aba8432699c8ce4ca1f71833ef14a89ffde0ea4063e37b9d819fdb1e407f4 or 
> 1ad4e1bd76921b71482657f3b017184e9ade8e2a0b9f43ad64ed2dda83b1520f
>
> On Wed, Jul 1, 2020 at 3:39 AM Changqing Li 
> <changqing.li@windriver.com <mailto:changqing.li@windriver.com>> wrote:
>
>
>     On 6/30/20 6:01 PM, Richard Purdie wrote:
>     > On Tue, 2020-06-30 at 17:49 +0800, Changqing Li wrote:
>     >> From: Changqing Li <changqing.li@windriver.com
>     <mailto:changqing.li@windriver.com>>
>     >>
>     >> fix error:
>     >> + /usr/lib/gdk-pixbuf-2.0/gdk-pixbuf-query-loaders --update-cache
>     >> /var/tmp/rpm-tmp.mdYxY6: line 12:
>     /usr/lib/gdk-pixbuf-2.0/gdk-pixbuf-
>     >> query-loaders: No such file or directory
>     >> %post(adwaita-icon-theme-3.36.1-r0.0.noarch): waitpid(2961) rc 2961
>     >> status 7f00
>     >> warning: %post(adwaita-icon-theme-3.36.1-r0.0.noarch) scriptlet
>     >> failed, exit status 127
>     >>
>     >> when install adwaita-icon-theme, which inherit gtk-icon-cache
>     >> on target, above error reported,  fix by add needeed packages
>     >> in RDEPENDS
>     >>
>     >> Signed-off-by: Changqing Li <changqing.li@windriver.com
>     <mailto:changqing.li@windriver.com>>
>     >> ---
>     >>   meta/classes/gtk-icon-cache.bbclass | 2 ++
>     >>   1 file changed, 2 insertions(+)
>     >>
>     >> diff --git a/meta/classes/gtk-icon-cache.bbclass
>     b/meta/classes/gtk-
>     >> icon-cache.bbclass
>     >> index 91cb4ad409..7f218ce7ae 100644
>     >> --- a/meta/classes/gtk-icon-cache.bbclass
>     >> +++ b/meta/classes/gtk-icon-cache.bbclass
>     >> @@ -4,6 +4,8 @@ DEPENDS +=" ${@['hicolor-icon-theme',
>     '']['${BPN}' ==
>     >> 'hicolor-icon-theme']} gtk
>     >>
>     >>   PACKAGE_WRITE_DEPS += "gtk+3-native gdk-pixbuf-native"
>     >>
>     >> +RDEPENDS_${PN} += "gdk-pixbuf gtk+3"
>     >> +
>     >>   gtk_icon_cache_postinst() {
>     >>   if [ "x$D" != "x" ]; then
>     >>      $INTERCEPT_DIR/postinst_intercept update_gtk_icon_cache ${PKG}
>     >> \
>     > This isn't quite right since the postinst may be added to a package
>     > other than ${PN}.
>     >
>     > You need to add the RDEPENDS to the code:
>     >
>     >          rdepends = ' ' + d.getVar('MLPREFIX', False) +
>     "hicolor-icon-theme"
>     >          d.appendVar('RDEPENDS_%s' % pkg, rdepends)
>     >
>     > later in that class.
>     >
>     > Cheers,
>     >
>     > Richard
>     Thanks, I will correct it.
>     >
>     
>

[-- Attachment #2: Type: text/html, Size: 7861 bytes --]

Re: [OE-core] [PATCH] gtk-icon-cache.bbclass: update RDEPENDS

[Khem Raj]

On 7/12/20 11:03 PM, Changqing Li wrote:
> Hi, Martin
> 
> Thanks for tell me the problem.  Maybe I don't understand you 
> correctly,  but I don't met your problem, below is what I tried,
> 
> if I am wrong, please tell me how I can reproduce your problem, thanks.
> 
> 

since gtk+3 or perhaps even gdk-pixbuf is not allarch package being 
added as runtime dependency here would mean that any package thats 
inheriting this class and allarch class will have the issue Martin is 
seeing, one way to fix is to call it abi safe using 
SIGGEN_EXCLUDERECIPES_ABISAFE but since its a class, I dont think you 
can easily call that out in layer.conf.

> Here is what I tried:
> 
> bitbake adwaita-icon-themewithout my patch, and then build 
> adwaita-icon-theme with my patch, and then run below command:
> 
> bitbake-diffsigs 
> 3.36.1-r0.do_prepare_recipe_sysroot.sigdata.608eb6ea5873c19534fddfeacee59d81fa799ce6c965217ffe76a0141885093a 
> 3.36.1-r0.do_prepare_recipe_sysroot.sigdata.b10948f26bfd089980c9f9af928e108e9764627201dcfd9db43efc8a455b181b
> NOTE: Starting bitbake server...
> runtaskdeps changed:
> ['autoconf/autoconf_2.69.bb:do_populate_sysroot:virtual:native:/poky/meta/recipes-devtools/autoconf/autoconf_2.69.bb 
> automake/automake_1.16.2.bb:do_populate_sysroot:virtual:native:/poky/meta/recipes-devtools/automake/automake_1.16.2.bb', 
> +gdk-pixbuf/gdk-pixbuf_2.40.0.bb:do_populate_sysroot, 
> 'gnome/adwaita-icon-theme_3.36.1.bb:do_fetch 
> gnu-config/gnu-config_git.bb:do_populate_sysroot:virtual:native:/poky/meta/recipes-devtools/gnu-config/gnu-config_git.bb', 
> +gtk+/gtk+3_3.24.21.bb:do_populate_sysroot, 
> 'gtk+/gtk+3_3.24.21.bb:do_populate_sysroot:virtual:native:/poky/meta/recipes-gnome/gtk+/gtk+3_3.24.21.bb 
> hicolor-icon-theme/hicolor-icon-theme_0.17.bb:do_populate_sysroot 
> librsvg/librsvg_2.40.20.bb:do_populate_sysroot:virtual:native:/poky/meta/recipes-gnome/librsvg/librsvg_2.40.20.bb 
> libtool/libtool-native_2.4.6.bb:do_populate_sysroot 
> pkgconfig/pkgconfig_git.bb:do_populate_sysroot:virtual:native:/poky/meta/recipes-devtools/pkgconfig/pkgconfig_git.bb 
> pseudo/pseudo_git.bb:do_populate_sysroot:virtual:native:/poky/meta/recipes-devtools/pseudo/pseudo_git.bb']
> Number of task dependencies changed
> Dependency on task gtk+/gtk+3_3.24.21.bb:do_populate_sysroot was added 
> with hash 60018dc07fa11c46226232c0923871b65f88f51a0b7665045f779a1111c1e1dd
> Dependency on task gdk-pixbuf/gdk-pixbuf_2.40.0.bb:do_populate_sysroot 
> was added with hash 
> 17cd8a1fe76fa0b342dc50b8e2d71d8d88eec93d0367ae48629ae66f41eca11f
> 
> 
> On 7/11/20 12:37 AM, Martin Jansa wrote:
>> With this change now in master and dunfell there is signature issue in 
>> allarch adwaita-icon-theme now runtime depending on TUNE_PKGARCH 
>> gdk-pixbuf as shown by sstate-diff-machines.sh/bitbake-diffsigs 
>> <http://sstate-diff-machines.sh/bitbake-diffsigs>:
>>
>> bitbake-diffsigs 
>> tmp-glibc/sstate-diff/1594398219/qemu*/all-webos-linux/adwaita-icon-theme/*do_prepare_recipe_sysroot*
>> NOTE: Starting bitbake server...
>> NOTE: Started PRServer with DBfile: cache/prserv.sqlite3, IP: 
>> 127.0.0.1, PORT: 33511, PID: 36423
>> Hash for dependent task 
>> gdk-pixbuf/gdk-pixbuf_2.40.0.bb:do_populate_sysroot changed from 
>> a72aba8432699c8ce4ca1f71833ef14a89ffde0ea4063e37b9d819fdb1e407f4 to 
>> 1ad4e1bd76921b71482657f3b017184e9ade8e2a0b9f43ad64ed2dda83b1520f
>> Unable to find matching sigdata for 
>> openembedded-core/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.40.0.bb:do_populate_sysroot 
>> with hashes 
>> a72aba8432699c8ce4ca1f71833ef14a89ffde0ea4063e37b9d819fdb1e407f4 or 
>> 1ad4e1bd76921b71482657f3b017184e9ade8e2a0b9f43ad64ed2dda83b1520f
>>
>> On Wed, Jul 1, 2020 at 3:39 AM Changqing Li 
>> <changqing.li@windriver.com <mailto:changqing.li@windriver.com>> wrote:
>>
>>
>>     On 6/30/20 6:01 PM, Richard Purdie wrote:
>>     > On Tue, 2020-06-30 at 17:49 +0800, Changqing Li wrote:
>>     >> From: Changqing Li <changqing.li@windriver.com
>>     <mailto:changqing.li@windriver.com>>
>>     >>
>>     >> fix error:
>>     >> + /usr/lib/gdk-pixbuf-2.0/gdk-pixbuf-query-loaders --update-cache
>>     >> /var/tmp/rpm-tmp.mdYxY6: line 12:
>>     /usr/lib/gdk-pixbuf-2.0/gdk-pixbuf-
>>     >> query-loaders: No such file or directory
>>     >> %post(adwaita-icon-theme-3.36.1-r0.0.noarch): waitpid(2961) rc 2961
>>     >> status 7f00
>>     >> warning: %post(adwaita-icon-theme-3.36.1-r0.0.noarch) scriptlet
>>     >> failed, exit status 127
>>     >>
>>     >> when install adwaita-icon-theme, which inherit gtk-icon-cache
>>     >> on target, above error reported,  fix by add needeed packages
>>     >> in RDEPENDS
>>     >>
>>     >> Signed-off-by: Changqing Li <changqing.li@windriver.com
>>     <mailto:changqing.li@windriver.com>>
>>     >> ---
>>     >>   meta/classes/gtk-icon-cache.bbclass | 2 ++
>>     >>   1 file changed, 2 insertions(+)
>>     >>
>>     >> diff --git a/meta/classes/gtk-icon-cache.bbclass
>>     b/meta/classes/gtk-
>>     >> icon-cache.bbclass
>>     >> index 91cb4ad409..7f218ce7ae 100644
>>     >> --- a/meta/classes/gtk-icon-cache.bbclass
>>     >> +++ b/meta/classes/gtk-icon-cache.bbclass
>>     >> @@ -4,6 +4,8 @@ DEPENDS +=" ${@['hicolor-icon-theme',
>>     '']['${BPN}' ==
>>     >> 'hicolor-icon-theme']} gtk
>>     >>
>>     >>   PACKAGE_WRITE_DEPS += "gtk+3-native gdk-pixbuf-native"
>>     >>
>>     >> +RDEPENDS_${PN} += "gdk-pixbuf gtk+3"
>>     >> +
>>     >>   gtk_icon_cache_postinst() {
>>     >>   if [ "x$D" != "x" ]; then
>>     >>      $INTERCEPT_DIR/postinst_intercept update_gtk_icon_cache ${PKG}
>>     >> \
>>     > This isn't quite right since the postinst may be added to a package
>>     > other than ${PN}.
>>     >
>>     > You need to add the RDEPENDS to the code:
>>     >
>>     >          rdepends = ' ' + d.getVar('MLPREFIX', False) +
>>     "hicolor-icon-theme"
>>     >          d.appendVar('RDEPENDS_%s' % pkg, rdepends)
>>     >
>>     > later in that class.
>>     >
>>     > Cheers,
>>     >
>>     > Richard
>>     Thanks, I will correct it.
>>     >
>>
> 
> 
> 

Re: [OE-core] [PATCH] gtk-icon-cache.bbclass: update RDEPENDS

[Changqing Li]

On 7/14/20 12:30 AM, Khem Raj wrote:
>
>
> On 7/12/20 11:03 PM, Changqing Li wrote:
>> Hi, Martin
>>
>> Thanks for tell me the problem.  Maybe I don't understand you 
>> correctly,  but I don't met your problem, below is what I tried,
>>
>> if I am wrong, please tell me how I can reproduce your problem, thanks.
>>
>>
>
> since gtk+3 or perhaps even gdk-pixbuf is not allarch package being 
> added as runtime dependency here would mean that any package thats 
> inheriting this class and allarch class will have the issue Martin is 
> seeing, one way to fix is to call it abi safe using 
> SIGGEN_EXCLUDERECIPES_ABISAFE but since its a class, I dont think you 
> can easily call that out in layer.conf.

How about add it in gtk-icon-cache.bbclass,  and check the arch first,  
if it is allarch,  then add gtk+3/pixbug into SIGGEN_EXCLUDERECIPES_ABISAFE?

>
>> Here is what I tried:
>>
>> bitbake adwaita-icon-themewithout my patch, and then build 
>> adwaita-icon-theme with my patch, and then run below command:
>>
>> bitbake-diffsigs 
>> 3.36.1-r0.do_prepare_recipe_sysroot.sigdata.608eb6ea5873c19534fddfeacee59d81fa799ce6c965217ffe76a0141885093a 
>> 3.36.1-r0.do_prepare_recipe_sysroot.sigdata.b10948f26bfd089980c9f9af928e108e9764627201dcfd9db43efc8a455b181b 
>>
>> NOTE: Starting bitbake server...
>> runtaskdeps changed:
>> ['autoconf/autoconf_2.69.bb:do_populate_sysroot:virtual:native:/poky/meta/recipes-devtools/autoconf/autoconf_2.69.bb 
>> automake/automake_1.16.2.bb:do_populate_sysroot:virtual:native:/poky/meta/recipes-devtools/automake/automake_1.16.2.bb', 
>> +gdk-pixbuf/gdk-pixbuf_2.40.0.bb:do_populate_sysroot, 
>> 'gnome/adwaita-icon-theme_3.36.1.bb:do_fetch 
>> gnu-config/gnu-config_git.bb:do_populate_sysroot:virtual:native:/poky/meta/recipes-devtools/gnu-config/gnu-config_git.bb', 
>> +gtk+/gtk+3_3.24.21.bb:do_populate_sysroot, 
>> 'gtk+/gtk+3_3.24.21.bb:do_populate_sysroot:virtual:native:/poky/meta/recipes-gnome/gtk+/gtk+3_3.24.21.bb 
>> hicolor-icon-theme/hicolor-icon-theme_0.17.bb:do_populate_sysroot 
>> librsvg/librsvg_2.40.20.bb:do_populate_sysroot:virtual:native:/poky/meta/recipes-gnome/librsvg/librsvg_2.40.20.bb 
>> libtool/libtool-native_2.4.6.bb:do_populate_sysroot 
>> pkgconfig/pkgconfig_git.bb:do_populate_sysroot:virtual:native:/poky/meta/recipes-devtools/pkgconfig/pkgconfig_git.bb 
>> pseudo/pseudo_git.bb:do_populate_sysroot:virtual:native:/poky/meta/recipes-devtools/pseudo/pseudo_git.bb'] 
>>
>> Number of task dependencies changed
>> Dependency on task gtk+/gtk+3_3.24.21.bb:do_populate_sysroot was 
>> added with hash 
>> 60018dc07fa11c46226232c0923871b65f88f51a0b7665045f779a1111c1e1dd
>> Dependency on task 
>> gdk-pixbuf/gdk-pixbuf_2.40.0.bb:do_populate_sysroot was added with 
>> hash 17cd8a1fe76fa0b342dc50b8e2d71d8d88eec93d0367ae48629ae66f41eca11f
>>
>>
>> On 7/11/20 12:37 AM, Martin Jansa wrote:
>>> With this change now in master and dunfell there is signature issue 
>>> in allarch adwaita-icon-theme now runtime depending on TUNE_PKGARCH 
>>> gdk-pixbuf as shown by sstate-diff-machines.sh/bitbake-diffsigs 
>>> <http://sstate-diff-machines.sh/bitbake-diffsigs>:
>>>
>>> bitbake-diffsigs 
>>> tmp-glibc/sstate-diff/1594398219/qemu*/all-webos-linux/adwaita-icon-theme/*do_prepare_recipe_sysroot*
>>> NOTE: Starting bitbake server...
>>> NOTE: Started PRServer with DBfile: cache/prserv.sqlite3, IP: 
>>> 127.0.0.1, PORT: 33511, PID: 36423
>>> Hash for dependent task 
>>> gdk-pixbuf/gdk-pixbuf_2.40.0.bb:do_populate_sysroot changed from 
>>> a72aba8432699c8ce4ca1f71833ef14a89ffde0ea4063e37b9d819fdb1e407f4 to 
>>> 1ad4e1bd76921b71482657f3b017184e9ade8e2a0b9f43ad64ed2dda83b1520f
>>> Unable to find matching sigdata for 
>>> openembedded-core/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.40.0.bb:do_populate_sysroot 
>>> with hashes 
>>> a72aba8432699c8ce4ca1f71833ef14a89ffde0ea4063e37b9d819fdb1e407f4 or 
>>> 1ad4e1bd76921b71482657f3b017184e9ade8e2a0b9f43ad64ed2dda83b1520f

Martin, Khem, I still don't know how to reproduce this error "Unable to 
find matching sigdata for ....",  could you send how to reproduce?

>>>
>>> On Wed, Jul 1, 2020 at 3:39 AM Changqing Li 
>>> <changqing.li@windriver.com <mailto:changqing.li@windriver.com>> wrote:
>>>
>>>
>>>     On 6/30/20 6:01 PM, Richard Purdie wrote:
>>>     > On Tue, 2020-06-30 at 17:49 +0800, Changqing Li wrote:
>>>     >> From: Changqing Li <changqing.li@windriver.com
>>>     <mailto:changqing.li@windriver.com>>
>>>     >>
>>>     >> fix error:
>>>     >> + /usr/lib/gdk-pixbuf-2.0/gdk-pixbuf-query-loaders 
>>> --update-cache
>>>     >> /var/tmp/rpm-tmp.mdYxY6: line 12:
>>>     /usr/lib/gdk-pixbuf-2.0/gdk-pixbuf-
>>>     >> query-loaders: No such file or directory
>>>     >> %post(adwaita-icon-theme-3.36.1-r0.0.noarch): waitpid(2961) 
>>> rc 2961
>>>     >> status 7f00
>>>     >> warning: %post(adwaita-icon-theme-3.36.1-r0.0.noarch) scriptlet
>>>     >> failed, exit status 127
>>>     >>
>>>     >> when install adwaita-icon-theme, which inherit gtk-icon-cache
>>>     >> on target, above error reported,  fix by add needeed packages
>>>     >> in RDEPENDS
>>>     >>
>>>     >> Signed-off-by: Changqing Li <changqing.li@windriver.com
>>>     <mailto:changqing.li@windriver.com>>
>>>     >> ---
>>>     >>   meta/classes/gtk-icon-cache.bbclass | 2 ++
>>>     >>   1 file changed, 2 insertions(+)
>>>     >>
>>>     >> diff --git a/meta/classes/gtk-icon-cache.bbclass
>>>     b/meta/classes/gtk-
>>>     >> icon-cache.bbclass
>>>     >> index 91cb4ad409..7f218ce7ae 100644
>>>     >> --- a/meta/classes/gtk-icon-cache.bbclass
>>>     >> +++ b/meta/classes/gtk-icon-cache.bbclass
>>>     >> @@ -4,6 +4,8 @@ DEPENDS +=" ${@['hicolor-icon-theme',
>>>     '']['${BPN}' ==
>>>     >> 'hicolor-icon-theme']} gtk
>>>     >>
>>>     >>   PACKAGE_WRITE_DEPS += "gtk+3-native gdk-pixbuf-native"
>>>     >>
>>>     >> +RDEPENDS_${PN} += "gdk-pixbuf gtk+3"
>>>     >> +
>>>     >>   gtk_icon_cache_postinst() {
>>>     >>   if [ "x$D" != "x" ]; then
>>>     >>      $INTERCEPT_DIR/postinst_intercept update_gtk_icon_cache 
>>> ${PKG}
>>>     >> \
>>>     > This isn't quite right since the postinst may be added to a 
>>> package
>>>     > other than ${PN}.
>>>     >
>>>     > You need to add the RDEPENDS to the code:
>>>     >
>>>     >          rdepends = ' ' + d.getVar('MLPREFIX', False) +
>>>     "hicolor-icon-theme"
>>>     >          d.appendVar('RDEPENDS_%s' % pkg, rdepends)
>>>     >
>>>     > later in that class.
>>>     >
>>>     > Cheers,
>>>     >
>>>     > Richard
>>>     Thanks, I will correct it.
>>>     >
>>>
>>
>> 
>>

Re: [OE-core] [PATCH] gtk-icon-cache.bbclass: update RDEPENDS

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 7735 bytes --]

> Martin, Khem, I still don't know how to reproduce this error "Unable
to find matching sigdata for ....",  could you send how to reproduce?

"Unable to find matching sigdata for ...." part is irrelevant

The issue is this:
"Hash for dependent task gdk-pixbuf/gdk-pixbuf_2.40.0.bb:do_populate_sysroot
changed from
a72aba8432699c8ce4ca1f71833ef14a89ffde0ea4063e37b9d819fdb1e407f4 to
1ad4e1bd76921b71482657f3b017184e9ade8e2a0b9f43ad64ed2dda83b1520f"

and you can reproduce it when you generate the signatures for 2 MACHINEs
with different TUNE_PKGARCH e.g. qemux86 and qemuarm.



On Fri, Jul 17, 2020 at 9:36 AM Changqing Li <changqing.li@windriver.com>
wrote:

>
> On 7/14/20 12:30 AM, Khem Raj wrote:
> >
> >
> > On 7/12/20 11:03 PM, Changqing Li wrote:
> >> Hi, Martin
> >>
> >> Thanks for tell me the problem.  Maybe I don't understand you
> >> correctly,  but I don't met your problem, below is what I tried,
> >>
> >> if I am wrong, please tell me how I can reproduce your problem, thanks.
> >>
> >>
> >
> > since gtk+3 or perhaps even gdk-pixbuf is not allarch package being
> > added as runtime dependency here would mean that any package thats
> > inheriting this class and allarch class will have the issue Martin is
> > seeing, one way to fix is to call it abi safe using
> > SIGGEN_EXCLUDERECIPES_ABISAFE but since its a class, I dont think you
> > can easily call that out in layer.conf.
>
> How about add it in gtk-icon-cache.bbclass,  and check the arch first,
> if it is allarch,  then add gtk+3/pixbug into
> SIGGEN_EXCLUDERECIPES_ABISAFE?
>
> >
> >> Here is what I tried:
> >>
> >> bitbake adwaita-icon-themewithout my patch, and then build
> >> adwaita-icon-theme with my patch, and then run below command:
> >>
> >> bitbake-diffsigs
> >>
> 3.36.1-r0.do_prepare_recipe_sysroot.sigdata.608eb6ea5873c19534fddfeacee59d81fa799ce6c965217ffe76a0141885093a
>
> >>
> 3.36.1-r0.do_prepare_recipe_sysroot.sigdata.b10948f26bfd089980c9f9af928e108e9764627201dcfd9db43efc8a455b181b
>
> >>
> >> NOTE: Starting bitbake server...
> >> runtaskdeps changed:
> >> ['autoconf/autoconf_2.69.bb:
> do_populate_sysroot:virtual:native:/poky/meta/recipes-devtools/autoconf/
> autoconf_2.69.bb
> >> automake/automake_1.16.2.bb:
> do_populate_sysroot:virtual:native:/poky/meta/recipes-devtools/automake/
> automake_1.16.2.bb',
> >> +gdk-pixbuf/gdk-pixbuf_2.40.0.bb:do_populate_sysroot,
> >> 'gnome/adwaita-icon-theme_3.36.1.bb:do_fetch
> >> gnu-config/gnu-config_git.bb:
> do_populate_sysroot:virtual:native:/poky/meta/recipes-devtools/gnu-config/
> gnu-config_git.bb',
> >> +gtk+/gtk+3_3.24.21.bb:do_populate_sysroot,
> >> 'gtk+/gtk+3_3.24.21.bb:
> do_populate_sysroot:virtual:native:/poky/meta/recipes-gnome/gtk+/gtk+
> 3_3.24.21.bb
> >> hicolor-icon-theme/hicolor-icon-theme_0.17.bb:do_populate_sysroot
> >> librsvg/librsvg_2.40.20.bb:
> do_populate_sysroot:virtual:native:/poky/meta/recipes-gnome/librsvg/
> librsvg_2.40.20.bb
> >> libtool/libtool-native_2.4.6.bb:do_populate_sysroot
> >> pkgconfig/pkgconfig_git.bb:
> do_populate_sysroot:virtual:native:/poky/meta/recipes-devtools/pkgconfig/
> pkgconfig_git.bb
> >> pseudo/pseudo_git.bb:
> do_populate_sysroot:virtual:native:/poky/meta/recipes-devtools/pseudo/
> pseudo_git.bb']
> >>
> >> Number of task dependencies changed
> >> Dependency on task gtk+/gtk+3_3.24.21.bb:do_populate_sysroot was
> >> added with hash
> >> 60018dc07fa11c46226232c0923871b65f88f51a0b7665045f779a1111c1e1dd
> >> Dependency on task
> >> gdk-pixbuf/gdk-pixbuf_2.40.0.bb:do_populate_sysroot was added with
> >> hash 17cd8a1fe76fa0b342dc50b8e2d71d8d88eec93d0367ae48629ae66f41eca11f
> >>
> >>
> >> On 7/11/20 12:37 AM, Martin Jansa wrote:
> >>> With this change now in master and dunfell there is signature issue
> >>> in allarch adwaita-icon-theme now runtime depending on TUNE_PKGARCH
> >>> gdk-pixbuf as shown by sstate-diff-machines.sh/bitbake-diffsigs
> >>> <http://sstate-diff-machines.sh/bitbake-diffsigs>:
> >>>
> >>> bitbake-diffsigs
> >>>
> tmp-glibc/sstate-diff/1594398219/qemu*/all-webos-linux/adwaita-icon-theme/*do_prepare_recipe_sysroot*
> >>> NOTE: Starting bitbake server...
> >>> NOTE: Started PRServer with DBfile: cache/prserv.sqlite3, IP:
> >>> 127.0.0.1, PORT: 33511, PID: 36423
> >>> Hash for dependent task
> >>> gdk-pixbuf/gdk-pixbuf_2.40.0.bb:do_populate_sysroot changed from
> >>> a72aba8432699c8ce4ca1f71833ef14a89ffde0ea4063e37b9d819fdb1e407f4 to
> >>> 1ad4e1bd76921b71482657f3b017184e9ade8e2a0b9f43ad64ed2dda83b1520f
> >>> Unable to find matching sigdata for
> >>> openembedded-core/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.40.0.bb:do_populate_sysroot
>
> >>> with hashes
> >>> a72aba8432699c8ce4ca1f71833ef14a89ffde0ea4063e37b9d819fdb1e407f4 or
> >>> 1ad4e1bd76921b71482657f3b017184e9ade8e2a0b9f43ad64ed2dda83b1520f
>
> Martin, Khem, I still don't know how to reproduce this error "Unable to
> find matching sigdata for ....",  could you send how to reproduce?
>
> >>>
> >>> On Wed, Jul 1, 2020 at 3:39 AM Changqing Li
> >>> <changqing.li@windriver.com <mailto:changqing.li@windriver.com>>
> wrote:
> >>>
> >>>
> >>>     On 6/30/20 6:01 PM, Richard Purdie wrote:
> >>>     > On Tue, 2020-06-30 at 17:49 +0800, Changqing Li wrote:
> >>>     >> From: Changqing Li <changqing.li@windriver.com
> >>>     <mailto:changqing.li@windriver.com>>
> >>>     >>
> >>>     >> fix error:
> >>>     >> + /usr/lib/gdk-pixbuf-2.0/gdk-pixbuf-query-loaders
> >>> --update-cache
> >>>     >> /var/tmp/rpm-tmp.mdYxY6: line 12:
> >>>     /usr/lib/gdk-pixbuf-2.0/gdk-pixbuf-
> >>>     >> query-loaders: No such file or directory
> >>>     >> %post(adwaita-icon-theme-3.36.1-r0.0.noarch): waitpid(2961)
> >>> rc 2961
> >>>     >> status 7f00
> >>>     >> warning: %post(adwaita-icon-theme-3.36.1-r0.0.noarch) scriptlet
> >>>     >> failed, exit status 127
> >>>     >>
> >>>     >> when install adwaita-icon-theme, which inherit gtk-icon-cache
> >>>     >> on target, above error reported,  fix by add needeed packages
> >>>     >> in RDEPENDS
> >>>     >>
> >>>     >> Signed-off-by: Changqing Li <changqing.li@windriver.com
> >>>     <mailto:changqing.li@windriver.com>>
> >>>     >> ---
> >>>     >>   meta/classes/gtk-icon-cache.bbclass | 2 ++
> >>>     >>   1 file changed, 2 insertions(+)
> >>>     >>
> >>>     >> diff --git a/meta/classes/gtk-icon-cache.bbclass
> >>>     b/meta/classes/gtk-
> >>>     >> icon-cache.bbclass
> >>>     >> index 91cb4ad409..7f218ce7ae 100644
> >>>     >> --- a/meta/classes/gtk-icon-cache.bbclass
> >>>     >> +++ b/meta/classes/gtk-icon-cache.bbclass
> >>>     >> @@ -4,6 +4,8 @@ DEPENDS +=" ${@['hicolor-icon-theme',
> >>>     '']['${BPN}' ==
> >>>     >> 'hicolor-icon-theme']} gtk
> >>>     >>
> >>>     >>   PACKAGE_WRITE_DEPS += "gtk+3-native gdk-pixbuf-native"
> >>>     >>
> >>>     >> +RDEPENDS_${PN} += "gdk-pixbuf gtk+3"
> >>>     >> +
> >>>     >>   gtk_icon_cache_postinst() {
> >>>     >>   if [ "x$D" != "x" ]; then
> >>>     >>      $INTERCEPT_DIR/postinst_intercept update_gtk_icon_cache
> >>> ${PKG}
> >>>     >> \
> >>>     > This isn't quite right since the postinst may be added to a
> >>> package
> >>>     > other than ${PN}.
> >>>     >
> >>>     > You need to add the RDEPENDS to the code:
> >>>     >
> >>>     >          rdepends = ' ' + d.getVar('MLPREFIX', False) +
> >>>     "hicolor-icon-theme"
> >>>     >          d.appendVar('RDEPENDS_%s' % pkg, rdepends)
> >>>     >
> >>>     > later in that class.
> >>>     >
> >>>     > Cheers,
> >>>     >
> >>>     > Richard
> >>>     Thanks, I will correct it.
> >>>     >
> >>>
> >>
> >> 
> >>
>

[-- Attachment #2: Type: text/html, Size: 11272 bytes --]

[PATCH] layer.conf: fix adwaita-icon-theme signature change problem

[Changqing Li]

From: Changqing Li <changqing.li@windriver.com>

allarch package adwaita-icon-theme inherit both allarch and
gtk-icon-cache, since commit 31e3d34c8a9c3e8481aa837aa0bf52adf095fe62
[gtk-icon-cache.bbclass: add runtime dependency], it start depend on
non-allarch packages gdk-pixbuf and gtk+3, which make it's signature
changes when machine changed.

like for task do_prepare_recipe_sysroot:
"Hash for dependent task
gdk-pixbuf/gdk-pixbuf_2.40.0.bb:do_populate_sysroot changed from
a72aba8432699c8ce4ca1f71833ef14a89ffde0ea4063e37b9d819fdb1e407f4 to
1ad4e1bd76921b71482657f3b017184e9ade8e2a0b9f43ad64ed2dda83b1520f"

the only way to fix this is remove the task dependency.
SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS not work in class, so add it in
layer.conf.

Maybe we have other recipes under other layers have similar problem, we
can only add one by one to its layer.conf, seems not a good idea. but
add *->pixbuf will influence other packages

Signed-off-by: Changqing Li <changqing.li@windriver.com>
---
 meta/conf/layer.conf | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/conf/layer.conf b/meta/conf/layer.conf
index 098ef12ac6..c115c87043 100644
--- a/meta/conf/layer.conf
+++ b/meta/conf/layer.conf
@@ -80,6 +80,8 @@ SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \
   weston-init->kbd \
   connman->xl2tpd \
   lttng-tools->lttng-modules \
+  adwaita-icon-theme->gdk-pixbuf \
+  adwaita-icon-theme->gtk+3 \
 "
 
 # Avoid adding bison-native to the sysroot without a specific
-- 
2.17.1

Re: [OE-core] [PATCH] layer.conf: fix adwaita-icon-theme signature change problem

[Khem Raj]

infact the error is not limited to just one theme recipe but all which
inherit this class see

http://jenkins.nas-admin.org/view/OE/job/oe_world_workspace-compare-signatures/980/console

so are we forcing same kind of fix everywhere ? seems a bit of kludge to me

On Wed, Jul 22, 2020 at 11:55 PM Changqing Li
<changqing.li@windriver.com> wrote:
>
> From: Changqing Li <changqing.li@windriver.com>
>
> allarch package adwaita-icon-theme inherit both allarch and
> gtk-icon-cache, since commit 31e3d34c8a9c3e8481aa837aa0bf52adf095fe62
> [gtk-icon-cache.bbclass: add runtime dependency], it start depend on
> non-allarch packages gdk-pixbuf and gtk+3, which make it's signature
> changes when machine changed.
>
> like for task do_prepare_recipe_sysroot:
> "Hash for dependent task
> gdk-pixbuf/gdk-pixbuf_2.40.0.bb:do_populate_sysroot changed from
> a72aba8432699c8ce4ca1f71833ef14a89ffde0ea4063e37b9d819fdb1e407f4 to
> 1ad4e1bd76921b71482657f3b017184e9ade8e2a0b9f43ad64ed2dda83b1520f"
>
> the only way to fix this is remove the task dependency.
> SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS not work in class, so add it in
> layer.conf.
>
> Maybe we have other recipes under other layers have similar problem, we
> can only add one by one to its layer.conf, seems not a good idea. but
> add *->pixbuf will influence other packages
>
> Signed-off-by: Changqing Li <changqing.li@windriver.com>
> ---
>  meta/conf/layer.conf | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/conf/layer.conf b/meta/conf/layer.conf
> index 098ef12ac6..c115c87043 100644
> --- a/meta/conf/layer.conf
> +++ b/meta/conf/layer.conf
> @@ -80,6 +80,8 @@ SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \
>    weston-init->kbd \
>    connman->xl2tpd \
>    lttng-tools->lttng-modules \
> +  adwaita-icon-theme->gdk-pixbuf \
> +  adwaita-icon-theme->gtk+3 \
>  "
>
>  # Avoid adding bison-native to the sysroot without a specific
> --
> 2.17.1
>
> 

Re: [OE-core] [PATCH] layer.conf: fix adwaita-icon-theme signature change problem

[Changqing Li]

On 7/23/20 4:35 PM, Khem Raj wrote:
> infact the error is not limited to just one theme recipe but all which
> inherit this class see
>
> http://jenkins.nas-admin.org/view/OE/job/oe_world_workspace-compare-signatures/980/console
>
> so are we forcing same kind of fix everywhere ? seems a bit of kludge to me

Yes,  I also noticed that  there are several recipes under other layer 
have same problem,

and that's why I say this fix maybe not a good idea.  but signatures 
generated very early,

SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS not work if set in the 
gtk-icon-cache.bbclass.

Any other good idea? Thanks.

>
> On Wed, Jul 22, 2020 at 11:55 PM Changqing Li
> <changqing.li@windriver.com> wrote:
>> From: Changqing Li <changqing.li@windriver.com>
>>
>> allarch package adwaita-icon-theme inherit both allarch and
>> gtk-icon-cache, since commit 31e3d34c8a9c3e8481aa837aa0bf52adf095fe62
>> [gtk-icon-cache.bbclass: add runtime dependency], it start depend on
>> non-allarch packages gdk-pixbuf and gtk+3, which make it's signature
>> changes when machine changed.
>>
>> like for task do_prepare_recipe_sysroot:
>> "Hash for dependent task
>> gdk-pixbuf/gdk-pixbuf_2.40.0.bb:do_populate_sysroot changed from
>> a72aba8432699c8ce4ca1f71833ef14a89ffde0ea4063e37b9d819fdb1e407f4 to
>> 1ad4e1bd76921b71482657f3b017184e9ade8e2a0b9f43ad64ed2dda83b1520f"
>>
>> the only way to fix this is remove the task dependency.
>> SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS not work in class, so add it in
>> layer.conf.
>>
>> Maybe we have other recipes under other layers have similar problem, we
>> can only add one by one to its layer.conf, seems not a good idea. but
>> add *->pixbuf will influence other packages
>>
>> Signed-off-by: Changqing Li <changqing.li@windriver.com>
>> ---
>>   meta/conf/layer.conf | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/meta/conf/layer.conf b/meta/conf/layer.conf
>> index 098ef12ac6..c115c87043 100644
>> --- a/meta/conf/layer.conf
>> +++ b/meta/conf/layer.conf
>> @@ -80,6 +80,8 @@ SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \
>>     weston-init->kbd \
>>     connman->xl2tpd \
>>     lttng-tools->lttng-modules \
>> +  adwaita-icon-theme->gdk-pixbuf \
>> +  adwaita-icon-theme->gtk+3 \
>>   "
>>
>>   # Avoid adding bison-native to the sysroot without a specific
>> --
>> 2.17.1
>>
>>