All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Philipp Tomsich <philipp.tomsich@vrull.eu>, qemu-devel@nongnu.org
Cc: Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH v2 1/2] tcg: add dup_const_tl wrapper
Date: Mon, 4 Oct 2021 19:22:30 -0700	[thread overview]
Message-ID: <ae1a0274-fe91-5736-0938-25e931c88548@linaro.org> (raw)
In-Reply-To: <20211003214243.3813425-1-philipp.tomsich@vrull.eu>

On 10/3/21 2:42 PM, Philipp Tomsich wrote:
> dup_const always generates a uint64_t, which may exceed the size of a
> target_long (generating warnings with recent-enough compilers).
> 
> To ensure that we can use dup_const both for 64bit and 32bit targets,
> this adds dup_const_tl, which either maps back to dup_const (for 64bit
> targets) or provides a similar implementation using 32bit constants.
> 
> Signed-off-by: Philipp Tomsich<philipp.tomsich@vrull.eu>
> 
> ---
> 
> Changes in v2:
> - Changed dup_const_tl to enforce the sanity check with
>    qemu_build_not_reached as requested in the review.

Queueing this one patch through tcg-next.
I'll let Alistair take the other through riscv.

r~


      parent reply	other threads:[~2021-10-05  2:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-03 21:42 [PATCH v2 1/2] tcg: add dup_const_tl wrapper Philipp Tomsich
2021-10-03 21:42 ` [PATCH v2 2/2] target/riscv: Use dup_const_tl in orc.b to legalise truncation of constant Philipp Tomsich
2021-10-04  7:43   ` Philippe Mathieu-Daudé
2021-10-06 22:26   ` Alistair Francis
2021-10-06 22:42   ` Alistair Francis
2021-10-04  0:38 ` [PATCH v2 1/2] tcg: add dup_const_tl wrapper Richard Henderson
2021-10-04  7:43 ` Philippe Mathieu-Daudé
2021-10-05  2:22 ` Richard Henderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae1a0274-fe91-5736-0938-25e931c88548@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alistair.francis@wdc.com \
    --cc=philipp.tomsich@vrull.eu \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.