Re: [PATCH] drm/amdgpu: expose amdgpu_sensors on pre-powerplay chips

From: Samuel Pitoiset <samuel.pitoiset-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Tom St Denis" <tom.stdenis-5C7GfCeVMHo@public.gmane.org>,
	"Deucher,
	Alexander" <Alexander.Deucher-5C7GfCeVMHo@public.gmane.org>,
	"'Michel Dänzer'"
	<michel-otUistvHUpPR7s880joybQ@public.gmane.org>
Cc: "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH] drm/amdgpu: expose amdgpu_sensors on pre-powerplay chips
Date: Wed, 15 Feb 2017 16:55:47 +0100	[thread overview]
Message-ID: <ae23658a-01eb-9986-ae66-54ba06da27a5@gmail.com> (raw)
In-Reply-To: <1ef8a2b2-9591-64dc-b924-e4b274ab0745-5C7GfCeVMHo@public.gmane.org>

On 02/15/2017 04:01 PM, Tom St Denis wrote:
> On 14/02/17 09:56 PM, Deucher, Alexander wrote:
>>> -----Original Message-----
>>> From: Michel Dänzer [mailto:michel@daenzer.net]
>>> Sent: Tuesday, February 14, 2017 9:52 PM
>>> To: Deucher, Alexander; 'Samuel Pitoiset'; StDenis, Tom
>>> Cc: amd-gfx@lists.freedesktop.org
>>> Subject: Re: [PATCH] drm/amdgpu: expose amdgpu_sensors on pre-
>>> powerplay chips
>>>
>>> On 15/02/17 01:17 AM, Deucher, Alexander wrote:
>>>>> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On
>>> Behalf
>>>>> Of Samuel Pitoiset
>>>>>
>>>>>> Otherwise, it seems to work though the GPU_TEMP reads as "5000" on
>>> my
>>>>>> Kaveri (meaning temp of 5C which isn't true).
>>>>>>
>>>>>> I suspect the dpm code is reading the wrong register to get the
>>>>>> temp but
>>>>>> we can fix that in another change later on.
>>>>>
>>>>> No idea. It was just a copy-n-paste. Maybe the initial code is buggy?
>>>>
>>>> I don’t know that the GPU temp sensor on CI based APUs actually works
>>>> properly.  I think the package temperature is exposed via the CPU
>>>> thermals.
>>>
>>> Seems to work fine with radeon on my two Kaveri laptops, FWIW.
>>>
>>> On my desktop Kaveri, unplausibly low values (around 9-10C) are reported
>>> at idle for both GPU and CPU. With load, both go up to around 30C, so it
>>> seems like the values make sense in a relative sense but not in an
>>> absolute one.
>>
>> I think  I vaguely recall that it might actually be power rather than
>> temperature.  Need to check with the SMU guys.
>
>
> On my retail kaveri (with latest bios...) it seems to track with load
> but isn't really accurate (it'll jump double digits back and forth)
>
> Eitherway though if Samuel updates the patches to include a check for
> amdgpu_drm we should be able to commit them.

Sure, I will send a v3.

>
> I've already created a patch for umr to read them, just waiting on the
> kernel side to land.
>
> Tom
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx