From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH V2 02/10] nl80211: allow multiple active scheduled scan requests
Date: Tue, 18 Apr 2017 21:14:51 +0200 [thread overview]
Message-ID: <ae245fa9-8415-5f23-f0c7-a4f95680bc3a@broadcom.com> (raw)
In-Reply-To: <1492505735.2472.3.camel@sipsolutions.net>
On 4/18/2017 10:55 AM, Johannes Berg wrote:
> On Tue, 2017-04-18 at 10:53 +0200, Johannes Berg wrote:
>> Hi Arend,
>>
>> Overall this looks good, and I've almost applied it - but I have a
>> question on this patch.
>>
>> You have this list:
>>
>>> + struct list_head sched_scan_req_list;
>>> struct cfg80211_sched_scan_request __rcu *sched_scan_req;
>>
>> but you kept this. In fact, it's even still *used*. I don't
>> understand
>> that part.
>>
>> Also, you used RCU primitives for the new list, but you never
>> actually
>> used them - except in one place (in nl80211_stop_sched_scan) where
>> it's
>> actually not needed at all and the _rcu should be removed (since it
>> holds the lock)
>>
>> What's up with that?
>
> Actually, I think I see what's up - you simply forgot to remove the
> sched_scan_req member, and then didn't realize that it was still used
> in nl80211_netlink_notify(), and that's the place that *does* need the
> RCU stuff.
Yes. Sorry for screwing it up. Will rebase the series and fix it.
Regards,
Arend
next prev parent reply other threads:[~2017-04-18 19:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 12:06 [PATCH V2 00/10] cfg80211: support multiple scheduled scans Arend van Spriel
2017-04-13 12:06 ` [PATCH V2 01/10] nl80211: add request id in scheduled scan event messages Arend van Spriel
2017-04-18 8:56 ` Johannes Berg
2017-04-13 12:06 ` [PATCH V2 02/10] nl80211: allow multiple active scheduled scan requests Arend van Spriel
2017-04-18 8:53 ` Johannes Berg
2017-04-18 8:55 ` Johannes Berg
2017-04-18 19:14 ` Arend van Spriel [this message]
2017-04-13 12:06 ` [PATCH V2 03/10] nl80211: add support for BSSIDs in scheduled scan matchsets Arend van Spriel
2017-04-13 12:06 ` [PATCH V2 04/10] cfg80211: add request id parameter to .sched_scan_stop() signature Arend van Spriel
2017-04-13 12:06 ` [PATCH V2 05/10] cfg80211: add request id to cfg80211_sched_scan_*() api Arend van Spriel
2017-04-13 12:06 ` [PATCH V2 06/10] brcmfmac: add firmware feature detection for gscan feature Arend van Spriel
2017-04-13 12:06 ` [PATCH V2 07/10] brcmfmac: move scheduled scan wiphy param setting to pno module Arend van Spriel
2017-04-13 12:06 ` [PATCH V2 08/10] brcmfmac: add support multi-scheduled scan Arend van Spriel
2017-04-13 12:06 ` [PATCH V2 09/10] brcmfmac: add mutex to protect pno requests Arend van Spriel
2017-04-13 12:06 ` [PATCH V2 10/10] brcmfmac: add scheduled scan support for specified BSSIDs Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae245fa9-8415-5f23-f0c7-a4f95680bc3a@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.