From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A259BC433EF for ; Sun, 28 Nov 2021 15:59:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358126AbhK1QDC convert rfc822-to-8bit (ORCPT ); Sun, 28 Nov 2021 11:03:02 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:35714 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S244386AbhK1QA4 (ORCPT ); Sun, 28 Nov 2021 11:00:56 -0500 X-UUID: a06df0059a734746a1cc6e4dd9453dbf-20211128 X-UUID: a06df0059a734746a1cc6e4dd9453dbf-20211128 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 283879108; Sun, 28 Nov 2021 23:57:35 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Sun, 28 Nov 2021 23:57:34 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sun, 28 Nov 2021 23:57:33 +0800 Message-ID: From: Jason-JH Lin To: Tzung-Bi Shih CC: Chun-Kuang Hu , "; Philipp Zabel" , "; Matthias Brugger" , "; Jassi Brar" , "; David Airlie" , "; Daniel Vetter" , "; dri-devel@lists.freedesktop.org; linux-mediatek@lists.infradead.org; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; hsinyi@chromium.org; fshao@chromium.org; Nancy Lin =?UTF-8?Q?=28=E6=9E=97=E6=AC=A3=E8=9E=A2=29?=" , "; Singo Chang =?UTF-8?Q?=28=E5=BC=B5=E8=88=88=E5=9C=8B=29?=" In-Reply-To: References: <20211117064158.27451-1-jason-jh.lin@mediatek.com> <20211117064158.27451-4-jason-jh.lin@mediatek.com> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Subject: Re: FW: [PATCH 3/3] drm/mediatek: add devlink to cmdq dev Date: Sun, 28 Nov 2021 23:57:33 +0800 X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 Content-Transfer-Encoding: 8BIT X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tzung-Bi, Thanks for the reviews. > From: Linux-mediatek On > Behalf Of Tzung-Bi Shih > Sent: Thursday, November 18, 2021 1:55 PM > To: Jason-JH Lin (林睿祥) > Cc: Chun-Kuang Hu ; Philipp Zabel < > p.zabel@pengutronix.de>; Matthias Brugger ; > Jassi Brar ; David Airlie >; Daniel Vetter ; dri-devel@lists.freedesktop.org; > linux-mediatek@lists.infradead.org; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > hsinyi@chromium.org; fshao@chromium.org; Nancy Lin (林欣螢) < > Nancy.Lin@mediatek.com>; Singo Chang (張興國) > Subject: Re: [PATCH 3/3] drm/mediatek: add devlink to cmdq dev > > On Wed, Nov 17, 2021 at 02:41:58PM +0800, jason-jh.lin wrote: > > @@ -158,6 +159,7 @@ static void mtk_drm_crtc_destroy(struct > > drm_crtc *crtc) > > mtk_drm_cmdq_pkt_destroy(&mtk_crtc->cmdq_handle); > > > > if (mtk_crtc->cmdq_client.chan) { > > + device_link_remove(mtk_crtc->drm_dev, mtk_crtc- > > >cmdq_client.chan->mbox->dev); > > mbox_free_channel(mtk_crtc->cmdq_client.chan); > > mtk_crtc->cmdq_client.chan = NULL; > > } > > [...] > > @@ -956,6 +959,16 @@ int mtk_drm_crtc_create(struct drm_device > > *drm_dev, > > } > > > > if (mtk_crtc->cmdq_client.chan) { > > + struct device_link *link; > > + > > + /* add devlink to cmdq dev to make sure suspend/resume > > order is correct */ > > + link = device_link_add(dev, mtk_crtc->cmdq_client.chan- > > >mbox->dev, > > + DL_FLAG_PM_RUNTIME | > > DL_FLAG_STATELESS); > > + if (!link) { > > + dev_err(dev, "Unable to link dev=%s\n", > > + dev_name(mtk_crtc->cmdq_client.chan- > > >mbox->dev)); > > + } > > + > > If device_link_add() failed, doesn't mtk_drm_crtc_create() need to > return an error and exit? OK, I'll add the return error at the next verion. > > OTOH, if device_link_add() failed, won't it bring any side effects to > call device_link_remove()? > Because device_link_remove() will find the device_link of supplier and consumer, then delete the device_link between them. If device_link_add() failed, supplier and consumer won't create the device_link. So calling device_link_remove() won't do anything without deive_link and won't bring any side effects. Regards, Jason-JH.Lin > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!125dmOZ7xCLkwbIrzZf1VqVLQBbdT4RFHoMjR38U1GeCxaTM6xvvB-mSr7sTc6BuY5IH$ > -- Jason-JH Lin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79B6FC433EF for ; Sun, 28 Nov 2021 16:04:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357583AbhK1QH5 convert rfc822-to-8bit (ORCPT ); Sun, 28 Nov 2021 11:07:57 -0500 Received: from mailgw01.mediatek.com ([60.244.123.138]:35056 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S245397AbhK1QFz (ORCPT ); Sun, 28 Nov 2021 11:05:55 -0500 X-UUID: 81bda1ccb0b4480cb9210040dba67a6d-20211129 X-UUID: 81bda1ccb0b4480cb9210040dba67a6d-20211129 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1868573853; Mon, 29 Nov 2021 00:02:34 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 29 Nov 2021 00:02:33 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 29 Nov 2021 00:02:33 +0800 Message-ID: From: Jason-JH Lin To: Tzung-Bi Shih CC: Chun-Kuang Hu , "; Philipp Zabel" , "; Matthias Brugger" , "; Jassi Brar" , "; David Airlie" , "; Daniel Vetter" , "; dri-devel@lists.freedesktop.org; linux-mediatek@lists.infradead.org; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; hsinyi@chromium.org; fshao@chromium.org; Nancy Lin =?UTF-8?Q?=28=E6=9E=97=E6=AC=A3=E8=9E=A2=29?=" , "; Singo Chang =?UTF-8?Q?=28=E5=BC=B5=E8=88=88=E5=9C=8B=29?=" In-Reply-To: References: <20211117064158.27451-1-jason-jh.lin@mediatek.com> <20211117064158.27451-4-jason-jh.lin@mediatek.com> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Subject: Re: FW: [PATCH 3/3] drm/mediatek: add devlink to cmdq dev Date: Mon, 29 Nov 2021 00:02:33 +0800 X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 Content-Transfer-Encoding: 8BIT X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Message-ID: <20211128160233.Mbw4EN7z73rjlh-pGifinFLeuHvcDt_u7-9Ju8viKfI@z> Hi Tzung-Bi, Thanks for the reviews. > From: Linux-mediatek On > Behalf Of Tzung-Bi Shih > Sent: Thursday, November 18, 2021 1:55 PM > To: Jason-JH Lin (林睿祥) > Cc: Chun-Kuang Hu ; Philipp Zabel < > p.zabel@pengutronix.de>; Matthias Brugger ; > Jassi Brar ; David Airlie >; Daniel Vetter ; dri-devel@lists.freedesktop.org; > linux-mediatek@lists.infradead.org; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > hsinyi@chromium.org; fshao@chromium.org; Nancy Lin (林欣螢) < > Nancy.Lin@mediatek.com>; Singo Chang (張興國) > Subject: Re: [PATCH 3/3] drm/mediatek: add devlink to cmdq dev > > On Wed, Nov 17, 2021 at 02:41:58PM +0800, jason-jh.lin wrote: > > @@ -158,6 +159,7 @@ static void mtk_drm_crtc_destroy(struct > > drm_crtc *crtc) > > mtk_drm_cmdq_pkt_destroy(&mtk_crtc->cmdq_handle); > > > > if (mtk_crtc->cmdq_client.chan) { > > + device_link_remove(mtk_crtc->drm_dev, mtk_crtc- > > >cmdq_client.chan->mbox->dev); > > mbox_free_channel(mtk_crtc->cmdq_client.chan); > > mtk_crtc->cmdq_client.chan = NULL; > > } > > [...] > > @@ -956,6 +959,16 @@ int mtk_drm_crtc_create(struct drm_device > > *drm_dev, > > } > > > > if (mtk_crtc->cmdq_client.chan) { > > + struct device_link *link; > > + > > + /* add devlink to cmdq dev to make sure suspend/resume > > order is correct */ > > + link = device_link_add(dev, mtk_crtc->cmdq_client.chan- > > >mbox->dev, > > + DL_FLAG_PM_RUNTIME | > > DL_FLAG_STATELESS); > > + if (!link) { > > + dev_err(dev, "Unable to link dev=%s\n", > > + dev_name(mtk_crtc->cmdq_client.chan- > > >mbox->dev)); > > + } > > + > > If device_link_add() failed, doesn't mtk_drm_crtc_create() need to > return an error and exit? OK, I'll add the return error at the next verion. > > OTOH, if device_link_add() failed, won't it bring any side effects to > call device_link_remove()? > Because device_link_remove() will find the device_link of supplier and consumer, then delete the device_link between them. If device_link_add() failed, supplier and consumer won't create the device_link. So calling device_link_remove() won't do anything without deive_link and won't bring any side effects. Regards, Jason-JH.Lin > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!125dmOZ7xCLkwbIrzZf1VqVLQBbdT4RFHoMjR38U1GeCxaTM6xvvB-mSr7sTc6BuY5IH$ > -- Jason-JH Lin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4980C433F5 for ; Sun, 28 Nov 2021 15:57:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:Resent-Cc:Resent-From:Subject: MIME-Version:References:In-Reply-To:CC:To:From:Message-ID:Reply-To:Content-ID :Content-Description:Resent-Date:Resent-Sender:Resent-To:Resent-Message-ID: List-Owner; bh=9PhvaRJHaTH3OcOGBKGAtHdwIE+o4LG82OJR0xWAQYA=; b=4C5AKnHefHt1s6 wFVcHGuV3ElAV1O5ET5EzOYC+pKZ0/r1Rd4c9Pw2Td7kjbTs+AXC5vri17hCXhQAYCC5xtd5p1F5G dsoIrXHDz0EUJElXvhFfJDxi/cge4LX39GuKUIAK95X3M8aWTbGcvm+QrHpPxDpiYwpQnfiQ7T70Z 6G4fs2N5PqazmGAfS6WOdDsG2UaiO1Ylh4IKBrX3PS00lu12vTEhZGUEqcMmNdCOV2f3pM3BJzqGE l4c6uMo0oCG/dM1pUJA3iclimv3vlKg7Y1Kq2S4OqBYihw6frd0flbiurTkrsD2Nudwej3xE0+P/q DvvgG3YXoVEdDPMcl3iQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrMYg-00G7Hd-KH; Sun, 28 Nov 2021 15:57:42 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrMYd-00G7Go-8X; Sun, 28 Nov 2021 15:57:41 +0000 X-UUID: 698d88a339c34e279fc47dc5d03bf1d2-20211128 X-UUID: 698d88a339c34e279fc47dc5d03bf1d2-20211128 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 538637904; Sun, 28 Nov 2021 08:57:36 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 28 Nov 2021 07:57:35 -0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Sun, 28 Nov 2021 23:57:34 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sun, 28 Nov 2021 23:57:33 +0800 Message-ID: From: Jason-JH Lin To: Tzung-Bi Shih CC: Chun-Kuang Hu , "; Philipp Zabel" , "; Matthias Brugger" , "; Jassi Brar" , "; David Airlie" , "; Daniel Vetter" , "; dri-devel@lists.freedesktop.org; linux-mediatek@lists.infradead.org; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; hsinyi@chromium.org; fshao@chromium.org; Nancy Lin =?UTF-8?Q?=28=E6=9E=97=E6=AC=A3=E8=9E=A2=29?=" , "; Singo Chang =?UTF-8?Q?=28=E5=BC=B5=E8=88=88=E5=9C=8B=29?=" In-Reply-To: References: <20211117064158.27451-1-jason-jh.lin@mediatek.com> <20211117064158.27451-4-jason-jh.lin@mediatek.com> MIME-Version: 1.0 Subject: Re: FW: [PATCH 3/3] drm/mediatek: add devlink to cmdq dev Resent-From: Jason-JH Lin Resent-Cc: DRI Development , "moderated list:ARM/Mediatek SoC support" , "Linux ARM" , linux-kernel , Hsin-Yi Wang , "Fei Shao" Date: Sun, 28 Nov 2021 23:57:33 +0800 X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211128_075739_335111_296E7E7C X-CRM114-Status: GOOD ( 18.79 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org SGkgVHp1bmctQmksCgpUaGFua3MgZm9yIHRoZSByZXZpZXdzLgoKPiBGcm9tOiBMaW51eC1tZWRp YXRlayA8bGludXgtbWVkaWF0ZWstYm91bmNlc0BsaXN0cy5pbmZyYWRlYWQub3JnPiBPbgo+IEJl aGFsZiBPZiBUenVuZy1CaSBTaGloCj4gU2VudDogVGh1cnNkYXksIE5vdmVtYmVyIDE4LCAyMDIx IDE6NTUgUE0KPiBUbzogSmFzb24tSkggTGluICjmnpfnnb/npaUpIDxKYXNvbi1KSC5MaW5AbWVk aWF0ZWsuY29tPgo+IENjOiBDaHVuLUt1YW5nIEh1IDxjaHVua3VhbmcuaHVAa2VybmVsLm9yZz47 IFBoaWxpcHAgWmFiZWwgPAo+IHAuemFiZWxAcGVuZ3V0cm9uaXguZGU+OyBNYXR0aGlhcyBCcnVn Z2VyIDxtYXR0aGlhcy5iZ2dAZ21haWwuY29tPjsKPiBKYXNzaSBCcmFyIDxqYXNzaXNpbmdoYnJh ckBnbWFpbC5jb20+OyBEYXZpZCBBaXJsaWUgPGFpcmxpZWRAbGludXguaWUKPiA+OyBEYW5pZWwg VmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+OyBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn OyAKPiBsaW51eC1tZWRpYXRla0BsaXN0cy5pbmZyYWRlYWQub3JnOyAKPiBsaW51eC1hcm0ta2Vy bmVsQGxpc3RzLmluZnJhZGVhZC5vcmc7IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7IAo+ IGhzaW55aUBjaHJvbWl1bS5vcmc7IGZzaGFvQGNocm9taXVtLm9yZzsgTmFuY3kgTGluICjmnpfm rKPonqIpIDwKPiBOYW5jeS5MaW5AbWVkaWF0ZWsuY29tPjsgU2luZ28gQ2hhbmcgKOW8teiIiOWc iykgPFNpbmdvLkNoYW5nQG1lZGlhdGVrLmNvbT4KPiBTdWJqZWN0OiBSZTogW1BBVENIIDMvM10g ZHJtL21lZGlhdGVrOiBhZGQgZGV2bGluayB0byBjbWRxIGRldgo+IAo+IE9uIFdlZCwgTm92IDE3 LCAyMDIxIGF0IDAyOjQxOjU4UE0gKzA4MDAsIGphc29uLWpoLmxpbiB3cm90ZToKPiA+IEBAIC0x NTgsNiArMTU5LDcgQEAgc3RhdGljIHZvaWQgbXRrX2RybV9jcnRjX2Rlc3Ryb3koc3RydWN0Cj4g PiBkcm1fY3J0YyAqY3J0YykKPiA+ICAJbXRrX2RybV9jbWRxX3BrdF9kZXN0cm95KCZtdGtfY3J0 Yy0+Y21kcV9oYW5kbGUpOwo+ID4gIAo+ID4gIAlpZiAobXRrX2NydGMtPmNtZHFfY2xpZW50LmNo YW4pIHsKPiA+ICsJCWRldmljZV9saW5rX3JlbW92ZShtdGtfY3J0Yy0+ZHJtX2RldiwgbXRrX2Ny dGMtCj4gPiA+Y21kcV9jbGllbnQuY2hhbi0+bWJveC0+ZGV2KTsKPiA+ICAJCW1ib3hfZnJlZV9j aGFubmVsKG10a19jcnRjLT5jbWRxX2NsaWVudC5jaGFuKTsKPiA+ICAJCW10a19jcnRjLT5jbWRx X2NsaWVudC5jaGFuID0gTlVMTDsKPiA+ICAJfQo+IAo+IFsuLi5dCj4gPiBAQCAtOTU2LDYgKzk1 OSwxNiBAQCBpbnQgbXRrX2RybV9jcnRjX2NyZWF0ZShzdHJ1Y3QgZHJtX2RldmljZQo+ID4gKmRy bV9kZXYsCj4gPiAgCX0KPiA+ICAKPiA+ICAJaWYgKG10a19jcnRjLT5jbWRxX2NsaWVudC5jaGFu KSB7Cj4gPiArCQlzdHJ1Y3QgZGV2aWNlX2xpbmsgKmxpbms7Cj4gPiArCj4gPiArCQkvKiBhZGQg ZGV2bGluayB0byBjbWRxIGRldiB0byBtYWtlIHN1cmUgc3VzcGVuZC9yZXN1bWUKPiA+IG9yZGVy IGlzIGNvcnJlY3QgKi8KPiA+ICsJCWxpbmsgPSBkZXZpY2VfbGlua19hZGQoZGV2LCBtdGtfY3J0 Yy0+Y21kcV9jbGllbnQuY2hhbi0KPiA+ID5tYm94LT5kZXYsCj4gPiArCQkJCSAgICAgICBETF9G TEFHX1BNX1JVTlRJTUUgfAo+ID4gRExfRkxBR19TVEFURUxFU1MpOwo+ID4gKwkJaWYgKCFsaW5r KSB7Cj4gPiArCQkJZGV2X2VycihkZXYsICJVbmFibGUgdG8gbGluayBkZXY9JXNcbiIsCj4gPiAr CQkJCWRldl9uYW1lKG10a19jcnRjLT5jbWRxX2NsaWVudC5jaGFuLQo+ID4gPm1ib3gtPmRldikp Owo+ID4gKwkJfQo+ID4gKwo+IAo+IElmIGRldmljZV9saW5rX2FkZCgpIGZhaWxlZCwgZG9lc24n dCBtdGtfZHJtX2NydGNfY3JlYXRlKCkgbmVlZCB0bwo+IHJldHVybiBhbiBlcnJvciBhbmQgZXhp dD8KCk9LLCBJJ2xsIGFkZCB0aGUgcmV0dXJuIGVycm9yIGF0IHRoZSBuZXh0IHZlcmlvbi4KPiAK PiBPVE9ILCBpZiBkZXZpY2VfbGlua19hZGQoKSBmYWlsZWQsIHdvbid0IGl0IGJyaW5nIGFueSBz aWRlIGVmZmVjdHMgdG8KPiBjYWxsIGRldmljZV9saW5rX3JlbW92ZSgpPwo+IAoKQmVjYXVzZSBk ZXZpY2VfbGlua19yZW1vdmUoKSB3aWxsIGZpbmQgdGhlIGRldmljZV9saW5rIG9mIHN1cHBsaWVy IGFuZApjb25zdW1lciwgdGhlbiBkZWxldGUgdGhlIGRldmljZV9saW5rIGJldHdlZW4gdGhlbS4K SWYgZGV2aWNlX2xpbmtfYWRkKCkgZmFpbGVkLCBzdXBwbGllciBhbmQgY29uc3VtZXIgd29uJ3Qg Y3JlYXRlIHRoZQpkZXZpY2VfbGluay4KU28gY2FsbGluZyBkZXZpY2VfbGlua19yZW1vdmUoKSB3 b24ndCBkbyBhbnl0aGluZyB3aXRob3V0IGRlaXZlX2xpbmsKYW5kIHdvbid0IGJyaW5nIGFueSBz aWRlIGVmZmVjdHMuCgpSZWdhcmRzLApKYXNvbi1KSC5MaW4KPiBfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IExpbnV4LW1lZGlhdGVrIG1haWxpbmcgbGlz dAo+IExpbnV4LW1lZGlhdGVrQGxpc3RzLmluZnJhZGVhZC5vcmcKPiAKaHR0cHM6Ly91cmxkZWZl bnNlLmNvbS92My9fX2h0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtbWVkaWF0ZWtfXzshIUNUUk5LQTl3TWcwQVJidyExMjVkbU9aN3hDTGt3YklyelpmMVZx VkxRQmJkVDRSRkhvTWpSMzhVMUdlQ3hhVE02eHZ2Qi1tU3I3c1RjNkJ1WTVJSCQKPiAgCi0tIApK YXNvbi1KSCBMaW4gPGphc29uLWpoLmxpbkBtZWRpYXRlay5jb20+CgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtbWVkaWF0ZWsgbWFpbGluZyBs aXN0CkxpbnV4LW1lZGlhdGVrQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tZWRpYXRlawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76B76C433F5 for ; Sun, 28 Nov 2021 16:02:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:Resent-Cc:Resent-From:Subject: MIME-Version:References:In-Reply-To:CC:To:From:Message-ID:Reply-To:Content-ID :Content-Description:Resent-Date:Resent-Sender:Resent-To:Resent-Message-ID: List-Owner; bh=9PhvaRJHaTH3OcOGBKGAtHdwIE+o4LG82OJR0xWAQYA=; b=RBw1i/7X/nCmVN eyfwdnziV1xe5zNb9fD32Rp0iaGfizwLst1p2ESZFtuR8SlDrULHL4foUlO7XJxb5QUBXWYJvJal3 +e+Cvaa28mQ9zcL35tOPLVovkyyy1kj7ZyGsDvxfczElU1bUVjfpyDNkbg7ag/u0adBo5J8izkPp8 dbHUHhbjkzZcmS4AFkVXVN2x20xJGSFKVPsosnEsJb/LSL9oMBcgWi+jews1GM8k6krgfTwrBJsKy hq26C09ywxfru5wiDSpObpxTogavx2vrmFLROZVEL59OswdFSAtl59Si4B5zc3jtymhaHQbX6CvOr ZqEBDRa2jWc97Yuk+z5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrMdU-00G8EE-Rj; Sun, 28 Nov 2021 16:02:40 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrMdR-00G8DL-Pp; Sun, 28 Nov 2021 16:02:39 +0000 X-UUID: cb557e29f8b1489e9005c5435c87c526-20211128 X-UUID: cb557e29f8b1489e9005c5435c87c526-20211128 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1348135641; Sun, 28 Nov 2021 09:02:36 -0700 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 28 Nov 2021 08:02:34 -0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 29 Nov 2021 00:02:33 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 29 Nov 2021 00:02:33 +0800 Message-ID: From: Jason-JH Lin To: Tzung-Bi Shih CC: Chun-Kuang Hu , "; Philipp Zabel" , "; Matthias Brugger" , "; Jassi Brar" , "; David Airlie" , "; Daniel Vetter" , "; dri-devel@lists.freedesktop.org; linux-mediatek@lists.infradead.org; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; hsinyi@chromium.org; fshao@chromium.org; Nancy Lin =?UTF-8?Q?=28=E6=9E=97=E6=AC=A3=E8=9E=A2=29?=" , "; Singo Chang =?UTF-8?Q?=28=E5=BC=B5=E8=88=88=E5=9C=8B=29?=" In-Reply-To: References: <20211117064158.27451-1-jason-jh.lin@mediatek.com> <20211117064158.27451-4-jason-jh.lin@mediatek.com> MIME-Version: 1.0 Subject: Re: FW: [PATCH 3/3] drm/mediatek: add devlink to cmdq dev Resent-From: Jason-JH Lin Resent-Cc: DRI Development , "; moderated list:ARM/Mediatek SoC support" , "; Linux ARM" , "; linux-kernel" , "; Hsin-Yi Wang" , "; Fei Shao" Date: Mon, 29 Nov 2021 00:02:33 +0800 X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211128_080237_853408_EB20F359 X-CRM114-Status: GOOD ( 18.87 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Message-ID: <20211128160233.QhQuvL7ZTowGTmj-3B87PfPAm6lkQurxZ8HPzvd1pCk@z> SGkgVHp1bmctQmksCgpUaGFua3MgZm9yIHRoZSByZXZpZXdzLgoKPiBGcm9tOiBMaW51eC1tZWRp YXRlayA8bGludXgtbWVkaWF0ZWstYm91bmNlc0BsaXN0cy5pbmZyYWRlYWQub3JnPiBPbgo+IEJl aGFsZiBPZiBUenVuZy1CaSBTaGloCj4gU2VudDogVGh1cnNkYXksIE5vdmVtYmVyIDE4LCAyMDIx IDE6NTUgUE0KPiBUbzogSmFzb24tSkggTGluICjmnpfnnb/npaUpIDxKYXNvbi1KSC5MaW5AbWVk aWF0ZWsuY29tPgo+IENjOiBDaHVuLUt1YW5nIEh1IDxjaHVua3VhbmcuaHVAa2VybmVsLm9yZz47 IFBoaWxpcHAgWmFiZWwgPAo+IHAuemFiZWxAcGVuZ3V0cm9uaXguZGU+OyBNYXR0aGlhcyBCcnVn Z2VyIDxtYXR0aGlhcy5iZ2dAZ21haWwuY29tPjsKPiBKYXNzaSBCcmFyIDxqYXNzaXNpbmdoYnJh ckBnbWFpbC5jb20+OyBEYXZpZCBBaXJsaWUgPGFpcmxpZWRAbGludXguaWUKPiA+OyBEYW5pZWwg VmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+OyBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn OyAKPiBsaW51eC1tZWRpYXRla0BsaXN0cy5pbmZyYWRlYWQub3JnOyAKPiBsaW51eC1hcm0ta2Vy bmVsQGxpc3RzLmluZnJhZGVhZC5vcmc7IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7IAo+ IGhzaW55aUBjaHJvbWl1bS5vcmc7IGZzaGFvQGNocm9taXVtLm9yZzsgTmFuY3kgTGluICjmnpfm rKPonqIpIDwKPiBOYW5jeS5MaW5AbWVkaWF0ZWsuY29tPjsgU2luZ28gQ2hhbmcgKOW8teiIiOWc iykgPFNpbmdvLkNoYW5nQG1lZGlhdGVrLmNvbT4KPiBTdWJqZWN0OiBSZTogW1BBVENIIDMvM10g ZHJtL21lZGlhdGVrOiBhZGQgZGV2bGluayB0byBjbWRxIGRldgo+IAo+IE9uIFdlZCwgTm92IDE3 LCAyMDIxIGF0IDAyOjQxOjU4UE0gKzA4MDAsIGphc29uLWpoLmxpbiB3cm90ZToKPiA+IEBAIC0x NTgsNiArMTU5LDcgQEAgc3RhdGljIHZvaWQgbXRrX2RybV9jcnRjX2Rlc3Ryb3koc3RydWN0Cj4g PiBkcm1fY3J0YyAqY3J0YykKPiA+ICAJbXRrX2RybV9jbWRxX3BrdF9kZXN0cm95KCZtdGtfY3J0 Yy0+Y21kcV9oYW5kbGUpOwo+ID4gIAo+ID4gIAlpZiAobXRrX2NydGMtPmNtZHFfY2xpZW50LmNo YW4pIHsKPiA+ICsJCWRldmljZV9saW5rX3JlbW92ZShtdGtfY3J0Yy0+ZHJtX2RldiwgbXRrX2Ny dGMtCj4gPiA+Y21kcV9jbGllbnQuY2hhbi0+bWJveC0+ZGV2KTsKPiA+ICAJCW1ib3hfZnJlZV9j aGFubmVsKG10a19jcnRjLT5jbWRxX2NsaWVudC5jaGFuKTsKPiA+ICAJCW10a19jcnRjLT5jbWRx X2NsaWVudC5jaGFuID0gTlVMTDsKPiA+ICAJfQo+IAo+IFsuLi5dCj4gPiBAQCAtOTU2LDYgKzk1 OSwxNiBAQCBpbnQgbXRrX2RybV9jcnRjX2NyZWF0ZShzdHJ1Y3QgZHJtX2RldmljZQo+ID4gKmRy bV9kZXYsCj4gPiAgCX0KPiA+ICAKPiA+ICAJaWYgKG10a19jcnRjLT5jbWRxX2NsaWVudC5jaGFu KSB7Cj4gPiArCQlzdHJ1Y3QgZGV2aWNlX2xpbmsgKmxpbms7Cj4gPiArCj4gPiArCQkvKiBhZGQg ZGV2bGluayB0byBjbWRxIGRldiB0byBtYWtlIHN1cmUgc3VzcGVuZC9yZXN1bWUKPiA+IG9yZGVy IGlzIGNvcnJlY3QgKi8KPiA+ICsJCWxpbmsgPSBkZXZpY2VfbGlua19hZGQoZGV2LCBtdGtfY3J0 Yy0+Y21kcV9jbGllbnQuY2hhbi0KPiA+ID5tYm94LT5kZXYsCj4gPiArCQkJCSAgICAgICBETF9G TEFHX1BNX1JVTlRJTUUgfAo+ID4gRExfRkxBR19TVEFURUxFU1MpOwo+ID4gKwkJaWYgKCFsaW5r KSB7Cj4gPiArCQkJZGV2X2VycihkZXYsICJVbmFibGUgdG8gbGluayBkZXY9JXNcbiIsCj4gPiAr CQkJCWRldl9uYW1lKG10a19jcnRjLT5jbWRxX2NsaWVudC5jaGFuLQo+ID4gPm1ib3gtPmRldikp Owo+ID4gKwkJfQo+ID4gKwo+IAo+IElmIGRldmljZV9saW5rX2FkZCgpIGZhaWxlZCwgZG9lc24n dCBtdGtfZHJtX2NydGNfY3JlYXRlKCkgbmVlZCB0bwo+IHJldHVybiBhbiBlcnJvciBhbmQgZXhp dD8KCk9LLCBJJ2xsIGFkZCB0aGUgcmV0dXJuIGVycm9yIGF0IHRoZSBuZXh0IHZlcmlvbi4KPiAK PiBPVE9ILCBpZiBkZXZpY2VfbGlua19hZGQoKSBmYWlsZWQsIHdvbid0IGl0IGJyaW5nIGFueSBz aWRlIGVmZmVjdHMgdG8KPiBjYWxsIGRldmljZV9saW5rX3JlbW92ZSgpPwo+IAoKQmVjYXVzZSBk ZXZpY2VfbGlua19yZW1vdmUoKSB3aWxsIGZpbmQgdGhlIGRldmljZV9saW5rIG9mIHN1cHBsaWVy IGFuZApjb25zdW1lciwgdGhlbiBkZWxldGUgdGhlIGRldmljZV9saW5rIGJldHdlZW4gdGhlbS4K SWYgZGV2aWNlX2xpbmtfYWRkKCkgZmFpbGVkLCBzdXBwbGllciBhbmQgY29uc3VtZXIgd29uJ3Qg Y3JlYXRlIHRoZQpkZXZpY2VfbGluay4KU28gY2FsbGluZyBkZXZpY2VfbGlua19yZW1vdmUoKSB3 b24ndCBkbyBhbnl0aGluZyB3aXRob3V0IGRlaXZlX2xpbmsKYW5kIHdvbid0IGJyaW5nIGFueSBz aWRlIGVmZmVjdHMuCgpSZWdhcmRzLApKYXNvbi1KSC5MaW4KPiBfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IExpbnV4LW1lZGlhdGVrIG1haWxpbmcgbGlz dAo+IExpbnV4LW1lZGlhdGVrQGxpc3RzLmluZnJhZGVhZC5vcmcKPiAKaHR0cHM6Ly91cmxkZWZl bnNlLmNvbS92My9fX2h0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtbWVkaWF0ZWtfXzshIUNUUk5LQTl3TWcwQVJidyExMjVkbU9aN3hDTGt3YklyelpmMVZx VkxRQmJkVDRSRkhvTWpSMzhVMUdlQ3hhVE02eHZ2Qi1tU3I3c1RjNkJ1WTVJSCQKPiAgCi0tIApK YXNvbi1KSCBMaW4gPGphc29uLWpoLmxpbkBtZWRpYXRlay5jb20+CgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtbWVkaWF0ZWsgbWFpbGluZyBs aXN0CkxpbnV4LW1lZGlhdGVrQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tZWRpYXRlawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F13DC433EF for ; Sun, 28 Nov 2021 15:59:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:Resent-Cc:Resent-From:Subject: MIME-Version:References:In-Reply-To:CC:To:From:Message-ID:Reply-To:Content-ID :Content-Description:Resent-Date:Resent-Sender:Resent-To:Resent-Message-ID: List-Owner; bh=7GJOjVlpkiTP1A43Md2TCSr/9dOIQjGW8uK9wb94eSk=; b=u+ZyvXS0w7uQz9 KcbIMIggA7A8hYUBOTK1AA7uDpqjgrqdiq2gyr77t5lpHVlNSKk/1ctvf70JyFmg7uAkndR5/L2qg RvcUXrx5VDM4dRl33z0If1ayr2/w79GHFjO6SOxtfW+obrJuR/pf64yGV7m9JLi0+SpNS2+spkoNr +rnA9kJyMrlk/CItNnjTPnT1OrnwIg177dlAk2HiK6kjjCA76gGNm9bnBMyhxiyUNfXh9IqFKZXWg BCvMestolUWWvc1a83RpMRmAbuJAB3hjcGROvu/unZPnum4DnK+qTQLRh1rT02ngryFknn6KnNcCt 5QZIYg5ziyRK4UDHMLLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrMYi-00G7Hu-Hu; Sun, 28 Nov 2021 15:57:44 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrMYd-00G7Go-8X; Sun, 28 Nov 2021 15:57:41 +0000 X-UUID: 698d88a339c34e279fc47dc5d03bf1d2-20211128 X-UUID: 698d88a339c34e279fc47dc5d03bf1d2-20211128 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 538637904; Sun, 28 Nov 2021 08:57:36 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 28 Nov 2021 07:57:35 -0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Sun, 28 Nov 2021 23:57:34 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sun, 28 Nov 2021 23:57:33 +0800 Message-ID: From: Jason-JH Lin To: Tzung-Bi Shih CC: Chun-Kuang Hu , "; Philipp Zabel" , "; Matthias Brugger" , "; Jassi Brar" , "; David Airlie" , "; Daniel Vetter" , "; dri-devel@lists.freedesktop.org; linux-mediatek@lists.infradead.org; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; hsinyi@chromium.org; fshao@chromium.org; Nancy Lin =?UTF-8?Q?=28=E6=9E=97=E6=AC=A3=E8=9E=A2=29?=" , "; Singo Chang =?UTF-8?Q?=28=E5=BC=B5=E8=88=88=E5=9C=8B=29?=" In-Reply-To: References: <20211117064158.27451-1-jason-jh.lin@mediatek.com> <20211117064158.27451-4-jason-jh.lin@mediatek.com> MIME-Version: 1.0 Subject: Re: FW: [PATCH 3/3] drm/mediatek: add devlink to cmdq dev Resent-From: Jason-JH Lin Resent-Cc: DRI Development , "moderated list:ARM/Mediatek SoC support" , "Linux ARM" , linux-kernel , Hsin-Yi Wang , "Fei Shao" Date: Sun, 28 Nov 2021 23:57:33 +0800 X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211128_075739_335111_296E7E7C X-CRM114-Status: GOOD ( 18.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgVHp1bmctQmksCgpUaGFua3MgZm9yIHRoZSByZXZpZXdzLgoKPiBGcm9tOiBMaW51eC1tZWRp YXRlayA8bGludXgtbWVkaWF0ZWstYm91bmNlc0BsaXN0cy5pbmZyYWRlYWQub3JnPiBPbgo+IEJl aGFsZiBPZiBUenVuZy1CaSBTaGloCj4gU2VudDogVGh1cnNkYXksIE5vdmVtYmVyIDE4LCAyMDIx IDE6NTUgUE0KPiBUbzogSmFzb24tSkggTGluICjmnpfnnb/npaUpIDxKYXNvbi1KSC5MaW5AbWVk aWF0ZWsuY29tPgo+IENjOiBDaHVuLUt1YW5nIEh1IDxjaHVua3VhbmcuaHVAa2VybmVsLm9yZz47 IFBoaWxpcHAgWmFiZWwgPAo+IHAuemFiZWxAcGVuZ3V0cm9uaXguZGU+OyBNYXR0aGlhcyBCcnVn Z2VyIDxtYXR0aGlhcy5iZ2dAZ21haWwuY29tPjsKPiBKYXNzaSBCcmFyIDxqYXNzaXNpbmdoYnJh ckBnbWFpbC5jb20+OyBEYXZpZCBBaXJsaWUgPGFpcmxpZWRAbGludXguaWUKPiA+OyBEYW5pZWwg VmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+OyBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn OyAKPiBsaW51eC1tZWRpYXRla0BsaXN0cy5pbmZyYWRlYWQub3JnOyAKPiBsaW51eC1hcm0ta2Vy bmVsQGxpc3RzLmluZnJhZGVhZC5vcmc7IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7IAo+ IGhzaW55aUBjaHJvbWl1bS5vcmc7IGZzaGFvQGNocm9taXVtLm9yZzsgTmFuY3kgTGluICjmnpfm rKPonqIpIDwKPiBOYW5jeS5MaW5AbWVkaWF0ZWsuY29tPjsgU2luZ28gQ2hhbmcgKOW8teiIiOWc iykgPFNpbmdvLkNoYW5nQG1lZGlhdGVrLmNvbT4KPiBTdWJqZWN0OiBSZTogW1BBVENIIDMvM10g ZHJtL21lZGlhdGVrOiBhZGQgZGV2bGluayB0byBjbWRxIGRldgo+IAo+IE9uIFdlZCwgTm92IDE3 LCAyMDIxIGF0IDAyOjQxOjU4UE0gKzA4MDAsIGphc29uLWpoLmxpbiB3cm90ZToKPiA+IEBAIC0x NTgsNiArMTU5LDcgQEAgc3RhdGljIHZvaWQgbXRrX2RybV9jcnRjX2Rlc3Ryb3koc3RydWN0Cj4g PiBkcm1fY3J0YyAqY3J0YykKPiA+ICAJbXRrX2RybV9jbWRxX3BrdF9kZXN0cm95KCZtdGtfY3J0 Yy0+Y21kcV9oYW5kbGUpOwo+ID4gIAo+ID4gIAlpZiAobXRrX2NydGMtPmNtZHFfY2xpZW50LmNo YW4pIHsKPiA+ICsJCWRldmljZV9saW5rX3JlbW92ZShtdGtfY3J0Yy0+ZHJtX2RldiwgbXRrX2Ny dGMtCj4gPiA+Y21kcV9jbGllbnQuY2hhbi0+bWJveC0+ZGV2KTsKPiA+ICAJCW1ib3hfZnJlZV9j aGFubmVsKG10a19jcnRjLT5jbWRxX2NsaWVudC5jaGFuKTsKPiA+ICAJCW10a19jcnRjLT5jbWRx X2NsaWVudC5jaGFuID0gTlVMTDsKPiA+ICAJfQo+IAo+IFsuLi5dCj4gPiBAQCAtOTU2LDYgKzk1 OSwxNiBAQCBpbnQgbXRrX2RybV9jcnRjX2NyZWF0ZShzdHJ1Y3QgZHJtX2RldmljZQo+ID4gKmRy bV9kZXYsCj4gPiAgCX0KPiA+ICAKPiA+ICAJaWYgKG10a19jcnRjLT5jbWRxX2NsaWVudC5jaGFu KSB7Cj4gPiArCQlzdHJ1Y3QgZGV2aWNlX2xpbmsgKmxpbms7Cj4gPiArCj4gPiArCQkvKiBhZGQg ZGV2bGluayB0byBjbWRxIGRldiB0byBtYWtlIHN1cmUgc3VzcGVuZC9yZXN1bWUKPiA+IG9yZGVy IGlzIGNvcnJlY3QgKi8KPiA+ICsJCWxpbmsgPSBkZXZpY2VfbGlua19hZGQoZGV2LCBtdGtfY3J0 Yy0+Y21kcV9jbGllbnQuY2hhbi0KPiA+ID5tYm94LT5kZXYsCj4gPiArCQkJCSAgICAgICBETF9G TEFHX1BNX1JVTlRJTUUgfAo+ID4gRExfRkxBR19TVEFURUxFU1MpOwo+ID4gKwkJaWYgKCFsaW5r KSB7Cj4gPiArCQkJZGV2X2VycihkZXYsICJVbmFibGUgdG8gbGluayBkZXY9JXNcbiIsCj4gPiAr CQkJCWRldl9uYW1lKG10a19jcnRjLT5jbWRxX2NsaWVudC5jaGFuLQo+ID4gPm1ib3gtPmRldikp Owo+ID4gKwkJfQo+ID4gKwo+IAo+IElmIGRldmljZV9saW5rX2FkZCgpIGZhaWxlZCwgZG9lc24n dCBtdGtfZHJtX2NydGNfY3JlYXRlKCkgbmVlZCB0bwo+IHJldHVybiBhbiBlcnJvciBhbmQgZXhp dD8KCk9LLCBJJ2xsIGFkZCB0aGUgcmV0dXJuIGVycm9yIGF0IHRoZSBuZXh0IHZlcmlvbi4KPiAK PiBPVE9ILCBpZiBkZXZpY2VfbGlua19hZGQoKSBmYWlsZWQsIHdvbid0IGl0IGJyaW5nIGFueSBz aWRlIGVmZmVjdHMgdG8KPiBjYWxsIGRldmljZV9saW5rX3JlbW92ZSgpPwo+IAoKQmVjYXVzZSBk ZXZpY2VfbGlua19yZW1vdmUoKSB3aWxsIGZpbmQgdGhlIGRldmljZV9saW5rIG9mIHN1cHBsaWVy IGFuZApjb25zdW1lciwgdGhlbiBkZWxldGUgdGhlIGRldmljZV9saW5rIGJldHdlZW4gdGhlbS4K SWYgZGV2aWNlX2xpbmtfYWRkKCkgZmFpbGVkLCBzdXBwbGllciBhbmQgY29uc3VtZXIgd29uJ3Qg Y3JlYXRlIHRoZQpkZXZpY2VfbGluay4KU28gY2FsbGluZyBkZXZpY2VfbGlua19yZW1vdmUoKSB3 b24ndCBkbyBhbnl0aGluZyB3aXRob3V0IGRlaXZlX2xpbmsKYW5kIHdvbid0IGJyaW5nIGFueSBz aWRlIGVmZmVjdHMuCgpSZWdhcmRzLApKYXNvbi1KSC5MaW4KPiBfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IExpbnV4LW1lZGlhdGVrIG1haWxpbmcgbGlz dAo+IExpbnV4LW1lZGlhdGVrQGxpc3RzLmluZnJhZGVhZC5vcmcKPiAKaHR0cHM6Ly91cmxkZWZl bnNlLmNvbS92My9fX2h0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtbWVkaWF0ZWtfXzshIUNUUk5LQTl3TWcwQVJidyExMjVkbU9aN3hDTGt3YklyelpmMVZx VkxRQmJkVDRSRkhvTWpSMzhVMUdlQ3hhVE02eHZ2Qi1tU3I3c1RjNkJ1WTVJSCQKPiAgCi0tIApK YXNvbi1KSCBMaW4gPGphc29uLWpoLmxpbkBtZWRpYXRlay5jb20+CgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E980C433EF for ; Sun, 28 Nov 2021 16:04:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:Resent-Cc:Resent-From:Subject: MIME-Version:References:In-Reply-To:CC:To:From:Message-ID:Reply-To:Content-ID :Content-Description:Resent-Date:Resent-Sender:Resent-To:Resent-Message-ID: List-Owner; bh=7GJOjVlpkiTP1A43Md2TCSr/9dOIQjGW8uK9wb94eSk=; b=XXp1R2ItWDPmlE U5IE1vilSw66PZtUyJFiz1MDStvtRXc8qJvGsgLNJUy3YkIVehEUNoCNKNzTb7Jx7jycsOQzfJ1fZ Z9hkDsTQvFOFRT8fiItLMrD7Eo+zRZsikXtJkIKYa4OzkKoXKOQ2sYs6d9jx21hmuyBo1Y4oWnLnj FbgKAjOuQn4qPbvnZjp4dGuK6rX1AjCA07XpzVZoTMj2hsKkAslE3lu58Ap0oxLrLEOYhfJwk1+pW KyeLpJd+PpwNGP2JOBjrBmPwsaERBzWI80vVfCXRjv34nAbc4yWcvrmYTsTkFhwLfpCNEeDkVNPGq MbMMbnVeWElCB/nQilwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrMdW-00G8EK-My; Sun, 28 Nov 2021 16:02:42 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrMdR-00G8DL-Pp; Sun, 28 Nov 2021 16:02:39 +0000 X-UUID: cb557e29f8b1489e9005c5435c87c526-20211128 X-UUID: cb557e29f8b1489e9005c5435c87c526-20211128 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1348135641; Sun, 28 Nov 2021 09:02:36 -0700 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 28 Nov 2021 08:02:34 -0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 29 Nov 2021 00:02:33 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 29 Nov 2021 00:02:33 +0800 Message-ID: From: Jason-JH Lin To: Tzung-Bi Shih CC: Chun-Kuang Hu , "; Philipp Zabel" , "; Matthias Brugger" , "; Jassi Brar" , "; David Airlie" , "; Daniel Vetter" , "; dri-devel@lists.freedesktop.org; linux-mediatek@lists.infradead.org; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; hsinyi@chromium.org; fshao@chromium.org; Nancy Lin =?UTF-8?Q?=28=E6=9E=97=E6=AC=A3=E8=9E=A2=29?=" , "; Singo Chang =?UTF-8?Q?=28=E5=BC=B5=E8=88=88=E5=9C=8B=29?=" In-Reply-To: References: <20211117064158.27451-1-jason-jh.lin@mediatek.com> <20211117064158.27451-4-jason-jh.lin@mediatek.com> MIME-Version: 1.0 Subject: Re: FW: [PATCH 3/3] drm/mediatek: add devlink to cmdq dev Resent-From: Jason-JH Lin Resent-Cc: DRI Development , "; moderated list:ARM/Mediatek SoC support" , "; Linux ARM" , "; linux-kernel" , "; Hsin-Yi Wang" , "; Fei Shao" Date: Mon, 29 Nov 2021 00:02:33 +0800 X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211128_080237_853408_EB20F359 X-CRM114-Status: GOOD ( 18.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Message-ID: <20211128160233._lfScZAbqKDYaBcJDbd5T8BUq-8kZ8MAp_IztwLE1fI@z> SGkgVHp1bmctQmksCgpUaGFua3MgZm9yIHRoZSByZXZpZXdzLgoKPiBGcm9tOiBMaW51eC1tZWRp YXRlayA8bGludXgtbWVkaWF0ZWstYm91bmNlc0BsaXN0cy5pbmZyYWRlYWQub3JnPiBPbgo+IEJl aGFsZiBPZiBUenVuZy1CaSBTaGloCj4gU2VudDogVGh1cnNkYXksIE5vdmVtYmVyIDE4LCAyMDIx IDE6NTUgUE0KPiBUbzogSmFzb24tSkggTGluICjmnpfnnb/npaUpIDxKYXNvbi1KSC5MaW5AbWVk aWF0ZWsuY29tPgo+IENjOiBDaHVuLUt1YW5nIEh1IDxjaHVua3VhbmcuaHVAa2VybmVsLm9yZz47 IFBoaWxpcHAgWmFiZWwgPAo+IHAuemFiZWxAcGVuZ3V0cm9uaXguZGU+OyBNYXR0aGlhcyBCcnVn Z2VyIDxtYXR0aGlhcy5iZ2dAZ21haWwuY29tPjsKPiBKYXNzaSBCcmFyIDxqYXNzaXNpbmdoYnJh ckBnbWFpbC5jb20+OyBEYXZpZCBBaXJsaWUgPGFpcmxpZWRAbGludXguaWUKPiA+OyBEYW5pZWwg VmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+OyBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn OyAKPiBsaW51eC1tZWRpYXRla0BsaXN0cy5pbmZyYWRlYWQub3JnOyAKPiBsaW51eC1hcm0ta2Vy bmVsQGxpc3RzLmluZnJhZGVhZC5vcmc7IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7IAo+ IGhzaW55aUBjaHJvbWl1bS5vcmc7IGZzaGFvQGNocm9taXVtLm9yZzsgTmFuY3kgTGluICjmnpfm rKPonqIpIDwKPiBOYW5jeS5MaW5AbWVkaWF0ZWsuY29tPjsgU2luZ28gQ2hhbmcgKOW8teiIiOWc iykgPFNpbmdvLkNoYW5nQG1lZGlhdGVrLmNvbT4KPiBTdWJqZWN0OiBSZTogW1BBVENIIDMvM10g ZHJtL21lZGlhdGVrOiBhZGQgZGV2bGluayB0byBjbWRxIGRldgo+IAo+IE9uIFdlZCwgTm92IDE3 LCAyMDIxIGF0IDAyOjQxOjU4UE0gKzA4MDAsIGphc29uLWpoLmxpbiB3cm90ZToKPiA+IEBAIC0x NTgsNiArMTU5LDcgQEAgc3RhdGljIHZvaWQgbXRrX2RybV9jcnRjX2Rlc3Ryb3koc3RydWN0Cj4g PiBkcm1fY3J0YyAqY3J0YykKPiA+ICAJbXRrX2RybV9jbWRxX3BrdF9kZXN0cm95KCZtdGtfY3J0 Yy0+Y21kcV9oYW5kbGUpOwo+ID4gIAo+ID4gIAlpZiAobXRrX2NydGMtPmNtZHFfY2xpZW50LmNo YW4pIHsKPiA+ICsJCWRldmljZV9saW5rX3JlbW92ZShtdGtfY3J0Yy0+ZHJtX2RldiwgbXRrX2Ny dGMtCj4gPiA+Y21kcV9jbGllbnQuY2hhbi0+bWJveC0+ZGV2KTsKPiA+ICAJCW1ib3hfZnJlZV9j aGFubmVsKG10a19jcnRjLT5jbWRxX2NsaWVudC5jaGFuKTsKPiA+ICAJCW10a19jcnRjLT5jbWRx X2NsaWVudC5jaGFuID0gTlVMTDsKPiA+ICAJfQo+IAo+IFsuLi5dCj4gPiBAQCAtOTU2LDYgKzk1 OSwxNiBAQCBpbnQgbXRrX2RybV9jcnRjX2NyZWF0ZShzdHJ1Y3QgZHJtX2RldmljZQo+ID4gKmRy bV9kZXYsCj4gPiAgCX0KPiA+ICAKPiA+ICAJaWYgKG10a19jcnRjLT5jbWRxX2NsaWVudC5jaGFu KSB7Cj4gPiArCQlzdHJ1Y3QgZGV2aWNlX2xpbmsgKmxpbms7Cj4gPiArCj4gPiArCQkvKiBhZGQg ZGV2bGluayB0byBjbWRxIGRldiB0byBtYWtlIHN1cmUgc3VzcGVuZC9yZXN1bWUKPiA+IG9yZGVy IGlzIGNvcnJlY3QgKi8KPiA+ICsJCWxpbmsgPSBkZXZpY2VfbGlua19hZGQoZGV2LCBtdGtfY3J0 Yy0+Y21kcV9jbGllbnQuY2hhbi0KPiA+ID5tYm94LT5kZXYsCj4gPiArCQkJCSAgICAgICBETF9G TEFHX1BNX1JVTlRJTUUgfAo+ID4gRExfRkxBR19TVEFURUxFU1MpOwo+ID4gKwkJaWYgKCFsaW5r KSB7Cj4gPiArCQkJZGV2X2VycihkZXYsICJVbmFibGUgdG8gbGluayBkZXY9JXNcbiIsCj4gPiAr CQkJCWRldl9uYW1lKG10a19jcnRjLT5jbWRxX2NsaWVudC5jaGFuLQo+ID4gPm1ib3gtPmRldikp Owo+ID4gKwkJfQo+ID4gKwo+IAo+IElmIGRldmljZV9saW5rX2FkZCgpIGZhaWxlZCwgZG9lc24n dCBtdGtfZHJtX2NydGNfY3JlYXRlKCkgbmVlZCB0bwo+IHJldHVybiBhbiBlcnJvciBhbmQgZXhp dD8KCk9LLCBJJ2xsIGFkZCB0aGUgcmV0dXJuIGVycm9yIGF0IHRoZSBuZXh0IHZlcmlvbi4KPiAK PiBPVE9ILCBpZiBkZXZpY2VfbGlua19hZGQoKSBmYWlsZWQsIHdvbid0IGl0IGJyaW5nIGFueSBz aWRlIGVmZmVjdHMgdG8KPiBjYWxsIGRldmljZV9saW5rX3JlbW92ZSgpPwo+IAoKQmVjYXVzZSBk ZXZpY2VfbGlua19yZW1vdmUoKSB3aWxsIGZpbmQgdGhlIGRldmljZV9saW5rIG9mIHN1cHBsaWVy IGFuZApjb25zdW1lciwgdGhlbiBkZWxldGUgdGhlIGRldmljZV9saW5rIGJldHdlZW4gdGhlbS4K SWYgZGV2aWNlX2xpbmtfYWRkKCkgZmFpbGVkLCBzdXBwbGllciBhbmQgY29uc3VtZXIgd29uJ3Qg Y3JlYXRlIHRoZQpkZXZpY2VfbGluay4KU28gY2FsbGluZyBkZXZpY2VfbGlua19yZW1vdmUoKSB3 b24ndCBkbyBhbnl0aGluZyB3aXRob3V0IGRlaXZlX2xpbmsKYW5kIHdvbid0IGJyaW5nIGFueSBz aWRlIGVmZmVjdHMuCgpSZWdhcmRzLApKYXNvbi1KSC5MaW4KPiBfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IExpbnV4LW1lZGlhdGVrIG1haWxpbmcgbGlz dAo+IExpbnV4LW1lZGlhdGVrQGxpc3RzLmluZnJhZGVhZC5vcmcKPiAKaHR0cHM6Ly91cmxkZWZl bnNlLmNvbS92My9fX2h0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtbWVkaWF0ZWtfXzshIUNUUk5LQTl3TWcwQVJidyExMjVkbU9aN3hDTGt3YklyelpmMVZx VkxRQmJkVDRSRkhvTWpSMzhVMUdlQ3hhVE02eHZ2Qi1tU3I3c1RjNkJ1WTVJSCQKPiAgCi0tIApK YXNvbi1KSCBMaW4gPGphc29uLWpoLmxpbkBtZWRpYXRlay5jb20+CgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9655FC433F5 for ; Sun, 28 Nov 2021 15:57:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C4EB572F3D; Sun, 28 Nov 2021 15:57:41 +0000 (UTC) Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5ADE172F3D for ; Sun, 28 Nov 2021 15:57:40 +0000 (UTC) X-UUID: a06df0059a734746a1cc6e4dd9453dbf-20211128 X-UUID: a06df0059a734746a1cc6e4dd9453dbf-20211128 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 283879108; Sun, 28 Nov 2021 23:57:35 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Sun, 28 Nov 2021 23:57:34 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sun, 28 Nov 2021 23:57:33 +0800 Message-ID: From: Jason-JH Lin To: Tzung-Bi Shih In-Reply-To: References: <20211117064158.27451-1-jason-jh.lin@mediatek.com> <20211117064158.27451-4-jason-jh.lin@mediatek.com> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Subject: Re: FW: [PATCH 3/3] drm/mediatek: add devlink to cmdq dev Resent-From: Jason-JH Lin Resent-Cc: DRI Development , "moderated list:ARM/Mediatek SoC support" , "Linux ARM" , linux-kernel , Hsin-Yi Wang , "Fei Shao" Date: Sun, 28 Nov 2021 23:57:33 +0800 X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 Content-Transfer-Encoding: quoted-printable X-MTK: N X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , "; David Airlie" , "; Singo Chang =?UTF-8?Q?=28=E5=BC=B5=E8=88=88=E5=9C=8B=29?=" , "; Jassi Brar" , "; dri-devel@lists.freedesktop.org; linux-mediatek@lists.infradead.org; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; hsinyi@chromium.org; fshao@chromium.org; Nancy Lin =?UTF-8?Q?=28=E6=9E=97=E6=AC=A3=E8=9E=A2=29?=" , "; Matthias Brugger" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Resent-Message-Id: <20211128155741.C4EB572F3D@gabe.freedesktop.org> Resent-Date: Sun, 28 Nov 2021 15:57:41 +0000 (UTC) Hi Tzung-Bi, Thanks for the reviews. > From: Linux-mediatek On > Behalf Of Tzung-Bi Shih > Sent: Thursday, November 18, 2021 1:55 PM > To: Jason-JH Lin (=E6=9E=97=E7=9D=BF=E7=A5=A5) > Cc: Chun-Kuang Hu ; Philipp Zabel < > p.zabel@pengutronix.de>; Matthias Brugger ; > Jassi Brar ; David Airlie >; Daniel Vetter ; dri-devel@lists.freedesktop.org;=20 > linux-mediatek@lists.infradead.org;=20 > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;=20 > hsinyi@chromium.org; fshao@chromium.org; Nancy Lin (=E6=9E=97=E6=AC=A3=E8= =9E=A2) < > Nancy.Lin@mediatek.com>; Singo Chang (=E5=BC=B5=E8=88=88=E5=9C=8B) > Subject: Re: [PATCH 3/3] drm/mediatek: add devlink to cmdq dev >=20 > On Wed, Nov 17, 2021 at 02:41:58PM +0800, jason-jh.lin wrote: > > @@ -158,6 +159,7 @@ static void mtk_drm_crtc_destroy(struct > > drm_crtc *crtc) > > mtk_drm_cmdq_pkt_destroy(&mtk_crtc->cmdq_handle); > > =20 > > if (mtk_crtc->cmdq_client.chan) { > > + device_link_remove(mtk_crtc->drm_dev, mtk_crtc- > > >cmdq_client.chan->mbox->dev); > > mbox_free_channel(mtk_crtc->cmdq_client.chan); > > mtk_crtc->cmdq_client.chan =3D NULL; > > } >=20 > [...] > > @@ -956,6 +959,16 @@ int mtk_drm_crtc_create(struct drm_device > > *drm_dev, > > } > > =20 > > if (mtk_crtc->cmdq_client.chan) { > > + struct device_link *link; > > + > > + /* add devlink to cmdq dev to make sure suspend/resume > > order is correct */ > > + link =3D device_link_add(dev, mtk_crtc->cmdq_client.chan- > > >mbox->dev, > > + DL_FLAG_PM_RUNTIME | > > DL_FLAG_STATELESS); > > + if (!link) { > > + dev_err(dev, "Unable to link dev=3D%s\n", > > + dev_name(mtk_crtc->cmdq_client.chan- > > >mbox->dev)); > > + } > > + >=20 > If device_link_add() failed, doesn't mtk_drm_crtc_create() need to > return an error and exit? OK, I'll add the return error at the next verion. >=20 > OTOH, if device_link_add() failed, won't it bring any side effects to > call device_link_remove()? >=20 Because device_link_remove() will find the device_link of supplier and consumer, then delete the device_link between them. If device_link_add() failed, supplier and consumer won't create the device_link. So calling device_link_remove() won't do anything without deive_link and won't bring any side effects. Regards, Jason-JH.Lin > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org >=20 https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/lin= ux-mediatek__;!!CTRNKA9wMg0ARbw!125dmOZ7xCLkwbIrzZf1VqVLQBbdT4RFHoMjR38U1Ge= CxaTM6xvvB-mSr7sTc6BuY5IH$ > =20 --=20 Jason-JH Lin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6123AC433F5 for ; Sun, 28 Nov 2021 16:02:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BAB0D72F93; Sun, 28 Nov 2021 16:02:42 +0000 (UTC) Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8D89672F93 for ; Sun, 28 Nov 2021 16:02:40 +0000 (UTC) X-UUID: 81bda1ccb0b4480cb9210040dba67a6d-20211129 X-UUID: 81bda1ccb0b4480cb9210040dba67a6d-20211129 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1868573853; Mon, 29 Nov 2021 00:02:34 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 29 Nov 2021 00:02:33 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 29 Nov 2021 00:02:33 +0800 Message-ID: From: Jason-JH Lin To: Tzung-Bi Shih In-Reply-To: References: <20211117064158.27451-1-jason-jh.lin@mediatek.com> <20211117064158.27451-4-jason-jh.lin@mediatek.com> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Subject: Re: FW: [PATCH 3/3] drm/mediatek: add devlink to cmdq dev Resent-From: Jason-JH Lin Resent-Cc: DRI Development , "; moderated list:ARM/Mediatek SoC support" , "; Linux ARM" , "; linux-kernel" , "; Hsin-Yi Wang" , "; Fei Shao" Date: Mon, 29 Nov 2021 00:02:33 +0800 X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 Content-Transfer-Encoding: quoted-printable X-MTK: N X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , "; David Airlie" , "; Singo Chang =?UTF-8?Q?=28=E5=BC=B5=E8=88=88=E5=9C=8B=29?=" , "; Jassi Brar" , "; dri-devel@lists.freedesktop.org; linux-mediatek@lists.infradead.org; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; hsinyi@chromium.org; fshao@chromium.org; Nancy Lin =?UTF-8?Q?=28=E6=9E=97=E6=AC=A3=E8=9E=A2=29?=" , "; Matthias Brugger" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Resent-Message-Id: <20211128160242.BAB0D72F93@gabe.freedesktop.org> Resent-Date: Sun, 28 Nov 2021 16:02:42 +0000 (UTC) Message-ID: <20211128160233.oZvz6IS8s-dUOZCCfXFEMT4GkUYUkGs2dyGe1psuLUc@z> Hi Tzung-Bi, Thanks for the reviews. > From: Linux-mediatek On > Behalf Of Tzung-Bi Shih > Sent: Thursday, November 18, 2021 1:55 PM > To: Jason-JH Lin (=E6=9E=97=E7=9D=BF=E7=A5=A5) > Cc: Chun-Kuang Hu ; Philipp Zabel < > p.zabel@pengutronix.de>; Matthias Brugger ; > Jassi Brar ; David Airlie >; Daniel Vetter ; dri-devel@lists.freedesktop.org;=20 > linux-mediatek@lists.infradead.org;=20 > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;=20 > hsinyi@chromium.org; fshao@chromium.org; Nancy Lin (=E6=9E=97=E6=AC=A3=E8= =9E=A2) < > Nancy.Lin@mediatek.com>; Singo Chang (=E5=BC=B5=E8=88=88=E5=9C=8B) > Subject: Re: [PATCH 3/3] drm/mediatek: add devlink to cmdq dev >=20 > On Wed, Nov 17, 2021 at 02:41:58PM +0800, jason-jh.lin wrote: > > @@ -158,6 +159,7 @@ static void mtk_drm_crtc_destroy(struct > > drm_crtc *crtc) > > mtk_drm_cmdq_pkt_destroy(&mtk_crtc->cmdq_handle); > > =20 > > if (mtk_crtc->cmdq_client.chan) { > > + device_link_remove(mtk_crtc->drm_dev, mtk_crtc- > > >cmdq_client.chan->mbox->dev); > > mbox_free_channel(mtk_crtc->cmdq_client.chan); > > mtk_crtc->cmdq_client.chan =3D NULL; > > } >=20 > [...] > > @@ -956,6 +959,16 @@ int mtk_drm_crtc_create(struct drm_device > > *drm_dev, > > } > > =20 > > if (mtk_crtc->cmdq_client.chan) { > > + struct device_link *link; > > + > > + /* add devlink to cmdq dev to make sure suspend/resume > > order is correct */ > > + link =3D device_link_add(dev, mtk_crtc->cmdq_client.chan- > > >mbox->dev, > > + DL_FLAG_PM_RUNTIME | > > DL_FLAG_STATELESS); > > + if (!link) { > > + dev_err(dev, "Unable to link dev=3D%s\n", > > + dev_name(mtk_crtc->cmdq_client.chan- > > >mbox->dev)); > > + } > > + >=20 > If device_link_add() failed, doesn't mtk_drm_crtc_create() need to > return an error and exit? OK, I'll add the return error at the next verion. >=20 > OTOH, if device_link_add() failed, won't it bring any side effects to > call device_link_remove()? >=20 Because device_link_remove() will find the device_link of supplier and consumer, then delete the device_link between them. If device_link_add() failed, supplier and consumer won't create the device_link. So calling device_link_remove() won't do anything without deive_link and won't bring any side effects. Regards, Jason-JH.Lin > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org >=20 https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/lin= ux-mediatek__;!!CTRNKA9wMg0ARbw!125dmOZ7xCLkwbIrzZf1VqVLQBbdT4RFHoMjR38U1Ge= CxaTM6xvvB-mSr7sTc6BuY5IH$ > =20 --=20 Jason-JH Lin