From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 441BDC43214 for ; Thu, 5 Aug 2021 07:12:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2565660ED6 for ; Thu, 5 Aug 2021 07:12:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237800AbhHEHNH (ORCPT ); Thu, 5 Aug 2021 03:13:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:59651 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230037AbhHEHNF (ORCPT ); Thu, 5 Aug 2021 03:13:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628147571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n0VxlG+I9DtspBlzYcgwvjsV5zD4hYtPEcF5uDUSb8k=; b=WnKShFfOo6rJV5EhQ9lb/uy7ktJQ7UGiYB787gx3g1QbQjDkMN2WZaPNV3i6eIIRfd7lWW xpPS6on/6Pslm66W77lCqGMyNUHz/W8xC7Pt8oXhPyihmDUVYm0crXhsdApFNo91BKeQti nD3m68uyx3SX8yz1rQkutZ6tX+65Omw= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-569-JmYAQgcHO8i4yI-utcAZbA-1; Thu, 05 Aug 2021 03:12:50 -0400 X-MC-Unique: JmYAQgcHO8i4yI-utcAZbA-1 Received: by mail-pj1-f70.google.com with SMTP id r13-20020a17090a4dcdb0290176dc35536aso4424576pjl.8 for ; Thu, 05 Aug 2021 00:12:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=n0VxlG+I9DtspBlzYcgwvjsV5zD4hYtPEcF5uDUSb8k=; b=VBcUBSudKBG6S+QliSUrb5i8WODvZj7ttV7YA5tTX6TP4byckpaeECLEEvBWCKl159 HdUVKBhOKYVf32LcXBxH793uFuTm8KSpFuKCQzZdzRh4LQTsFrKL5y6jCMkfrodLgMUw cQUmG47CaoL7Q2GOrpSVfa9VajGI2AoGkhZjOJbNzn0GhgZ8+mmCQwC56IY1zStUoPhp DCOz2gUlLuOX5vgpS6qQ2SE1sSaNPBO8YC14OVoiLtTWeP//hWbqpzv4aeUUC3va4gzk CcjU9j4yF30HslfEsCW5vg9xvQ8oQ3tm8I98tGWYU5hfMOaTbnD0roOXg30Gv+kEkN0t B97w== X-Gm-Message-State: AOAM531ar4TvYYcTR2WUmvd2XAYvKJvAZsQDV893iJL5T+TvBD+KlyIB BICeVJZItQK/swU/MyUbCXmZO1F0rb4dWadI+qKr3F4TvjldvhbV/Y9UoXZcGYFTfpFovQBqXhe LDsVynmVHbhueDLemCTpyf6JWZ4XljLwEGG4Bj+/UKROIJteIg7gfRsWicGOJVS6PcF398Vb1hy Hq X-Received: by 2002:a63:190b:: with SMTP id z11mr654577pgl.320.1628147568844; Thu, 05 Aug 2021 00:12:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUfHRxG/dXx9YH24cRrMopBNWNIkigiB28PNmXNoiyFNr8yDY8zBJY64Y2tGLqmxO/3wI2WA== X-Received: by 2002:a63:190b:: with SMTP id z11mr654537pgl.320.1628147568588; Thu, 05 Aug 2021 00:12:48 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id k8sm5028086pfu.116.2021.08.05.00.12.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Aug 2021 00:12:48 -0700 (PDT) Subject: Re: [PATCH v10 10/17] virtio: Handle device reset failure in register_virtio_device() To: Yongji Xie Cc: "Michael S. Tsirkin" , Stefan Hajnoczi , Stefano Garzarella , Parav Pandit , Christoph Hellwig , Christian Brauner , Randy Dunlap , Matthew Wilcox , Al Viro , Jens Axboe , bcrl@kvack.org, Jonathan Corbet , =?UTF-8?Q?Mika_Penttil=c3=a4?= , Dan Carpenter , joro@8bytes.org, Greg KH , He Zhe , Liu Xiaodong , Joe Perches , songmuchun@bytedance.com, virtualization , netdev@vger.kernel.org, kvm , linux-fsdevel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel References: <20210729073503.187-1-xieyongji@bytedance.com> <20210729073503.187-11-xieyongji@bytedance.com> <6bb6c689-e6dd-cfa2-094b-a0ca4258aded@redhat.com> From: Jason Wang Message-ID: Date: Thu, 5 Aug 2021 15:12:39 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2021/8/4 下午5:07, Yongji Xie 写道: > On Wed, Aug 4, 2021 at 4:54 PM Jason Wang wrote: >> >> 在 2021/8/4 下午4:50, Yongji Xie 写道: >>> On Wed, Aug 4, 2021 at 4:32 PM Jason Wang wrote: >>>> 在 2021/8/3 下午5:38, Yongji Xie 写道: >>>>> On Tue, Aug 3, 2021 at 4:09 PM Jason Wang wrote: >>>>>> 在 2021/7/29 下午3:34, Xie Yongji 写道: >>>>>>> The device reset may fail in virtio-vdpa case now, so add checks to >>>>>>> its return value and fail the register_virtio_device(). >>>>>> So the reset() would be called by the driver during remove as well, or >>>>>> is it sufficient to deal only with the reset during probe? >>>>>> >>>>> Actually there is no way to handle failure during removal. And it >>>>> should be safe with the protection of software IOTLB even if the >>>>> reset() fails. >>>>> >>>>> Thanks, >>>>> Yongji >>>> If this is true, does it mean we don't even need to care about reset >>>> failure? >>>> >>> But we need to handle the failure in the vhost-vdpa case, isn't it? >> >> Yes, but: >> >> - This patch is for virtio not for vhost, if we don't care virtio, we >> can avoid the changes >> - For vhost, there could be two ways probably: >> >> 1) let the set_status to report error >> 2) require userspace to re-read for status >> >> It looks to me you want to go with 1) and I'm not sure whether or not >> it's too late to go with 2). >> > Looks like 2) can't work if reset failure happens in > vhost_vdpa_release() and vhost_vdpa_open(). Yes, you're right. Thanks > > Thanks, > Yongji > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03F5DC4320A for ; Thu, 5 Aug 2021 07:12:56 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B7B260F41 for ; Thu, 5 Aug 2021 07:12:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9B7B260F41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 2FCB26073B; Thu, 5 Aug 2021 07:12:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PNu9ffvx92DR; Thu, 5 Aug 2021 07:12:54 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 11409605D8; Thu, 5 Aug 2021 07:12:53 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id E3B29C0010; Thu, 5 Aug 2021 07:12:53 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 756D6C000E for ; Thu, 5 Aug 2021 07:12:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 5DFDF83268 for ; Thu, 5 Aug 2021 07:12:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 83sGDfhVP6qv for ; Thu, 5 Aug 2021 07:12:52 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp1.osuosl.org (Postfix) with ESMTPS id 376A283267 for ; Thu, 5 Aug 2021 07:12:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628147571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n0VxlG+I9DtspBlzYcgwvjsV5zD4hYtPEcF5uDUSb8k=; b=WnKShFfOo6rJV5EhQ9lb/uy7ktJQ7UGiYB787gx3g1QbQjDkMN2WZaPNV3i6eIIRfd7lWW xpPS6on/6Pslm66W77lCqGMyNUHz/W8xC7Pt8oXhPyihmDUVYm0crXhsdApFNo91BKeQti nD3m68uyx3SX8yz1rQkutZ6tX+65Omw= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-214-gR6EfAgNOkCZGO2TheDNhw-1; Thu, 05 Aug 2021 03:12:49 -0400 X-MC-Unique: gR6EfAgNOkCZGO2TheDNhw-1 Received: by mail-pj1-f71.google.com with SMTP id s2-20020a17090a0742b0290177b02e795eso4440819pje.7 for ; Thu, 05 Aug 2021 00:12:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=n0VxlG+I9DtspBlzYcgwvjsV5zD4hYtPEcF5uDUSb8k=; b=oMTnGD/rrIJ63InbvbzgQ98Whwm222GSzzfJgYRAhOuzGtZqwXnrTaNuZvcB9Bxou1 7U5jt3MnkgirI6trlCbpxiPC0KRPS3abuRuTDTcTHJ2cnfEQ75NHdnH4XWrhP3FcTdec Wmp502OHy0kUnKfK41ew9TQKSZk9LNLhcBryOyKhAXX4DkjMP/GhWQtn8sgV4KjEpAOL Ha4p7oLTWiqhWWU1ljgpaRyxNVQiIhvET87IhVEPNf1s3DXfrqWxj6ENFJM8NtS/En/j VxQGZ9l7eR3xn9ppkzU7i5FqiU+54f1utRS6k+7XMDXQwCpr20Dc1qBMMEzljwurEEC5 OwAg== X-Gm-Message-State: AOAM532+3qF4GVqXNdl0ZAV5Qbhk/ZUUkUb21UOTSoY1pcDoxl6zDbBT 2mK5+vXRIy8e7YUs0mIZQzlb2N87yDPLk+ElTdte++Dr42gfzJDnn07PAio1ilja9gD+/XCpNox coXo2EVDPAuOGGt3k6vjUFSpmb+adwA== X-Received: by 2002:a63:190b:: with SMTP id z11mr654560pgl.320.1628147568773; Thu, 05 Aug 2021 00:12:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUfHRxG/dXx9YH24cRrMopBNWNIkigiB28PNmXNoiyFNr8yDY8zBJY64Y2tGLqmxO/3wI2WA== X-Received: by 2002:a63:190b:: with SMTP id z11mr654537pgl.320.1628147568588; Thu, 05 Aug 2021 00:12:48 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id k8sm5028086pfu.116.2021.08.05.00.12.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Aug 2021 00:12:48 -0700 (PDT) Subject: Re: [PATCH v10 10/17] virtio: Handle device reset failure in register_virtio_device() To: Yongji Xie References: <20210729073503.187-1-xieyongji@bytedance.com> <20210729073503.187-11-xieyongji@bytedance.com> <6bb6c689-e6dd-cfa2-094b-a0ca4258aded@redhat.com> From: Jason Wang Message-ID: Date: Thu, 5 Aug 2021 15:12:39 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: kvm , "Michael S. Tsirkin" , virtualization , Christian Brauner , Jonathan Corbet , Matthew Wilcox , Christoph Hellwig , Dan Carpenter , Stefano Garzarella , Liu Xiaodong , linux-fsdevel@vger.kernel.org, Al Viro , Stefan Hajnoczi , songmuchun@bytedance.com, Jens Axboe , He Zhe , Greg KH , Randy Dunlap , linux-kernel , iommu@lists.linux-foundation.org, bcrl@kvack.org, netdev@vger.kernel.org, Joe Perches , =?UTF-8?Q?Mika_Penttil=c3=a4?= X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" CuWcqCAyMDIxLzgvNCDkuIvljYg1OjA3LCBZb25namkgWGllIOWGmemBkzoKPiBPbiBXZWQsIEF1 ZyA0LCAyMDIxIGF0IDQ6NTQgUE0gSmFzb24gV2FuZyA8amFzb3dhbmdAcmVkaGF0LmNvbT4gd3Jv dGU6Cj4+Cj4+IOWcqCAyMDIxLzgvNCDkuIvljYg0OjUwLCBZb25namkgWGllIOWGmemBkzoKPj4+ IE9uIFdlZCwgQXVnIDQsIDIwMjEgYXQgNDozMiBQTSBKYXNvbiBXYW5nIDxqYXNvd2FuZ0ByZWRo YXQuY29tPiB3cm90ZToKPj4+PiDlnKggMjAyMS84LzMg5LiL5Y2INTozOCwgWW9uZ2ppIFhpZSDl hpnpgZM6Cj4+Pj4+IE9uIFR1ZSwgQXVnIDMsIDIwMjEgYXQgNDowOSBQTSBKYXNvbiBXYW5nIDxq YXNvd2FuZ0ByZWRoYXQuY29tPiB3cm90ZToKPj4+Pj4+IOWcqCAyMDIxLzcvMjkg5LiL5Y2IMzoz NCwgWGllIFlvbmdqaSDlhpnpgZM6Cj4+Pj4+Pj4gVGhlIGRldmljZSByZXNldCBtYXkgZmFpbCBp biB2aXJ0aW8tdmRwYSBjYXNlIG5vdywgc28gYWRkIGNoZWNrcyB0bwo+Pj4+Pj4+IGl0cyByZXR1 cm4gdmFsdWUgYW5kIGZhaWwgdGhlIHJlZ2lzdGVyX3ZpcnRpb19kZXZpY2UoKS4KPj4+Pj4+IFNv IHRoZSByZXNldCgpIHdvdWxkIGJlIGNhbGxlZCBieSB0aGUgZHJpdmVyIGR1cmluZyByZW1vdmUg YXMgd2VsbCwgb3IKPj4+Pj4+IGlzIGl0IHN1ZmZpY2llbnQgdG8gZGVhbCBvbmx5IHdpdGggdGhl IHJlc2V0IGR1cmluZyBwcm9iZT8KPj4+Pj4+Cj4+Pj4+IEFjdHVhbGx5IHRoZXJlIGlzIG5vIHdh eSB0byBoYW5kbGUgZmFpbHVyZSBkdXJpbmcgcmVtb3ZhbC4gQW5kIGl0Cj4+Pj4+IHNob3VsZCBi ZSBzYWZlIHdpdGggdGhlIHByb3RlY3Rpb24gb2Ygc29mdHdhcmUgSU9UTEIgZXZlbiBpZiB0aGUK Pj4+Pj4gcmVzZXQoKSBmYWlscy4KPj4+Pj4KPj4+Pj4gVGhhbmtzLAo+Pj4+PiBZb25namkKPj4+ PiBJZiB0aGlzIGlzIHRydWUsIGRvZXMgaXQgbWVhbiB3ZSBkb24ndCBldmVuIG5lZWQgdG8gY2Fy ZSBhYm91dCByZXNldAo+Pj4+IGZhaWx1cmU/Cj4+Pj4KPj4+IEJ1dCB3ZSBuZWVkIHRvIGhhbmRs ZSB0aGUgZmFpbHVyZSBpbiB0aGUgdmhvc3QtdmRwYSBjYXNlLCBpc24ndCBpdD8KPj4KPj4gWWVz LCBidXQ6Cj4+Cj4+IC0gVGhpcyBwYXRjaCBpcyBmb3IgdmlydGlvIG5vdCBmb3Igdmhvc3QsIGlm IHdlIGRvbid0IGNhcmUgdmlydGlvLCB3ZQo+PiBjYW4gYXZvaWQgdGhlIGNoYW5nZXMKPj4gLSBG b3Igdmhvc3QsIHRoZXJlIGNvdWxkIGJlIHR3byB3YXlzIHByb2JhYmx5Ogo+Pgo+PiAxKSBsZXQg dGhlIHNldF9zdGF0dXMgdG8gcmVwb3J0IGVycm9yCj4+IDIpIHJlcXVpcmUgdXNlcnNwYWNlIHRv IHJlLXJlYWQgZm9yIHN0YXR1cwo+Pgo+PiBJdCBsb29rcyB0byBtZSB5b3Ugd2FudCB0byBnbyB3 aXRoIDEpIGFuZCBJJ20gbm90IHN1cmUgd2hldGhlciBvciBub3QKPj4gaXQncyB0b28gbGF0ZSB0 byBnbyB3aXRoIDIpLgo+Pgo+IExvb2tzIGxpa2UgMikgY2FuJ3Qgd29yayBpZiByZXNldCBmYWls dXJlIGhhcHBlbnMgaW4KPiB2aG9zdF92ZHBhX3JlbGVhc2UoKSBhbmQgdmhvc3RfdmRwYV9vcGVu KCkuCgoKWWVzLCB5b3UncmUgcmlnaHQuCgpUaGFua3MKCgo+Cj4gVGhhbmtzLAo+IFlvbmdqaQo+ CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwppb21tdSBt YWlsaW5nIGxpc3QKaW9tbXVAbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0 cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vaW9tbXU= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,URIBL_RED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DB1FC4338F for ; Thu, 5 Aug 2021 07:12:58 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA8D3610A0 for ; Thu, 5 Aug 2021 07:12:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CA8D3610A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 939FA83267; Thu, 5 Aug 2021 07:12:57 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8DbLLIMQkn5K; Thu, 5 Aug 2021 07:12:56 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 452CA8332A; Thu, 5 Aug 2021 07:12:56 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1F359C0010; Thu, 5 Aug 2021 07:12:56 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2E3A5C000E for ; Thu, 5 Aug 2021 07:12:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 0FDDC403AF for ; Thu, 5 Aug 2021 07:12:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1zqCREAns7ys for ; Thu, 5 Aug 2021 07:12:54 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id 3BBDF401EC for ; Thu, 5 Aug 2021 07:12:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628147573; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n0VxlG+I9DtspBlzYcgwvjsV5zD4hYtPEcF5uDUSb8k=; b=bFXCHAqtxHv+9hYnFqAy/ZCG3DnyogXmnF9K075McnmQb6Ld+PvZkCLdRFA3sOPIFFYPMk mE1Z9iKt3XTMyNL8OZSMGvuWbbRtzk3ACem1WufjCS4gdl+N4IoT7QY4uqEyYJXQA4g2Po jpdCCYigL3WUOyUzFiAr9iUOBkQS3Oc= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-53-j7-9zmsdNW6ZcXQ3hZfBmA-1; Thu, 05 Aug 2021 03:12:49 -0400 X-MC-Unique: j7-9zmsdNW6ZcXQ3hZfBmA-1 Received: by mail-pl1-f198.google.com with SMTP id u6-20020a170902bf46b029012c971d6226so4026191pls.21 for ; Thu, 05 Aug 2021 00:12:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=n0VxlG+I9DtspBlzYcgwvjsV5zD4hYtPEcF5uDUSb8k=; b=aceVecswLEI3xNvedZ4YEfFNzTSS4e1aX3CNDI64XQUILsxyiAoxwGzXeeok9udWm2 9+AY8jci5YHN3mSluyQejvKnT3Ll3I2/FzpP9UTAqcnJ4tQGZL+H5ytuZcvnb9IjfDp3 Ste8s03esHl4YDc4YWvt1hoX8AJ/3OzJxTdLAF04WW/kEm6ErNeRLu5HtGx+AMC3JRg1 9oVIh0E6qd5hAh0w+L5ltWF489j7x+WUUJBd85cMVStMhuUCwqOSxhvHxX+Cp1hIiwra zZbpP2CKUHqLYf+b3FD3QlSVVi21pFcHvJCryGDQZ3dUBQvb0tKIUkMpvlU9hwAOAayq KPHA== X-Gm-Message-State: AOAM533hokUZ8xCa5qqHAsTyuzkRWw8/5e0QR5GIYwjKbM0TPeUXWeXu 4jT1aEomLE6JG+/Hb4U30poLdyWvGHf+Z4UZtg+m6/8GagpWFrDbeg+Znzst+UrSblIPjOZGk9G rsLS5kISHaEkSyi74fNy2Oxl7taDzv0V3aBIkYNXrfQ== X-Received: by 2002:a63:190b:: with SMTP id z11mr654570pgl.320.1628147568793; Thu, 05 Aug 2021 00:12:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUfHRxG/dXx9YH24cRrMopBNWNIkigiB28PNmXNoiyFNr8yDY8zBJY64Y2tGLqmxO/3wI2WA== X-Received: by 2002:a63:190b:: with SMTP id z11mr654537pgl.320.1628147568588; Thu, 05 Aug 2021 00:12:48 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id k8sm5028086pfu.116.2021.08.05.00.12.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Aug 2021 00:12:48 -0700 (PDT) Subject: Re: [PATCH v10 10/17] virtio: Handle device reset failure in register_virtio_device() To: Yongji Xie References: <20210729073503.187-1-xieyongji@bytedance.com> <20210729073503.187-11-xieyongji@bytedance.com> <6bb6c689-e6dd-cfa2-094b-a0ca4258aded@redhat.com> From: Jason Wang Message-ID: Date: Thu, 5 Aug 2021 15:12:39 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: kvm , "Michael S. Tsirkin" , virtualization , Christian Brauner , Jonathan Corbet , joro@8bytes.org, Matthew Wilcox , Christoph Hellwig , Dan Carpenter , Liu Xiaodong , linux-fsdevel@vger.kernel.org, Al Viro , Stefan Hajnoczi , songmuchun@bytedance.com, Jens Axboe , He Zhe , Greg KH , Randy Dunlap , linux-kernel , iommu@lists.linux-foundation.org, bcrl@kvack.org, netdev@vger.kernel.org, Joe Perches , =?UTF-8?Q?Mika_Penttil=c3=a4?= X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" CuWcqCAyMDIxLzgvNCDkuIvljYg1OjA3LCBZb25namkgWGllIOWGmemBkzoKPiBPbiBXZWQsIEF1 ZyA0LCAyMDIxIGF0IDQ6NTQgUE0gSmFzb24gV2FuZyA8amFzb3dhbmdAcmVkaGF0LmNvbT4gd3Jv dGU6Cj4+Cj4+IOWcqCAyMDIxLzgvNCDkuIvljYg0OjUwLCBZb25namkgWGllIOWGmemBkzoKPj4+ IE9uIFdlZCwgQXVnIDQsIDIwMjEgYXQgNDozMiBQTSBKYXNvbiBXYW5nIDxqYXNvd2FuZ0ByZWRo YXQuY29tPiB3cm90ZToKPj4+PiDlnKggMjAyMS84LzMg5LiL5Y2INTozOCwgWW9uZ2ppIFhpZSDl hpnpgZM6Cj4+Pj4+IE9uIFR1ZSwgQXVnIDMsIDIwMjEgYXQgNDowOSBQTSBKYXNvbiBXYW5nIDxq YXNvd2FuZ0ByZWRoYXQuY29tPiB3cm90ZToKPj4+Pj4+IOWcqCAyMDIxLzcvMjkg5LiL5Y2IMzoz NCwgWGllIFlvbmdqaSDlhpnpgZM6Cj4+Pj4+Pj4gVGhlIGRldmljZSByZXNldCBtYXkgZmFpbCBp biB2aXJ0aW8tdmRwYSBjYXNlIG5vdywgc28gYWRkIGNoZWNrcyB0bwo+Pj4+Pj4+IGl0cyByZXR1 cm4gdmFsdWUgYW5kIGZhaWwgdGhlIHJlZ2lzdGVyX3ZpcnRpb19kZXZpY2UoKS4KPj4+Pj4+IFNv IHRoZSByZXNldCgpIHdvdWxkIGJlIGNhbGxlZCBieSB0aGUgZHJpdmVyIGR1cmluZyByZW1vdmUg YXMgd2VsbCwgb3IKPj4+Pj4+IGlzIGl0IHN1ZmZpY2llbnQgdG8gZGVhbCBvbmx5IHdpdGggdGhl IHJlc2V0IGR1cmluZyBwcm9iZT8KPj4+Pj4+Cj4+Pj4+IEFjdHVhbGx5IHRoZXJlIGlzIG5vIHdh eSB0byBoYW5kbGUgZmFpbHVyZSBkdXJpbmcgcmVtb3ZhbC4gQW5kIGl0Cj4+Pj4+IHNob3VsZCBi ZSBzYWZlIHdpdGggdGhlIHByb3RlY3Rpb24gb2Ygc29mdHdhcmUgSU9UTEIgZXZlbiBpZiB0aGUK Pj4+Pj4gcmVzZXQoKSBmYWlscy4KPj4+Pj4KPj4+Pj4gVGhhbmtzLAo+Pj4+PiBZb25namkKPj4+ PiBJZiB0aGlzIGlzIHRydWUsIGRvZXMgaXQgbWVhbiB3ZSBkb24ndCBldmVuIG5lZWQgdG8gY2Fy ZSBhYm91dCByZXNldAo+Pj4+IGZhaWx1cmU/Cj4+Pj4KPj4+IEJ1dCB3ZSBuZWVkIHRvIGhhbmRs ZSB0aGUgZmFpbHVyZSBpbiB0aGUgdmhvc3QtdmRwYSBjYXNlLCBpc24ndCBpdD8KPj4KPj4gWWVz LCBidXQ6Cj4+Cj4+IC0gVGhpcyBwYXRjaCBpcyBmb3IgdmlydGlvIG5vdCBmb3Igdmhvc3QsIGlm IHdlIGRvbid0IGNhcmUgdmlydGlvLCB3ZQo+PiBjYW4gYXZvaWQgdGhlIGNoYW5nZXMKPj4gLSBG b3Igdmhvc3QsIHRoZXJlIGNvdWxkIGJlIHR3byB3YXlzIHByb2JhYmx5Ogo+Pgo+PiAxKSBsZXQg dGhlIHNldF9zdGF0dXMgdG8gcmVwb3J0IGVycm9yCj4+IDIpIHJlcXVpcmUgdXNlcnNwYWNlIHRv IHJlLXJlYWQgZm9yIHN0YXR1cwo+Pgo+PiBJdCBsb29rcyB0byBtZSB5b3Ugd2FudCB0byBnbyB3 aXRoIDEpIGFuZCBJJ20gbm90IHN1cmUgd2hldGhlciBvciBub3QKPj4gaXQncyB0b28gbGF0ZSB0 byBnbyB3aXRoIDIpLgo+Pgo+IExvb2tzIGxpa2UgMikgY2FuJ3Qgd29yayBpZiByZXNldCBmYWls dXJlIGhhcHBlbnMgaW4KPiB2aG9zdF92ZHBhX3JlbGVhc2UoKSBhbmQgdmhvc3RfdmRwYV9vcGVu KCkuCgoKWWVzLCB5b3UncmUgcmlnaHQuCgpUaGFua3MKCgo+Cj4gVGhhbmtzLAo+IFlvbmdqaQo+ CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpWaXJ0dWFs aXphdGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlzdHMubGludXgtZm91bmRhdGlv bi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8v dmlydHVhbGl6YXRpb24=