From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CFEBC433FE for ; Mon, 13 Sep 2021 05:51:01 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id C61A560F4B for ; Mon, 13 Sep 2021 05:51:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C61A560F4B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC2C840151; Mon, 13 Sep 2021 07:50:59 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id C53604014F; Mon, 13 Sep 2021 07:50:57 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10105"; a="221621422" X-IronPort-AV: E=Sophos;i="5.85,288,1624345200"; d="scan'208";a="221621422" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2021 22:50:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,288,1624345200"; d="scan'208";a="506945571" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga008.fm.intel.com with ESMTP; 12 Sep 2021 22:50:55 -0700 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Sun, 12 Sep 2021 22:50:54 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX602.ccr.corp.intel.com (10.109.6.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 13 Sep 2021 13:50:52 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2242.012; Mon, 13 Sep 2021 13:50:52 +0800 From: "Zhang, Qi Z" To: "Wang, Haiyue" , "Yu, DapengX" , "Yang, Qiming" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v3] net/ice: fix representor port segmentation fault Thread-Index: AQHXo4xN4LqUyH2cGkenTOoW7+Tpc6ug+D0AgACHNEA= Date: Mon, 13 Sep 2021 05:50:52 +0000 Message-ID: References: <20210903054140.1530911-1-dapengx.yu@intel.com> <20210907020033.2113437-1-dapengx.yu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] net/ice: fix representor port segmentation fault X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Wang, Haiyue > Sent: Monday, September 13, 2021 1:47 PM > To: Yu, DapengX ; Yang, Qiming > ; Zhang, Qi Z > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH v3] net/ice: fix representor port segmentation fault >=20 > > -----Original Message----- > > From: Yu, DapengX > > Sent: Tuesday, September 7, 2021 10:01 > > To: Yang, Qiming ; Zhang, Qi Z > > > > Cc: dev@dpdk.org; Wang, Haiyue ; Yu, DapengX > > ; stable@dpdk.org > > Subject: [PATCH v3] net/ice: fix representor port segmentation fault > > > > From: Dapeng Yu > > > > If DCF representor port is closed after DCF port is closed, there will > > be segmentation fault because representor accesses the released > > resource of DCF port. > > > > This patch checks if the resource is present before accessing. > > > > Fixes: 5674465a32c8 ("net/ice: add DCF VLAN handling") > > Cc: stable@dpdk.org > > > > Signed-off-by: Dapeng Yu > > --- > > V2: > > * Remove (void) to make code clean. > > V3: > > * Only check resource accessibility but not release it. > > --- > > drivers/net/ice/ice_dcf_vf_representor.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > >=20 > Acked-by: Haiyue Wang Applied to dpdk-next-net-intel. Thanks Qi >=20 > > -- > > 2.27.0 >=20