From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v4 1/2] drm/i915/cnl: Implement WaProgramMgsrForCorrectSliceSpecificMmioReads Date: Mon, 26 Mar 2018 17:57:38 +0100 Message-ID: References: <1521741956-1761-1-git-send-email-yunwei.zhang@intel.com> <1522080721-7029-1-git-send-email-yunwei.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2805C6E093 for ; Mon, 26 Mar 2018 16:57:41 +0000 (UTC) In-Reply-To: <1522080721-7029-1-git-send-email-yunwei.zhang@intel.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Yunwei Zhang , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI2LzAzLzIwMTggMTc6MTIsIFl1bndlaSBaaGFuZyB3cm90ZToKPiBXYVByb2dyYW1NZ3Ny Rm9yQ29ycmVjdFNsaWNlU3BlY2lmaWNNbWlvUmVhZHMgZGljdGF0ZSB0aGF0IGJlZm9yZSBhbnkg TU1JTwo+IHJlYWQgaW50byBTbGljZS9TdWJzbGljZSBzcGVjaWZpYyByZWdpc3RlcnMsIE1DUiBw YWNrZXQgY29udHJvbAo+IHJlZ2lzdGVyKDB4RkRDKSBuZWVkcyB0byBiZSBwcm9ncmFtbWVkIHRv IHBvaW50IHRvIGFueSBlbmFibGVkCj4gc2xpY2Uvc3Vic2xpY2UgcGFpci4gT3RoZXJ3aXNlLCBp bmNvcnJlY3QgdmFsdWUgd2lsbCBiZSByZXR1cm5lZC4KPiAKPiBIb3dldmVyLCB0aGF0IG1lYW5z IGVhY2ggc3Vic2VxdWVudCBNTUlPIHJlYWQgd2lsbCBiZSBmb3J3YXJkZWQgdG8gYQo+IHNwZWNp ZmljIHNsaWNlL3N1YnNsaWNlIGNvbWJpbmF0aW9uIGFzIHJlYWQgaXMgdW5pY2FzdC4gVGhpcyBp cyBPSyBzaW5jZQo+IHNsaWNlL3N1YnNsaWNlIHNwZWNpZmljIHJlZ2lzdGVyIHZhbHVlcyBhcmUg Y29uc2lzdGVudCBpbiBhbG1vc3QgYWxsIGNhc2VzCj4gYWNyb3NzIHNsaWNlL3N1YnNsaWNlLiBU aGVyZSBhcmUgcmFyZSBvY2Nhc2lvbnMgc3VjaCBhcyBJTlNURE9ORSB0aGF0IHRoaXMKPiB2YWx1 ZSB3aWxsIGJlIGRlcGVuZGVudCBvbiBzbGljZS9zdWJzbGljZSBjb21ibywgaW4gc3VjaCBjYXNl cywgd2UgbmVlZCB0bwo+IHByb2dyYW0gMHhGREMgYW5kIHJlY292ZXIgdGhpcyBhZnRlci4gVGhp cyBpcyBhbHJlYWR5IGNvdmVyZWQgYnkKPiByZWFkX3N1YnNsaWNlX3JlZy4KPiAKPiBBbHNvLCAw eEZEQyB3aWxsIGxvc2UgaXRzIGluZm9ybWF0aW9uIGFmdGVyIFREUi9lbmdpbmUgcmVzZXQvcG93 ZXIgc3RhdGUKPiBjaGFuZ2UuCj4gCj4gUmVmZXJlbmNlOiBIU0QjMTQwNTU4Njg0MCBCU0lEIzA1 NzUKPiAKPiB2MjoKPiAgIC0gdXNlIGZscygpIGluc3RlYWQgb2YgZmluZF9sYXN0X2JpdCgpIChD aHJpcykKPiAgIC0gYWRkZWQgSU5URUxfU1NFVSB0byBleHRyYWN0IHNzZXUgZnJvbSBkZXZpY2Ug aW5mby4gKENocmlzKQo+IHYzOgo+ICAgLSByZWJhc2Ugb24gbGF0ZXN0IHRpcAo+IHY0Ogo+ICAg LSBBZGRlZCByZWZlcmVuY2VzIChNaWthKQo+IAo+IFNpZ25lZC1vZmYtYnk6IFl1bndlaSBaaGFu ZyA8eXVud2VpLnpoYW5nQGludGVsLmNvbT4KPiBDYzogT3NjYXIgTWF0ZW8gPG9zY2FyLm1hdGVv QGludGVsLmNvbT4KPiBDYzogTWljaGVsIFRoaWVycnkgPG1pY2hlbC50aGllcnJ5QGludGVsLmNv bT4KPiBDYzogSm9vbmFzIExhaHRpbmVuIDxqb29uYXMubGFodGluZW5AbGludXguaW50ZWwuY29t Pgo+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogTWlr YSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oICAgICAgICB8ICAxICsKPiAgIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jIHwgMzkgKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKystLQo+ICAgMiBmaWxlcyBjaGFuZ2VkLCAzOCBpbnNlcnRpb25zKCspLCAyIGRlbGV0 aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5o IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+IGluZGV4IDgwMDIzMGIuLjJkYjJh MDQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBAQCAtMjI5Nyw2ICsyMjk3LDcgQEAg aW50ZWxfaW5mbyhjb25zdCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gICAK PiAgICNkZWZpbmUgSU5URUxfR0VOKGRldl9wcml2KQkoKGRldl9wcml2KS0+aW5mby5nZW4pCj4g ICAjZGVmaW5lIElOVEVMX0RFVklEKGRldl9wcml2KQkoKGRldl9wcml2KS0+aW5mby5kZXZpY2Vf aWQpCj4gKyNkZWZpbmUgSU5URUxfU1NFVShkZXZfcHJpdikJKChkZXZfcHJpdiktPmluZm8uc3Nl dSkKCklmIHdlIGFkZCB0aGlzIHNvbWVvbmUgZ2V0cyB0aGUgam9iIG9mIGNvbnZlcnRpbmcgZXhp c3RpbmcgdXNlcnM/Cgo+ICAgCj4gICAjZGVmaW5lIFJFVklEX0ZPUkVWRVIJCTB4ZmYKPiAgICNk ZWZpbmUgSU5URUxfUkVWSUQoZGV2X3ByaXYpCSgoZGV2X3ByaXYpLT5kcm0ucGRldi0+cmV2aXNp b24pCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMKPiBpbmRleCBkZTA5ZmE0 Li5jYzE5ZTBhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2lu ZV9jcy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMKPiBA QCAtNzk2LDYgKzc5NiwyNyBAQCBjb25zdCBjaGFyICppOTE1X2NhY2hlX2xldmVsX3N0cihzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwgaW50IHR5cGUpCj4gICAJfQo+ICAgfQo+ICAgCj4g K3N0YXRpYyB1MzIgY2FsY3VsYXRlX21jcih1MzIgbWNyLCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYpCgpkZXZfcHJpdiBmaXJzdCB3b3VsZCBiZSBtb3JlIHR5cGljYWwgZnVuY3Rp b24gYXJndW1lbnQgb3JkZXIuCgo+ICt7Cj4gKwljb25zdCBzdHJ1Y3Qgc3NldV9kZXZfaW5mbyAq c3NldSA9ICYoSU5URUxfU1NFVShkZXZfcHJpdikpOwo+ICsJdTMyIHNsaWNlID0gZmxzKHNzZXUt PnNsaWNlX21hc2spOwo+ICsJdTMyIHN1YnNsaWNlID0gZmxzKHNzZXUtPnN1YnNsaWNlX21hc2tb c2xpY2VdKTsKPiArCj4gKwltY3IgJj0gfihHRU44X01DUl9TTElDRV9NQVNLIHwgR0VOOF9NQ1Jf U1VCU0xJQ0VfTUFTSyk7Cj4gKwltY3IgfD0gR0VOOF9NQ1JfU0xJQ0Uoc2xpY2UpIHwgR0VOOF9N Q1JfU1VCU0xJQ0Uoc3Vic2xpY2UpOwo+ICsKPiArCXJldHVybiBtY3I7Cj4gK30KPiArCj4gK3N0 YXRpYyB2b2lkIHdhX2luaXRfbWNyKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikK PiArewo+ICsJdTMyIG1jcjsKPiArCj4gKwltY3IgPSBJOTE1X1JFQUQoR0VOOF9NQ1JfU0VMRUNU T1IpOwo+ICsJbWNyID0gY2FsY3VsYXRlX21jcihtY3IsIGRldl9wcml2KTsKPiArCUk5MTVfV1JJ VEUoR0VOOF9NQ1JfU0VMRUNUT1IsIG1jcik7Cj4gK30KPiArCj4gICBzdGF0aWMgaW5saW5lIHVp bnQzMl90Cj4gICByZWFkX3N1YnNsaWNlX3JlZyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYsIGludCBzbGljZSwKPiAgIAkJICBpbnQgc3Vic2xpY2UsIGk5MTVfcmVnX3QgcmVnKQo+ IEBAIC04MjgsMTggKzg0OSwyOSBAQCByZWFkX3N1YnNsaWNlX3JlZyhzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYsIGludCBzbGljZSwKPiAgIAlpbnRlbF91bmNvcmVfZm9yY2V3YWtl X2dldF9fbG9ja2VkKGRldl9wcml2LCBmd19kb21haW5zKTsKPiAgIAo+ICAgCW1jciA9IEk5MTVf UkVBRF9GVyhHRU44X01DUl9TRUxFQ1RPUik7Cj4gKwo+ICAgCS8qCj4gICAJICogVGhlIEhXIGV4 cGVjdHMgdGhlIHNsaWNlIGFuZCBzdWJsaWNlIHNlbGVjdG9ycyB0byBiZSByZXNldCB0byAwCj4g ICAJICogYWZ0ZXIgcmVhZGluZyBvdXQgdGhlIHJlZ2lzdGVycy4KPiAgIAkgKi8KPiAtCVdBUk5f T05fT05DRShtY3IgJiBtY3Jfc2xpY2Vfc3Vic2xpY2VfbWFzayk7Cj4gKwlpZiAoSU5URUxfR0VO KGRldl9wcml2KSA8IDEwKQo+ICsJCVdBUk5fT05fT05DRShtY3IgJiBtY3Jfc2xpY2Vfc3Vic2xp Y2VfbWFzayk7CgpDYW4gc3F1YXNoIHRvIHNpbmdsZSBsaW5lIFdBUk5fT05fT05DRShJTlRFTF9H RU4oKSA8IDEwICYmIChtY3IgJiAuLi4pKSwgCmlmIGl0IGZpdHMuCgo+ICAgCW1jciAmPSB+bWNy X3NsaWNlX3N1YnNsaWNlX21hc2s7Cj4gICAJbWNyIHw9IG1jcl9zbGljZV9zdWJzbGljZV9zZWxl Y3Q7Cj4gICAJSTkxNV9XUklURV9GVyhHRU44X01DUl9TRUxFQ1RPUiwgbWNyKTsKPiAgIAo+ICAg CXJldCA9IEk5MTVfUkVBRF9GVyhyZWcpOwo+ICAgCj4gLQltY3IgJj0gfm1jcl9zbGljZV9zdWJz bGljZV9tYXNrOwo+ICsJLyoKPiArCSAqIFdhUHJvZ3JhbU1nc3JGb3JDb3JyZWN0U2xpY2VTcGVj aWZpY01taW9SZWFkczpjbmwKPiArCSAqIGV4cGVjdHMgbWNyIHRvIGJlIHByb2dyYW1lZCB0byBh IGVuYWJsZWQgc2xpY2Uvc3Vic2xpY2UgcGFpcgo+ICsJICogYmVmb3JlIGFueSBNTUlPIHJlYWQg aW50byBzbGljZS9zdWJzbGljZSByZWdpc3Rlcgo+ICsJICovCj4gKwlpZiAoSU5URUxfR0VOKGRl dl9wcml2KSA8IDEwKQo+ICsJCW1jciAmPSB+bWNyX3NsaWNlX3N1YnNsaWNlX21hc2s7Cj4gKwll bHNlCj4gKwkJbWNyID0gY2FsY3VsYXRlX21jcihtY3IsIGRldl9wcml2KTsKCkRvZXMgaXQgbWFr ZSBzZW5zZSB0byBtb3ZlIHRoZSBjb25kaXRpb25hbCBhbmQgY29tbWVudCB0byBjYWxjdWxhdGVf bWNyIAotIHNvIGhlcmUgb25seSBhIHNpbmdsZSBjYWxsIHRvIGl0IHJlbWFpbnM/Cgo+ICsKPiAg IAlJOTE1X1dSSVRFX0ZXKEdFTjhfTUNSX1NFTEVDVE9SLCBtY3IpOwo+ICAgCj4gICAJaW50ZWxf dW5jb3JlX2ZvcmNld2FrZV9wdXRfX2xvY2tlZChkZXZfcHJpdiwgZndfZG9tYWlucyk7Cj4gQEAg LTEzMDcsNiArMTMzOSw5IEBAIHN0YXRpYyBpbnQgY25sX2luaXRfd29ya2Fyb3VuZHMoc3RydWN0 IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiA9IGVuZ2luZS0+aTkxNTsKPiAgIAlpbnQgcmV0Owo+ICAgCj4gKwkvKiBXYVByb2dy YW1NZ3NyRm9yQ29ycmVjdFNsaWNlU3BlY2lmaWNNbWlvUmVhZHM6IGNubCAqLwo+ICsJd2FfaW5p dF9tY3IoZGV2X3ByaXYpOwo+ICsKPiAgIAkvKiBXYURpc2FibGVJMm1DeWNsZU9uV1JQb3J0OmNu bCAocHJlLXByb2QpICovCj4gICAJaWYgKElTX0NOTF9SRVZJRChkZXZfcHJpdiwgQ05MX1JFVklE X0IwLCBDTkxfUkVWSURfQjApKQo+ICAgCQlJOTE1X1dSSVRFKEdBTVRfQ0hLTl9CSVRfUkVHLAo+ IAoKQWJvdmUgYXJlIHN1Z2dlc3Rpb25zIGFuZCBxdWVzdGlvbnMgb25seS4KClJlZ2FyZHMsCgpU dnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==