From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4C02C433E6 for ; Fri, 28 Aug 2020 08:55:37 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A3462206EB for ; Fri, 28 Aug 2020 08:55:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A3462206EB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kBaAS-0003kQ-06; Fri, 28 Aug 2020 08:55:28 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kBaAR-0003kJ-6O for xen-devel@lists.xenproject.org; Fri, 28 Aug 2020 08:55:27 +0000 X-Inumbo-ID: f145242c-fb9b-4541-b68e-388bb6e3a04c Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f145242c-fb9b-4541-b68e-388bb6e3a04c; Fri, 28 Aug 2020 08:55:26 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 17005B64B; Fri, 28 Aug 2020 08:55:58 +0000 (UTC) Subject: Re: [PATCH v2 8/8] x86/msr: Drop compatibility #GP handling in guest_{rd,wr}msr() To: Roger Pau Monne , Andrew Cooper Cc: xen-devel@lists.xenproject.org, Wei Liu References: <20200820150835.27440-1-roger.pau@citrix.com> <20200820150835.27440-9-roger.pau@citrix.com> From: Jan Beulich Message-ID: Date: Fri, 28 Aug 2020 10:55:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200820150835.27440-9-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 20.08.2020 17:08, Roger Pau Monne wrote: > Now that the main PV/HVM MSR handlers raise #GP for all unknown MSRs, there is > no need to special case these MSRs any more. I agree, yet I'd like to point out (based on past backporting of security fixes) that this change may end up being a good source of backporting mistakes, as 4.14 may need chunks added here which on master / staging have no place anymore. Jan