From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52BA4C433FE for ; Sun, 20 Feb 2022 09:32:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243570AbiBTJcx (ORCPT ); Sun, 20 Feb 2022 04:32:53 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:40768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243557AbiBTJcu (ORCPT ); Sun, 20 Feb 2022 04:32:50 -0500 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9908F08 for ; Sun, 20 Feb 2022 01:32:29 -0800 (PST) Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 03EB73F1A1 for ; Sun, 20 Feb 2022 09:32:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1645349545; bh=LKjm5LjPQkt9S6ejT9o1cKax4Elbs5PxSQyHCZobrC4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Q6OCEx1Bg2L56MLf/PdqvL+Bg03Lxj5EHWqRtkRuhloOSmP5LswWVHN0398sT301M pHYgl9IPge4pFhY5w81qdKNCKPEpzdtR3VX+t4epKNx5NGJ0Qt4ekGmbQa7/3Q4tZP jpOfOBVbleUWbJC+ak39pSxZmI/UAghvcfZOZDlveAMZ3TUdlNY1+vFeTxQslLZ2rn 4ZtqlR0q663owQuws6HT7t9A1OM5/lz07QlOfbmcYArphKDxTCo/zq9zKA1GcSnqXk ydWJtkfHqVhK7uiRaiWoZIxZn3Vd3rP1ohWz2sMc+i9zlElQ9qDcie0SUzeufwEhoy ThBSg0NRMjd7g== Received: by mail-wr1-f70.google.com with SMTP id g11-20020adfa48b000000b001e57dfb3c38so5659365wrb.2 for ; Sun, 20 Feb 2022 01:32:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=LKjm5LjPQkt9S6ejT9o1cKax4Elbs5PxSQyHCZobrC4=; b=EqaiuyfRXi7sAahHD+atDPgeMYc1ANRFqPJLkssbeJO7sYzx2iJgLW/odcOUwDCpnF XwBA4UUouWnIl7TYRPDp87GbMhRDvPJsshbGxjFTaCiuNfLlPo7oqO1k4y9QVTKzcnG7 pQGITY6KMzMLHU0zWrmY+HOJLD6D1pAXjKLtCOrGO1ja6zhLeE4WAZNVJBWMhNyGT5/T gqAUdlxjfq/f+OW7qLmnL4tepuhnaZh1pwx35SQAwLJl30H8pBdGlm4KLlVTD+wzngJN 4EHQZhtfzYCdcyg69v6C1zj0i6Q5qsPmj41E4d/MNM1hBEIejKHp5tLzQgKgo/7wTISq pI6g== X-Gm-Message-State: AOAM5325Q4n7AAwyTbGfpi10aVpWl658uyoe7cS37lQESLxgPIsNGs91 Z3OZnUIjCT3+9IkgB2f41eDjt3hjXonTTQXCzMu+rf5E6/KF5R0m5jlmHmYSj+WbLyK1Daf6Qr4 VKm5oWNCTvrqdyPiy7QU+meH7rsQKjBbpijXkJ3ZTPA== X-Received: by 2002:a05:600c:230d:b0:37d:5882:ec9b with SMTP id 13-20020a05600c230d00b0037d5882ec9bmr17101264wmo.162.1645349544118; Sun, 20 Feb 2022 01:32:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJx5VMR9zGe0H8y1LkWbw0H010mPlQxgB9BfhaHQlQDN2Ch3MW7W25dEBO2fUvk53yZ3IM4IIw== X-Received: by 2002:a05:600c:230d:b0:37d:5882:ec9b with SMTP id 13-20020a05600c230d00b0037d5882ec9bmr17101254wmo.162.1645349543973; Sun, 20 Feb 2022 01:32:23 -0800 (PST) Received: from [192.168.0.117] (xdsl-188-155-181-108.adslplus.ch. [188.155.181.108]) by smtp.gmail.com with ESMTPSA id i3sm50975818wrq.72.2022.02.20.01.32.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Feb 2022 01:32:23 -0800 (PST) Message-ID: Date: Sun, 20 Feb 2022 10:32:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 04/11] i2c: npcm: Update gcr property name Content-Language: en-US To: Tyrone Ting , avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, robh+dt@kernel.org, semen.protsenko@linaro.org, yangyicong@hisilicon.com, wsa@kernel.org, jie.deng@intel.com, sven@svenpeter.dev, bence98@sch.bme.hu, christophe.leroy@csgroup.eu, lukas.bulwahn@gmail.com, olof@lixom.net, arnd@arndb.de, digetx@gmail.com, andriy.shevchenko@linux.intel.com, tali.perry@nuvoton.com, Avi.Fishman@nuvoton.com, tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, JJLIU0@nuvoton.com, kfting@nuvoton.com Cc: openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220220035321.3870-1-warp5tw@gmail.com> <20220220035321.3870-5-warp5tw@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220220035321.3870-5-warp5tw@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/02/2022 04:53, Tyrone Ting wrote: > From: Tali Perry > > Use a generic name for NPCM system manager reigster. The subject is not accurate and you entirely skipped in commit msg the fact of an ABI break. You do not update a property name but you change the way of getting GCR regmap. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7899C433EF for ; Mon, 21 Feb 2022 05:20:16 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4K29bz0L1nz2yR8 for ; Mon, 21 Feb 2022 16:20:15 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=t/IDl4ux; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=canonical.com (client-ip=185.125.188.122; helo=smtp-relay-internal-0.canonical.com; envelope-from=krzysztof.kozlowski@canonical.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=t/IDl4ux; dkim-atps=neutral Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4K1gFW6fg3z2yHL for ; Sun, 20 Feb 2022 20:32:31 +1100 (AEDT) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id EE84A402FE for ; Sun, 20 Feb 2022 09:32:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1645349548; bh=LKjm5LjPQkt9S6ejT9o1cKax4Elbs5PxSQyHCZobrC4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=t/IDl4ux/CLFTFp9z0v3Mj4sMJ+qwqj4KL/i64A6jTQuFGTlCKg4aVe2qMwRib4FT PyfYTQeJ68q8+y+8Vr6q+yFnlBK8vHp7DI65rWhPdWVixHt6X/wH7n/UN7kvfRlG5t Tp7/YhwXAEjMt5bDKxcBEvAxLbckx2hllA8J+t6HeIILkaMjjlogaz4ywOZOADZuFA 1UBML1KnAKSHaD3qjBsuZMuchcFzTMeI8hjD95GJWEc0ydrOdd4fFVVxpmpPyBwRBX 8zHg8CGA1RTCF0mHHJS5CXdWXE/oRAiSSAw9Ioua/736ym5XV2Uq7ESTeeaZSQ91wv 3W+S86/vp5tcA== Received: by mail-wr1-f69.google.com with SMTP id s5-20020adfbc05000000b001e7af4f2231so5694606wrg.3 for ; Sun, 20 Feb 2022 01:32:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=LKjm5LjPQkt9S6ejT9o1cKax4Elbs5PxSQyHCZobrC4=; b=PLDJSWIzQCj8tUTskCsfaWmxqVpSpZm3MkhDXTFeJRXKdeSNH6B3JMElVbyntsiXo1 uXwsPR+PslKbsgoGyywvvahMjQ+2VCduysbpAI1V/O76+wfj1/XmrIJlBv4ugpICoW/n zbQT9k9BvhDSq/B9QpbBHJ9hLvh5h3BeZK5WI0KioMM4NEqqcGL/G0SjktRzWJIF8201 SM6T144P72XLBBun0GG65+vl3iT0eltjUwv0pyhV3trDlY9Yy3s0yM6LVewN7GmiQfUN UGRWTkZR1k8QiLQX667K3FpHNAl9UBn7L1T7SWQTJVLkjLMF1IKq5lFqEwzia+x1GN6h wjqA== X-Gm-Message-State: AOAM533Fh3zMXWv2WOujjSH1qB/SAsa1IUi1dcaGA9SXQyelPUjMnuEP rxHXW5Y1qwqEtCp3W8VQ2jFT6Ntydt66XYNZ5Wg7GwrN0Uba19fjbm9FJTMz7v85Cyoexb0KNOy odaVXTurNeCg5LbIrgVWUbqRTG/Ndv2pa5AzF X-Received: by 2002:a05:600c:230d:b0:37d:5882:ec9b with SMTP id 13-20020a05600c230d00b0037d5882ec9bmr17101283wmo.162.1645349544139; Sun, 20 Feb 2022 01:32:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJx5VMR9zGe0H8y1LkWbw0H010mPlQxgB9BfhaHQlQDN2Ch3MW7W25dEBO2fUvk53yZ3IM4IIw== X-Received: by 2002:a05:600c:230d:b0:37d:5882:ec9b with SMTP id 13-20020a05600c230d00b0037d5882ec9bmr17101254wmo.162.1645349543973; Sun, 20 Feb 2022 01:32:23 -0800 (PST) Received: from [192.168.0.117] (xdsl-188-155-181-108.adslplus.ch. [188.155.181.108]) by smtp.gmail.com with ESMTPSA id i3sm50975818wrq.72.2022.02.20.01.32.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Feb 2022 01:32:23 -0800 (PST) Message-ID: Date: Sun, 20 Feb 2022 10:32:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 04/11] i2c: npcm: Update gcr property name Content-Language: en-US To: Tyrone Ting , avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, robh+dt@kernel.org, semen.protsenko@linaro.org, yangyicong@hisilicon.com, wsa@kernel.org, jie.deng@intel.com, sven@svenpeter.dev, bence98@sch.bme.hu, christophe.leroy@csgroup.eu, lukas.bulwahn@gmail.com, olof@lixom.net, arnd@arndb.de, digetx@gmail.com, andriy.shevchenko@linux.intel.com, tali.perry@nuvoton.com, Avi.Fishman@nuvoton.com, tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, JJLIU0@nuvoton.com, kfting@nuvoton.com References: <20220220035321.3870-1-warp5tw@gmail.com> <20220220035321.3870-5-warp5tw@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220220035321.3870-5-warp5tw@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Mon, 21 Feb 2022 16:10:35 +1100 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On 20/02/2022 04:53, Tyrone Ting wrote: > From: Tali Perry > > Use a generic name for NPCM system manager reigster. The subject is not accurate and you entirely skipped in commit msg the fact of an ABI break. You do not update a property name but you change the way of getting GCR regmap. Best regards, Krzysztof